From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>,
rafael@kernel.org, daniel.lezcano@kernel.org
Cc: "Zhang Rui" <rui.zhang@intel.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Russell King" <linux+etnaviv@armlinux.org.uk>,
"Christian Gmeiner" <christian.gmeiner@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Guenter Roeck" <linux@roeck-us.net>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Benson Leung" <bleung@chromium.org>,
"Pali Rohár" <pali@kernel.org>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Amit Daniel Kachhap" <amit.kachhap@gmail.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 04/10] thermal/core: Make cooling device OF node conditional on CONFIG_THERMAL_OF
Date: Fri, 29 May 2026 14:27:52 +0100 [thread overview]
Message-ID: <a1d2999a-7d87-42d0-ad1b-65823eca3b9f@arm.com> (raw)
In-Reply-To: <20260526140802.1059293-16-daniel.lezcano@oss.qualcomm.com>
On 5/26/26 15:08, Daniel Lezcano wrote:
> The device node pointer stored in struct thermal_cooling_device is
> only used by the OF-specific thermal code to associate cooling devices
> with thermal zones defined in device tree.
>
> Now that OF and non-OF registration paths are separated and non-OF
> users no longer rely on devm_thermal_of_cooling_device_register() with
> a NULL device node, the np field is no longer required for non-OF
> configurations.
>
> Make this field conditional on CONFIG_THERMAL_OF to reduce memory
> footprint and better reflect its usage.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
> include/linux/thermal.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index fc3f4a098370..60e596e7d7ae 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -125,7 +125,6 @@ struct thermal_cooling_device {
> const char *type;
> unsigned long max_state;
> struct device device;
> - struct device_node *np;
> void *devdata;
> void *stats;
> const struct thermal_cooling_device_ops *ops;
> @@ -133,6 +132,9 @@ struct thermal_cooling_device {
> struct mutex lock; /* protect thermal_instances list */
> struct list_head thermal_instances;
> struct list_head node;
> +#ifdef CONFIG_THERMAL_OF
> + struct device_node *np;
> +#endif
> #ifdef CONFIG_THERMAL_DEBUGFS
> struct thermal_debugfs *debugfs;
> #endif
I've done compilation w/o THERMAL_OF set because it
was a bit odd...
It triggers an issue in the thermal_core.c at:
cdev->np which is left. This might break some bisect
in the suture if that would be the case.
drivers/thermal/thermal_core.c: In function
‘thermal_of_cooling_device_register’:
drivers/thermal/thermal_core.c:1121:13: error: ‘struct
thermal_cooling_device’ has no member named ‘np’
1121 | cdev->np = np;
| ^~
make[4]: *** [scripts/Makefile.build:289:
drivers/thermal/thermal_core.o] Error 1
make[3]: *** [scripts/Makefile.build:548: drivers/thermal] Error 2
make[3]: *** Waiting for unfinished jobs....
Let's maybe change the order with patch 05/10 ?
next prev parent reply other threads:[~2026-05-29 13:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 14:08 [PATCH v3 00/11] Support cooling device with ID in the OF Daniel Lezcano
2026-05-26 14:08 ` [PATCH v4 01/10] thermal/core: Introduce non-OF thermal_cooling_device_register() Daniel Lezcano
2026-05-29 9:47 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 02/10] thermal/core: Add devm_thermal_cooling_device_register() Daniel Lezcano
2026-05-29 12:55 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 03/10] hwmon: Use non-OF thermal cooling device registration API Daniel Lezcano
2026-05-29 12:55 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 04/10] thermal/core: Make cooling device OF node conditional on CONFIG_THERMAL_OF Daniel Lezcano
2026-05-29 13:27 ` Lukasz Luba [this message]
2026-05-26 14:08 ` [PATCH v4 05/10] thermal/of: Move cooling device OF helpers out of thermal core Daniel Lezcano
2026-05-29 13:26 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 06/10] thermal/of: Rename the devm_thermal_of_cooling_device_register() function Daniel Lezcano
2026-05-29 15:17 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 07/10] thermal/of: Add cooling device ID support Daniel Lezcano
2026-05-29 15:18 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 08/10] thermal/of: Pass cdev_id and introduce devm registration helper Daniel Lezcano
2026-05-29 15:21 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 09/10] thermal/of: Support cooling device ID in cooling-spec Daniel Lezcano
2026-05-29 15:25 ` Lukasz Luba
2026-05-26 14:08 ` [PATCH v4 10/10] dt-bindings: thermal: cooling-devices: Update support for 3 cells cooling device Daniel Lezcano
2026-05-29 15:26 ` Lukasz Luba
2026-05-29 8:35 ` [PATCH vs/3/4/ 00/11] Support cooling device with ID in the OF Daniel Lezcano
2026-05-29 12:35 ` Rafael J. Wysocki
2026-05-29 12:41 ` Daniel Lezcano
2026-05-29 15:29 ` Lukasz Luba
2026-05-29 15:31 ` Daniel Lezcano
2026-05-29 17:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1d2999a-7d87-42d0-ad1b-65823eca3b9f@arm.com \
--to=lukasz.luba@arm.com \
--cc=airlied@gmail.com \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=bleung@chromium.org \
--cc=christian.gmeiner@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=daniel.lezcano@oss.qualcomm.com \
--cc=heiko@sntech.de \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
--cc=neil.armstrong@linaro.org \
--cc=pali@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=simona@ffwll.ch \
--cc=tali.perry1@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=viresh.kumar@linaro.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®