From: David Heidelberg <david@ixit.cz>
To: Bryan O'Donoghue <bod.linux@nxsw.ie>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Petr Hodina <phodina@protonmail.com>,
Casey Connolly <casey.connolly@linaro.org>,
"Dr. Git" <drgitx@gmail.com>, Cory Keitz <ckeitz@amazon.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Joel Selvaraj <foss@joelselvaraj.com>,
Kieran Bingham <kbingham@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH WIP v5 6/9] media: qcom: camss: csiphy-3ph: Update Gen2 v1.1 MIPI CSI-2 C-PHY init
Date: Mon, 1 Jun 2026 19:02:57 +0200 [thread overview]
Message-ID: <a547e784-9e24-4dba-abcb-6c22130af2f2@ixit.cz> (raw)
In-Reply-To: <eff110a1-4161-4190-a0b2-7a1139a85d52@nxsw.ie>
On 01/06/2026 18:03, Bryan O'Donoghue wrote:
> On 31/05/2026 14:08, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> These values should improve C-PHY behaviour. Should match most recent
>> Qualcomm code.
>>
>> Acked-by: Cory Keitz <ckeitz@amazon.com>
>> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> .../media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> index d837fcf7cd2f0..9a0f009c033bb 100644
>> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
>> @@ -220,19 +220,19 @@ csiphy_lane_regs lane_regs_sdm845[] = {
>> {0x0660, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0664, 0x7F, 0x00, CSIPHY_DEFAULT_PARAMS},
>> };
>>
>> /* GEN2 1.0 3PH */
>> /* 3 entries: 3 lanes (C-PHY) */
>> static const struct
>> csiphy_lane_regs lane_regs_sdm845_3ph[] = {
>> - {0x015c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS},
>> - {0x0168, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS},
>> - {0x016c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x015c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x0168, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x016c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0104, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x010c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
>> {0x0108, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE},
>> {0x0114, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0150, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0118, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x011c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0120, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> @@ -240,19 +240,19 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = {
>> {0x0128, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x012c, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0144, 0x12, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0160, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x01cc, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0164, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x01dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS},
>>
>> - {0x035c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS},
>> - {0x0368, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS},
>> - {0x036c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x035c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x0368, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x036c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0304, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x030c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
>> {0x0308, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE},
>> {0x0314, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0350, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0318, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x031c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0320, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> @@ -260,19 +260,19 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = {
>> {0x0328, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x032c, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0344, 0x12, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0360, 0x02, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x03cc, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0364, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x03dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS},
>>
>> - {0x055c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS},
>> - {0x0568, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS},
>> - {0x056c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x055c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x0568, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS},
>> + {0x056c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0504, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x050c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE},
>> {0x0508, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE},
>> {0x0514, 0x20, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0550, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0518, 0x3e, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x051c, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>> {0x0520, 0x41, 0x00, CSIPHY_DEFAULT_PARAMS},
>>
>> --
>> 2.53.0
>>
>>
>>
>
> Squash this down !
Document the regs !
But now seriously - it's nice to have at least commit documenting what these
change doing.
In previous discussion [1] we agreed on keeping this commit.
David
[1]
https://lore.kernel.org/linux-media/be4abbc8-414a-429d-baff-48c829378a31@linaro.org/
>
> ---
> bod
>
--
David Heidelberg
next prev parent reply other threads:[~2026-06-01 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 13:08 [PATCH WIP v5 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms David Heidelberg via B4 Relay
2026-05-31 13:08 ` [PATCH WIP v5 1/9] media: qcom: camss: csiphy: Introduce PHY configuration David Heidelberg via B4 Relay
2026-06-01 15:57 ` Bryan O'Donoghue
2026-05-31 13:08 ` [PATCH WIP v5 2/9] media: qcom: camss: csiphy-3ph: Use odd bits for configuring C-PHY lanes David Heidelberg via B4 Relay
2026-06-01 8:49 ` Sakari Ailus
2026-06-01 12:48 ` David Heidelberg
2026-06-01 15:59 ` Bryan O'Donoghue
2026-05-31 13:08 ` [PATCH WIP v5 3/9] media: qcom: camss: Prepare CSID for C-PHY support David Heidelberg via B4 Relay
2026-05-31 13:08 ` [PATCH WIP v5 4/9] media: qcom: camss: Initialize lanes after lane configuration is available David Heidelberg via B4 Relay
2026-06-01 9:00 ` Sakari Ailus
2026-06-01 12:52 ` David Heidelberg
2026-05-31 13:08 ` [PATCH WIP v5 5/9] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 C-PHY init David Heidelberg via B4 Relay
2026-05-31 13:08 ` [PATCH WIP v5 6/9] media: qcom: camss: csiphy-3ph: Update " David Heidelberg via B4 Relay
2026-06-01 16:03 ` Bryan O'Donoghue
2026-06-01 17:02 ` David Heidelberg [this message]
2026-05-31 13:08 ` [PATCH WIP v5 7/9] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.1 " David Heidelberg via B4 Relay
2026-05-31 13:08 ` [PATCH WIP v5 8/9] media: qcom: camss: Account for C-PHY when calculating link frequency David Heidelberg via B4 Relay
2026-05-31 13:08 ` [PATCH WIP v5 9/9] media: qcom: camss: Enable C-PHY where available David Heidelberg via B4 Relay
2026-06-01 16:06 ` Bryan O'Donoghue
2026-06-01 15:56 ` [PATCH WIP v5 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a547e784-9e24-4dba-abcb-6c22130af2f2@ixit.cz \
--to=david@ixit.cz \
--cc=bod.linux@nxsw.ie \
--cc=bryan.odonoghue@linaro.org \
--cc=casey.connolly@linaro.org \
--cc=ckeitz@amazon.com \
--cc=drgitx@gmail.com \
--cc=foss@joelselvaraj.com \
--cc=kbingham@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=phodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®