* [PATCH v5 1/2] selftests/resctrl: Implement cl_flush() and sb() for aarch64
2026-10-12 7:47 [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64 Richard Cheng
@ 2026-10-12 7:47 ` Richard Cheng
2026-10-20 16:30 ` Ben Horgan
2026-10-12 7:47 ` [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT Richard Cheng
2026-10-12 22:09 ` [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64 Reinette Chatre
2 siblings, 1 reply; 9+ messages in thread
From: Richard Cheng @ 2026-10-12 7:47 UTC (permalink / raw)
To: tony.luck, reinette.chatre, x86, shuah, fenghuay
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc,
Richard Cheng
cl_flush() and sb() compile to empty functions on aarch64, making
mem_flush() a silent no-op and leaving CMT/CAT tests operating on
unflushed state.
Add "dsb sy" for sb(), ARM requires a DSB whose access type covers both
loads and stores.
For cl_flush(), "dc civac" only reaches the Point of Coherency, on
ARM MPAM systems the SLC lies past the PoC and may be a NOP on coherent
platforms. Instead, dirty each cacheline with a store so that
mem_flush's full-buffer sweep evicts lines from the SLC via LRU
pressure.
Signed-off-by: Richard Cheng <icheng@nvidia.com>
---
tools/testing/selftests/resctrl/fill_buf.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
index b9fa7968cd6e..eae0262fe265 100644
--- a/tools/testing/selftests/resctrl/fill_buf.c
+++ b/tools/testing/selftests/resctrl/fill_buf.c
@@ -27,6 +27,9 @@ static void sb(void)
#if defined(__i386) || defined(__x86_64)
asm volatile("sfence\n\t"
: : : "memory");
+#elif defined(__aarch64__)
+ asm volatile("dsb sy\n\t"
+ : : : "memory");
#endif
}
@@ -35,6 +38,14 @@ static void cl_flush(void *p)
#if defined(__i386) || defined(__x86_64)
asm volatile("clflush (%0)\n\t"
: : "r"(p) : "memory");
+#elif defined(__aarch64__)
+ /*
+ * Dirty the cache line with a store. As mem_flush() sweeps
+ * the full test buffer (sized larger than the SLC), cache pressure
+ * evicts lines from the SLC via LRU replacement.
+ */
+ asm volatile("strb wzr, [%0]\n\t"
+ : : "r"(p) : "memory");
#endif
}
--
2.43.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v5 1/2] selftests/resctrl: Implement cl_flush() and sb() for aarch64
2026-10-12 7:47 ` [PATCH v5 1/2] selftests/resctrl: Implement cl_flush() and sb() for aarch64 Richard Cheng
@ 2026-10-20 16:30 ` Ben Horgan
2026-10-21 9:55 ` Ben Horgan
0 siblings, 1 reply; 9+ messages in thread
From: Ben Horgan @ 2026-10-20 16:30 UTC (permalink / raw)
To: Richard Cheng, tony.luck, reinette.chatre, x86, shuah, fenghuay
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc
Hi Richard,
Thanks for having a look at the arm64 side of the resctrl selftests. That hasn't had much love but
it would be good to have them working properly.
On 12/10/2026 08:47, Richard Cheng wrote:
> cl_flush() and sb() compile to empty functions on aarch64, making
> mem_flush() a silent no-op and leaving CMT/CAT tests operating on
> unflushed state.
>
> Add "dsb sy" for sb(), ARM requires a DSB whose access type covers both
> loads and stores.
I guess this is referring to the synchronization required for the cache maintenance instruction but
that's not what you are using in this patch.
>
> For cl_flush(), "dc civac" only reaches the Point of Coherency, on
> ARM MPAM systems the SLC lies past the PoC and may be a NOP on coherent
> platforms. Instead, dirty each cacheline with a store so that
> mem_flush's full-buffer sweep evicts lines from the SLC via LRU
> pressure.
>
> Signed-off-by: Richard Cheng <icheng@nvidia.com>
> ---
> tools/testing/selftests/resctrl/fill_buf.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
> index b9fa7968cd6e..eae0262fe265 100644
> --- a/tools/testing/selftests/resctrl/fill_buf.c
> +++ b/tools/testing/selftests/resctrl/fill_buf.c
> @@ -27,6 +27,9 @@ static void sb(void)
> #if defined(__i386) || defined(__x86_64)
> asm volatile("sfence\n\t"
> : : : "memory");
> +#elif defined(__aarch64__)
> + asm volatile("dsb sy\n\t"
> + : : : "memory");
> #endif
> }
>
> @@ -35,6 +38,14 @@ static void cl_flush(void *p)
> #if defined(__i386) || defined(__x86_64)
> asm volatile("clflush (%0)\n\t"
> : : "r"(p) : "memory");
> +#elif defined(__aarch64__)
> + /*
> + * Dirty the cache line with a store. As mem_flush() sweeps
> + * the full test buffer (sized larger than the SLC), cache pressure
> + * evicts lines from the SLC via LRU replacement.
> + */
> + asm volatile("strb wzr, [%0]\n\t"
> + : : "r"(p) : "memory");
> #endif
Isn't this cl_flush() used without changing the resctrl control and monitor group (PARTID/PMG)?
Hence, I expect you are ending up making the cache full of data associated with the identifiers that
the benchmark runs with. Is that the case?
I'm also unclear how this the cat_test will detect any performance differences on arm/MPAM as the
perf events would need to specific to the system level cache implementation.
Thanks,
Ben
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v5 1/2] selftests/resctrl: Implement cl_flush() and sb() for aarch64
2026-10-20 16:30 ` Ben Horgan
@ 2026-10-21 9:55 ` Ben Horgan
0 siblings, 0 replies; 9+ messages in thread
From: Ben Horgan @ 2026-10-21 9:55 UTC (permalink / raw)
To: Richard Cheng, tony.luck, reinette.chatre, x86, shuah, fenghuay
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc
Hi Richard,
On 20/10/2026 17:30, Ben Horgan wrote:
> Hi Richard,
>
> Thanks for having a look at the arm64 side of the resctrl selftests. That hasn't had much love but
> it would be good to have them working properly.
>
> On 12/10/2026 08:47, Richard Cheng wrote:
>> cl_flush() and sb() compile to empty functions on aarch64, making
>> mem_flush() a silent no-op and leaving CMT/CAT tests operating on
>> unflushed state.
>>
>> Add "dsb sy" for sb(), ARM requires a DSB whose access type covers both
>> loads and stores.
>
> I guess this is referring to the synchronization required for the cache maintenance instruction but
> that's not what you are using in this patch.
>
>>
>> For cl_flush(), "dc civac" only reaches the Point of Coherency, on
>> ARM MPAM systems the SLC lies past the PoC and may be a NOP on coherent
>> platforms. Instead, dirty each cacheline with a store so that
>> mem_flush's full-buffer sweep evicts lines from the SLC via LRU
>> pressure.
>>
>> Signed-off-by: Richard Cheng <icheng@nvidia.com>
>> ---
>> tools/testing/selftests/resctrl/fill_buf.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
>> index b9fa7968cd6e..eae0262fe265 100644
>> --- a/tools/testing/selftests/resctrl/fill_buf.c
>> +++ b/tools/testing/selftests/resctrl/fill_buf.c
>> @@ -27,6 +27,9 @@ static void sb(void)
>> #if defined(__i386) || defined(__x86_64)
>> asm volatile("sfence\n\t"
>> : : : "memory");
>> +#elif defined(__aarch64__)
>> + asm volatile("dsb sy\n\t"
>> + : : : "memory");
>> #endif
>> }
>>
>> @@ -35,6 +38,14 @@ static void cl_flush(void *p)
>> #if defined(__i386) || defined(__x86_64)
>> asm volatile("clflush (%0)\n\t"
>> : : "r"(p) : "memory");
>> +#elif defined(__aarch64__)
>> + /*
>> + * Dirty the cache line with a store. As mem_flush() sweeps
>> + * the full test buffer (sized larger than the SLC), cache pressure
>> + * evicts lines from the SLC via LRU replacement.
>> + */
>> + asm volatile("strb wzr, [%0]\n\t"
>> + : : "r"(p) : "memory");
>> #endif
One more thing that occurred to me is that if this is intended to evict all existing data in the
cache then it would require that the cache portions bitmap for the control group (PARTID) in use is
set to all 1s. E.g. 'L3:0=0xffff'. Otherwise, you may not affect the whole cache. This likely means
that the cl_flush() function isn't the right abstraction for MPAM and the test needs a bit of
restructuring to get this to fit in elegantly. Similarly, to the limbo handler in resctrl you could
then check the llc_occupancy() to check it's under a "low enough" threshold.
Thanks,
Ben
>
> Isn't this cl_flush() used without changing the resctrl control and monitor group (PARTID/PMG)?
> Hence, I expect you are ending up making the cache full of data associated with the identifiers that
> the benchmark runs with. Is that the case?
>
> I'm also unclear how this the cat_test will detect any performance differences on arm/MPAM as the
> perf events would need to specific to the system level cache implementation.
>
> Thanks,
>
> Ben
>
>
>
>> }
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT
2026-10-12 7:47 [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64 Richard Cheng
2026-10-12 7:47 ` [PATCH v5 1/2] selftests/resctrl: Implement cl_flush() and sb() for aarch64 Richard Cheng
@ 2026-10-12 7:47 ` Richard Cheng
2026-10-20 16:18 ` Ben Horgan
2026-10-12 22:09 ` [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64 Reinette Chatre
2 siblings, 1 reply; 9+ messages in thread
From: Richard Cheng @ 2026-10-12 7:47 UTC (permalink / raw)
To: tony.luck, reinette.chatre, x86, shuah, fenghuay
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc,
Richard Cheng, Ilpo Järvinen
aarch64 has no vendor_id in /proc/cpuinfo, so detect_vendor() returns 0
and arch_supports_noncont_cat() falls through to "return false".
L3_NONCONT_CAT therefore spuriously fails on every ARM MPAM platform.
Define ARCH_ARM, short-circuit detect_vendor() to it on aarch64, and
add it to the AMD/Hygon always-supports early-out in
arch_supports_noncont_cat().
aarch64 has many implementers (ARM 0x41, NVIDIA 0x43, etc.), but MPAM
mandates non-contiguous CPBM uniformly, so per-implementer handling is
not needed here.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Richard Cheng <icheng@nvidia.com>
---
tools/testing/selftests/resctrl/cat_test.c | 9 ++++++--
tools/testing/selftests/resctrl/resctrl.h | 1 +
.../testing/selftests/resctrl/resctrl_tests.c | 21 +++++++++++++++++++
3 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
index 0a417267dd74..f4b02b3eedd7 100644
--- a/tools/testing/selftests/resctrl/cat_test.c
+++ b/tools/testing/selftests/resctrl/cat_test.c
@@ -271,8 +271,13 @@ static bool arch_supports_noncont_cat(const struct resctrl_test *test)
{
unsigned int vendor_id = get_vendor();
- /* AMD and Hygon always support non-contiguous CBM. */
- if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON)
+ /*
+ * AMD and Hygon always support non-contiguous CBM. ARM/MPAM defines
+ * MPAMCFG_CPBM as a bitmap with no contiguity constraint per ARM
+ * DDI 0598.
+ */
+ if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON ||
+ vendor_id == ARCH_ARM)
return true;
#if defined(__i386__) || defined(__x86_64__) /* arch */
diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
index a7556cdae0de..03b4500c1f7f 100644
--- a/tools/testing/selftests/resctrl/resctrl.h
+++ b/tools/testing/selftests/resctrl/resctrl.h
@@ -41,6 +41,7 @@
#define ARCH_INTEL BIT(0)
#define ARCH_AMD BIT(1)
#define ARCH_HYGON BIT(2)
+#define ARCH_ARM BIT(3)
#define END_OF_TESTS 1
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index dbcd5eea9fbc..cfece594a8c6 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -23,6 +23,15 @@ static struct resctrl_test *resctrl_tests[] = {
&l2_noncont_cat_test,
};
+static bool detect_aarch64(void)
+{
+#if defined(__aarch64__)
+ return true;
+#else
+ return false;
+#endif
+}
+
static unsigned int detect_vendor(void)
{
static unsigned int vendor_id;
@@ -34,6 +43,18 @@ static unsigned int detect_vendor(void)
if (initialized)
return vendor_id;
+ if (detect_aarch64()) {
+ /*
+ * aarch64 has no userspace vendor_id in /proc/cpuinfo.
+ * MPAM-capable ARM implementations follow ARM DDI 0598;
+ * treat all aarch64 builds as a single vendor for the
+ * purposes of resctrl selftests.
+ */
+ vendor_id = ARCH_ARM;
+ initialized = true;
+ return vendor_id;
+ }
+
inf = fopen("/proc/cpuinfo", "r");
if (!inf) {
vendor_id = 0;
--
2.43.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT
2026-10-12 7:47 ` [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT Richard Cheng
@ 2026-10-20 16:18 ` Ben Horgan
2026-10-21 14:56 ` Reinette Chatre
0 siblings, 1 reply; 9+ messages in thread
From: Ben Horgan @ 2026-10-20 16:18 UTC (permalink / raw)
To: Richard Cheng, tony.luck, reinette.chatre, x86, shuah, fenghuay
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc,
Ilpo Järvinen
Hi Richard,
On 12/10/2026 08:47, Richard Cheng wrote:
> aarch64 has no vendor_id in /proc/cpuinfo, so detect_vendor() returns 0
> and arch_supports_noncont_cat() falls through to "return false".
> L3_NONCONT_CAT therefore spuriously fails on every ARM MPAM platform.
>
> Define ARCH_ARM, short-circuit detect_vendor() to it on aarch64, and
> add it to the AMD/Hygon always-supports early-out in
> arch_supports_noncont_cat().
>
> aarch64 has many implementers (ARM 0x41, NVIDIA 0x43, etc.), but MPAM
> mandates non-contiguous CPBM uniformly, so per-implementer handling is
> not needed here.
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Richard Cheng <icheng@nvidia.com>
> ---
> tools/testing/selftests/resctrl/cat_test.c | 9 ++++++--
> tools/testing/selftests/resctrl/resctrl.h | 1 +
> .../testing/selftests/resctrl/resctrl_tests.c | 21 +++++++++++++++++++
> 3 files changed, 29 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index 0a417267dd74..f4b02b3eedd7 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -271,8 +271,13 @@ static bool arch_supports_noncont_cat(const struct resctrl_test *test)
> {
> unsigned int vendor_id = get_vendor();
>
> - /* AMD and Hygon always support non-contiguous CBM. */
> - if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON)
> + /*
> + * AMD and Hygon always support non-contiguous CBM. ARM/MPAM defines
> + * MPAMCFG_CPBM as a bitmap with no contiguity constraint per ARM
> + * DDI 0598.
> + */
> + if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON ||
> + vendor_id == ARCH_ARM)
> return true;
Would it be better not to just to use the information resctrl advertises?
/sys/fs/resctrl/info/L3/sparse_masks
Is there any reason this test doesn't use that other than being written before its introduction?
Thanks,
Ben
>
> #if defined(__i386__) || defined(__x86_64__) /* arch */
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index a7556cdae0de..03b4500c1f7f 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -41,6 +41,7 @@
> #define ARCH_INTEL BIT(0)
> #define ARCH_AMD BIT(1)
> #define ARCH_HYGON BIT(2)
> +#define ARCH_ARM BIT(3)
>
> #define END_OF_TESTS 1
>
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index dbcd5eea9fbc..cfece594a8c6 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -23,6 +23,15 @@ static struct resctrl_test *resctrl_tests[] = {
> &l2_noncont_cat_test,
> };
>
> +static bool detect_aarch64(void)
> +{
> +#if defined(__aarch64__)
> + return true;
> +#else
> + return false;
> +#endif
> +}
> +
> static unsigned int detect_vendor(void)
> {
> static unsigned int vendor_id;
> @@ -34,6 +43,18 @@ static unsigned int detect_vendor(void)
> if (initialized)
> return vendor_id;
>
> + if (detect_aarch64()) {
> + /*
> + * aarch64 has no userspace vendor_id in /proc/cpuinfo.
> + * MPAM-capable ARM implementations follow ARM DDI 0598;
> + * treat all aarch64 builds as a single vendor for the
> + * purposes of resctrl selftests.
> + */
> + vendor_id = ARCH_ARM;
> + initialized = true;
> + return vendor_id;
> + }
> +
> inf = fopen("/proc/cpuinfo", "r");
> if (!inf) {
> vendor_id = 0;
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT
2026-10-20 16:18 ` Ben Horgan
@ 2026-10-21 14:56 ` Reinette Chatre
2026-10-21 16:31 ` Ben Horgan
0 siblings, 1 reply; 9+ messages in thread
From: Reinette Chatre @ 2026-10-21 14:56 UTC (permalink / raw)
To: Ben Horgan, Richard Cheng, tony.luck, x86, shuah, fenghuay
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc,
Ilpo Järvinen
Hi Ben,
On 10/20/26 9:18 AM, Ben Horgan wrote:
> On 12/10/2026 08:47, Richard Cheng wrote:
>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>> index 0a417267dd74..f4b02b3eedd7 100644
>> --- a/tools/testing/selftests/resctrl/cat_test.c
>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>> @@ -271,8 +271,13 @@ static bool arch_supports_noncont_cat(const struct resctrl_test *test)
>> {
>> unsigned int vendor_id = get_vendor();
>>
>> - /* AMD and Hygon always support non-contiguous CBM. */
>> - if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON)
>> + /*
>> + * AMD and Hygon always support non-contiguous CBM. ARM/MPAM defines
>> + * MPAMCFG_CPBM as a bitmap with no contiguity constraint per ARM
>> + * DDI 0598.
>> + */
>> + if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON ||
>> + vendor_id == ARCH_ARM)
>> return true;
>
> Would it be better not to just to use the information resctrl advertises?
> /sys/fs/resctrl/info/L3/sparse_masks
The result of this architecture specific test is used to validate that
/sys/fs/resctrl/info/L3/sparse_masks provides accurate information.
This test was originally developed on Intel where support for
sparse masks need to be discovered from the hardware.
>
> Is there any reason this test doesn't use that other than being written before its introduction?
Reinette
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT
2026-10-21 14:56 ` Reinette Chatre
@ 2026-10-21 16:31 ` Ben Horgan
0 siblings, 0 replies; 9+ messages in thread
From: Ben Horgan @ 2026-10-21 16:31 UTC (permalink / raw)
To: Reinette Chatre, Richard Cheng, tony.luck, x86, shuah, fenghuay
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc,
Ilpo Järvinen
Hi Reinette, Richard,
On 21/10/2026 15:56, Reinette Chatre wrote:
> Hi Ben,
>
> On 10/20/26 9:18 AM, Ben Horgan wrote:
>> On 12/10/2026 08:47, Richard Cheng wrote:
>
>>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>>> index 0a417267dd74..f4b02b3eedd7 100644
>>> --- a/tools/testing/selftests/resctrl/cat_test.c
>>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>>> @@ -271,8 +271,13 @@ static bool arch_supports_noncont_cat(const struct resctrl_test *test)
>>> {
>>> unsigned int vendor_id = get_vendor();
>>>
>>> - /* AMD and Hygon always support non-contiguous CBM. */
>>> - if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON)
>>> + /*
>>> + * AMD and Hygon always support non-contiguous CBM. ARM/MPAM defines
>>> + * MPAMCFG_CPBM as a bitmap with no contiguity constraint per ARM
>>> + * DDI 0598.
Nit: DDI 0598 is retired. The new spec version is IHI0099.
>>> + */
>>> + if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON ||
>>> + vendor_id == ARCH_ARM)
>>> return true;
>>
>> Would it be better not to just to use the information resctrl advertises?
>> /sys/fs/resctrl/info/L3/sparse_masks
>
> The result of this architecture specific test is used to validate that
> /sys/fs/resctrl/info/L3/sparse_masks provides accurate information.
>
> This test was originally developed on Intel where support for
> sparse masks need to be discovered from the hardware.
Ah ok, thanks for putting me straight. The defined(__aarch64__) check looks to be the common way of
checking in the selftests. This looks fine to me.
Reviewed-by: Ben Horgan <ben.horgan@arm.com>
Thanks,
Ben
>
>>
>> Is there any reason this test doesn't use that other than being written before its introduction?
> Reinette
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64
2026-10-12 7:47 [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64 Richard Cheng
2026-10-12 7:47 ` [PATCH v5 1/2] selftests/resctrl: Implement cl_flush() and sb() for aarch64 Richard Cheng
2026-10-12 7:47 ` [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT Richard Cheng
@ 2026-10-12 22:09 ` Reinette Chatre
2 siblings, 0 replies; 9+ messages in thread
From: Reinette Chatre @ 2026-10-12 22:09 UTC (permalink / raw)
To: Richard Cheng, tony.luck, x86, shuah, fenghuay, Ben Horgan
Cc: Dave.Martin, james.morse, babu.moger, linux-kernel,
linux-kselftest, kaihengf, kobak, newtonl, kristinc
+Ben
Hi Everybody,
Could the Arm/MPAM folks please consider this series?
Thank you very much.
Reinette
On 10/12/26 12:47 AM, Richard Cheng wrote:
> This series fixes issues in the resctrl selftests on aarch64,
> where they currently misreport failures.
>
> Patch 1 adds aarch64 implementations of cl_flush() and sb() in
> fill_buf.c so cache flushes are no longer silent no-ops.
>
> Patch 2 teaches detect_vendor() about aarch64 (which exposes no
> vendor_id in /proc/cpuinfo) and lets arch_supports_noncont_cat()
> return true for ARM, fixing spurious L3_NONCONT_CAT failures.
>
> Changes since v4:
> - Drop v4 patch 1/3, which was applied to linux-kselftest/next.
> - Rebase the remaining patches onto linux-kselftest/next and
> renumber v4 patches 2/3 and 3/3 as patches 1/2 and 2/2.
> No code changes to the remaining patches.
>
> Richard Cheng (2):
> selftests/resctrl: Implement cl_flush() and sb() for aarch64
> selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT
>
> tools/testing/selftests/resctrl/cat_test.c | 9 ++++++--
> tools/testing/selftests/resctrl/fill_buf.c | 11 ++++++++++
> tools/testing/selftests/resctrl/resctrl.h | 1 +
> .../testing/selftests/resctrl/resctrl_tests.c | 21 +++++++++++++++++++
> 4 files changed, 40 insertions(+), 2 deletions(-)
>
>
> base-commit: 30af56a227e27b892d34bc44c23298b5274913e3
^ permalink raw reply [flat|nested] 9+ messages in thread