mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wasim Nazir <wasim.nazir@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	kernel@oss.qualcomm.com, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	Monish Chunara <quic_mchunara@quicinc.com>
Subject: Re: [PATCH v2 04/13] arm64: dts: qcom: lemans-evk: Add nvmem-layout for EEPROM
Date: Wed, 3 Sep 2025 21:17:38 +0530	[thread overview]
Message-ID: <aLhjGuaAybp2CeIg@hu-wasimn-hyd.qualcomm.com> (raw)
In-Reply-To: <c7b87a26-2529-4306-86b3-0b62805f0a2a@oss.qualcomm.com>

On Wed, Sep 03, 2025 at 05:12:44PM +0200, Konrad Dybcio wrote:
> On 9/3/25 5:08 PM, Wasim Nazir wrote:
> > On Wed, Sep 03, 2025 at 07:41:30PM +0530, Wasim Nazir wrote:
> >> On Wed, Sep 03, 2025 at 02:29:11PM +0200, Konrad Dybcio wrote:
> >>> On 9/3/25 1:47 PM, Wasim Nazir wrote:
> >>>> From: Monish Chunara <quic_mchunara@quicinc.com>
> >>>>
> >>>> Define the nvmem layout on the EEPROM connected via I2C to enable
> >>>> structured storage and access to board-specific configuration data,
> >>>> such as MAC addresses for Ethernet.
> >>>
> >>> The commit subject should emphasize the introduction of the EEPROM
> >>> itself, with the layout being a minor detail, yet the description of
> >>> its use which you provided is important and welcome
> >>>
> >>
> >> Thanks, Konrad, for pointing this out. I’ll update it in the next
> >> series.
> > 
> > Moreover, I notice that compatible definition is missing for this
> > EEPROM. I will add it in next series.
> 
> I think the pattern match in at24.yaml should catch it
> 

The EEPROM used on this platform is from Giantec, which requires a
dedicated compatible string.
While the generic "atmel,24c256" compatible is already supported in
at24.yaml.

-- 
Regards,
Wasim

  reply	other threads:[~2025-09-03 15:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 11:47 [PATCH v2 00/13] arm64: dts: qcom: lemans-evk: Extend board support for additional peripherals Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 01/13] dt-bindings: mmc: sdhci-msm: Document the Lemans compatible Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 02/13] arm64: dts: qcom: lemans: Add SDHC controller and SDC pin configuration Wasim Nazir
2025-09-03 15:48   ` Konrad Dybcio
2025-09-04  8:40     ` Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 03/13] arm64: dts: qcom: lemans-evk: Add TCA9534 I/O expander Wasim Nazir
2025-09-03 15:48   ` Konrad Dybcio
2025-09-03 16:15     ` Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 04/13] arm64: dts: qcom: lemans-evk: Add nvmem-layout for EEPROM Wasim Nazir
2025-09-03 12:29   ` Konrad Dybcio
2025-09-03 14:11     ` Wasim Nazir
2025-09-03 15:08       ` Wasim Nazir
2025-09-03 15:12         ` Konrad Dybcio
2025-09-03 15:47           ` Wasim Nazir [this message]
2025-09-03 11:47 ` [PATCH v2 05/13] arm64: dts: qcom: lemans-evk: Enable GPI DMA and QUPv3 controllers Wasim Nazir
2025-09-03 12:16   ` Dmitry Baryshkov
2025-09-03 14:09     ` Wasim Nazir
2025-09-03 14:15       ` Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 06/13] arm64: dts: qcom: lemans-evk: Enable PCIe support Wasim Nazir
2025-09-03 15:50   ` Konrad Dybcio
2025-09-03 16:14     ` Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 07/13] arm64: dts: qcom: lemans-evk: Enable remoteproc subsystems Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 08/13] arm64: dts: qcom: lemans-evk: Enable Iris video codec support Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 09/13] arm64: dts: qcom: lemans-evk: Enable first USB controller in device mode Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 10/13] arm64: dts: qcom: lemans-evk: Enable SDHCI for SD Card Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 11/13] arm64: dts: qcom: lemans-evk: Enable 2.5G Ethernet interface Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 12/13] arm64: dts: qcom: lemans: Add gpr node Wasim Nazir
2025-09-03 11:47 ` [PATCH v2 13/13] arm64: dts: qcom: lemans-evk: Add sound card Wasim Nazir
2025-09-03 21:56 ` [PATCH v2 00/13] arm64: dts: qcom: lemans-evk: Extend board support for additional peripherals Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLhjGuaAybp2CeIg@hu-wasimn-hyd.qualcomm.com \
    --to=wasim.nazir@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=quic_mchunara@quicinc.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®