mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cheng <icheng@nvidia.com>
To: tony.luck@intel.com, reinette.chatre@intel.com, shuah@kernel.org
Cc: Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com,
	 linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	yu.c.chen@intel.com,  fenghuay@nvidia.com, newtonl@nvidia.com,
	kristinc@nvidia.com, kaihengf@nvidia.com,  kobak@nvidia.com,
	ilpo.jarvinen@linux.intel.com
Subject: Re: [PATCH v3 0/3] selftests/resctrl: Fix resctrl selftests issues on aarch64
Date: Fri, 29 May 2026 10:28:26 +0800	[thread overview]
Message-ID: <ahj5bJRxN2ecghus@MWDK4CY14F> (raw)
In-Reply-To: <20260529022352.8308-1-icheng@nvidia.com>

On Fri, May 29, 2026 at 10:23:48AM +0800, Richard Cheng wrote:
> This series fixes numerous issues in the resctrl selftests on aarch64,
> where they currently misreport failures.
> 
> Patch 1 skips L3_CAT at feature-check time when MPAM legitimately
> reports every CBM bit as shareable, instead of failing the test.
> 
> Patch 2 adds aarch64 implementations of cl_flush() and sb() in
> fill_buf.c so cache flushes are no longer silent no-ops.
> 
> Patch 3 teaches detect_vendor() about aarch64 (which exposes no
> vendor_id in /proc/cpuinfo) and lets arch_supports_noncont_cat()
> return true for ARM, fixing spurious L3_NONCONT_CAT failures.
> 
> Changes since v2:
>     - Patch 1: add Ilpo's Reviewed-by.
>     - Patch 3: factor the aarch64 check into a detect_aarch64() helper
>       instead of an inline #ifdef in detect_vendor().
>     - Fix the patch ordering in this cover letter to match the series.
> 
> Richard Cheng (3):
>   selftests/resctrl: Skip L3_CAT when no exclusive cache portion exists
>   selftests/resctrl: Implement cl_flush() and sb() for aarch64
>   selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT
> 
>  tools/testing/selftests/resctrl/cat_test.c    | 32 +++++++++++++++++--
>  tools/testing/selftests/resctrl/fill_buf.c    |  6 ++++
>  tools/testing/selftests/resctrl/resctrl.h     |  1 +
>  .../testing/selftests/resctrl/resctrl_tests.c | 21 ++++++++++++
>  4 files changed, 57 insertions(+), 3 deletions(-)
> 
> -- 
> 2.43.0
>

Sorry forgot to cc Ilpo.

+Cc. Ilpo Järvinen

Best regards,
Richard Cheng.


      parent reply	other threads:[~2026-05-29  2:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29  2:23 Richard Cheng
2026-05-29  2:23 ` [PATCH v3 1/3] selftests/resctrl: Skip L3_CAT when no exclusive cache portion exists Richard Cheng
2026-06-26  3:25   ` Reinette Chatre
2026-05-29  2:23 ` [PATCH v3 2/3] selftests/resctrl: Implement cl_flush() and sb() for aarch64 Richard Cheng
2026-06-26  3:26   ` Reinette Chatre
2026-06-26 13:58     ` Ben Horgan
2026-07-02 14:15       ` Ben Horgan
2026-05-29  2:23 ` [PATCH v3 3/3] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT Richard Cheng
2026-05-31 19:01   ` Ilpo Järvinen
2026-06-26  3:26   ` Reinette Chatre
2026-05-29  2:28 ` Richard Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahj5bJRxN2ecghus@MWDK4CY14F \
    --to=icheng@nvidia.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=fenghuay@nvidia.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=james.morse@arm.com \
    --cc=kaihengf@nvidia.com \
    --cc=kobak@nvidia.com \
    --cc=kristinc@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=newtonl@nvidia.com \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

powered by JetHome