* [PATCH] iio: dac: mcp4725: fix odd_ptr_err.cocci warnings
@ 2016-10-22 20:41 Julia Lawall
2016-10-23 9:09 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2016-10-22 20:41 UTC (permalink / raw)
To: Tomas Novotny
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Yong Li, Akinobu Mita, linux-iio,
linux-kernel, kbuild-all
PTR_ERR should access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Tomas Novotny <tomas@novotny.cz>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
Not checked at all. This is being reported on the following tree:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
testing
head: 2796a310d462f73954c0ce8ffabaf4baacaecca1
commit: e0b80def1faa901d83a7d580e8aa4ad4a512bedf [109/113] iio: dac:
mcp4725: support voltage reference selection
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
mcp4725.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iio/dac/mcp4725.c
+++ b/drivers/iio/dac/mcp4725.c
@@ -418,7 +418,7 @@ static int mcp4725_probe(struct i2c_clie
if (pdata->use_vref) {
data->vref_reg = devm_regulator_get(&client->dev, "vref");
if (IS_ERR(data->vref_reg)) {
- err = PTR_ERR(data->vdd_reg);
+ err = PTR_ERR(data->vref_reg);
goto err_disable_vdd_reg;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: dac: mcp4725: fix odd_ptr_err.cocci warnings
2016-10-22 20:41 [PATCH] iio: dac: mcp4725: fix odd_ptr_err.cocci warnings Julia Lawall
@ 2016-10-23 9:09 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2016-10-23 9:09 UTC (permalink / raw)
To: Julia Lawall, Tomas Novotny
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Yong Li, Akinobu Mita, linux-iio, linux-kernel, kbuild-all
On 22/10/16 21:41, Julia Lawall wrote:
> PTR_ERR should access the value just tested by IS_ERR
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> CC: Tomas Novotny <tomas@novotny.cz>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Looks fairly obvious to me and I want to get a pull request out
shortly so applied.
Thanks,
Jonathan
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> Not checked at all. This is being reported on the following tree:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> testing
> head: 2796a310d462f73954c0ce8ffabaf4baacaecca1
> commit: e0b80def1faa901d83a7d580e8aa4ad4a512bedf [109/113] iio: dac:
> mcp4725: support voltage reference selection
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
>
>
> mcp4725.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -418,7 +418,7 @@ static int mcp4725_probe(struct i2c_clie
> if (pdata->use_vref) {
> data->vref_reg = devm_regulator_get(&client->dev, "vref");
> if (IS_ERR(data->vref_reg)) {
> - err = PTR_ERR(data->vdd_reg);
> + err = PTR_ERR(data->vref_reg);
> goto err_disable_vdd_reg;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-23 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-22 20:41 [PATCH] iio: dac: mcp4725: fix odd_ptr_err.cocci warnings Julia Lawall
2016-10-23 9:09 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®