From: Linus Torvalds <torvalds@linux-foundation.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: powerpc: introduce asm/swab.h
Date: Tue, 6 Jan 2009 21:08:06 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0901062103390.3057@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0901062354030.26118@xanadu.home>
On Tue, 6 Jan 2009, Nicolas Pitre wrote:
>
> Well, this series breaks ARM as well:
Ahh. I think it's the __SWAB_64_THRU_32__ case that is broken.
Does this fix things? Totally untested. Of course.
Linus
---
include/linux/swab.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/swab.h b/include/linux/swab.h
index 9a2d33e..be5284d 100644
--- a/include/linux/swab.h
+++ b/include/linux/swab.h
@@ -68,7 +68,7 @@ static inline __attribute_const__ __u64 __fswab64(__u64 val)
#elif defined(__SWAB_64_THRU_32__)
__u32 h = val >> 32;
__u32 l = val & ((1ULL << 32) - 1);
- return (((__u64)___swab32(l)) << 32) | ((__u64)(___swab32(h)));
+ return (((__u64)__fswab32(l)) << 32) | ((__u64)(__fswab32(h)));
#else
return ___constant_swab64(val);
#endif
next prev parent reply other threads:[~2009-01-07 5:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901070400.n0740Ore002063@hera.kernel.org>
2009-01-07 4:42 ` Benjamin Herrenschmidt
2009-01-07 4:48 ` Harvey Harrison
2009-01-07 4:59 ` Nicolas Pitre
2009-01-07 5:08 ` Linus Torvalds [this message]
2009-01-07 5:12 ` Nicolas Pitre
2009-01-07 5:01 ` Linus Torvalds
2009-01-07 5:08 ` Nicolas Pitre
2009-01-07 5:02 ` Benjamin Herrenschmidt
2009-01-07 5:11 ` Linus Torvalds
2009-01-07 5:19 ` Nicolas Pitre
2009-01-07 5:26 ` Nicolas Pitre
2009-01-07 5:38 ` Linus Torvalds
2009-01-07 5:37 ` Linus Torvalds
2009-01-07 6:02 ` Harvey Harrison
2009-01-07 6:05 ` Benjamin Herrenschmidt
2009-01-07 5:39 ` Steven Rostedt
2009-01-07 5:43 ` Benjamin Herrenschmidt
2009-01-07 8:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0901062103390.3057@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome