From: Linus Torvalds <torvalds@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: powerpc: introduce asm/swab.h
Date: Tue, 6 Jan 2009 21:11:42 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0901062108440.3057@localhost.localdomain> (raw)
In-Reply-To: <1231304552.14860.72.camel@pasglop>
On Wed, 7 Jan 2009, Benjamin Herrenschmidt wrote:
>
> Even if fixing that to use __swab32() instead, then it fails because
> this is defined after it's used. I worked around it using fswab in
> there instead.
That's the same patch I just sent out (but you changed comments too), so I
obviously agree.
x86 didn't see this (even in 32-bit mode) because it doesn't use that odd
__SWAB_64_THRU_32__ case, but does the 64-bit swab with native code.
Can you also verify that it works for you (not just compiles), just so
that I can commit it?
Linus
next prev parent reply other threads:[~2009-01-07 5:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901070400.n0740Ore002063@hera.kernel.org>
2009-01-07 4:42 ` Benjamin Herrenschmidt
2009-01-07 4:48 ` Harvey Harrison
2009-01-07 4:59 ` Nicolas Pitre
2009-01-07 5:08 ` Linus Torvalds
2009-01-07 5:12 ` Nicolas Pitre
2009-01-07 5:01 ` Linus Torvalds
2009-01-07 5:08 ` Nicolas Pitre
2009-01-07 5:02 ` Benjamin Herrenschmidt
2009-01-07 5:11 ` Linus Torvalds [this message]
2009-01-07 5:19 ` Nicolas Pitre
2009-01-07 5:26 ` Nicolas Pitre
2009-01-07 5:38 ` Linus Torvalds
2009-01-07 5:37 ` Linus Torvalds
2009-01-07 6:02 ` Harvey Harrison
2009-01-07 6:05 ` Benjamin Herrenschmidt
2009-01-07 5:39 ` Steven Rostedt
2009-01-07 5:43 ` Benjamin Herrenschmidt
2009-01-07 8:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0901062108440.3057@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome