From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maxwell Doose <maxwell@maxwelld.cc>
Cc: "Pan Chuang" <panchuang@vivo.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Gustavo Silva" <gustavograzs@gmail.com>,
"Maxwell Doose" <m32285159@gmail.com>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Siratul Islam" <email@sirat.me>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe()
Date: Sat, 18 Jul 2026 09:28:28 +0300 [thread overview]
Message-ID: <alsdDLZmctNCeu61@ashevche-desk.local> (raw)
In-Reply-To: <DK16R0RUSGG9.2LHH6CNKD0IAV@maxwelld.cc>
On Fri, Jul 17, 2026 at 05:05:22PM -0500, Maxwell Doose wrote:
> On Fri Jul 17, 2026 at 4:42 AM CDT
> Pan Chuang <panchuang@vivo.com> wrote:
...
> > @@ -686,7 +686,7 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
> > IRQF_NO_AUTOEN,
> > indio_dev->name, indio_dev);
> > if (ret)
> > - return dev_err_probe(dev, ret, "failed to request irq\n");
> > + return ret;
> >
> > return 0;
> > }
>
> Please split per driver and resubmit and feel free to add
>
> Reviewed-by: Maxwell Doose <maxwell@maxwelld.cc>
>
> once you do that.
This is trivial enough, so this sub-treewide approach is okay. When you want to
give a tag for certain piece of such a change, use comment style
Reviewed-... # for sdc30
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-18 6:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 23:21 ` Jonathan Cameron
2026-07-18 6:30 ` Andy Shevchenko
2026-07-17 9:42 ` [PATCH 02/13] iio: addac: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 22:05 ` Maxwell Doose
2026-07-17 23:24 ` Jonathan Cameron
2026-07-18 9:11 ` Maxwell Doose
2026-07-18 6:28 ` Andy Shevchenko [this message]
2026-07-17 9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
2026-07-17 23:26 ` Jonathan Cameron
2026-07-18 6:35 ` Andy Shevchenko
2026-07-17 9:42 ` [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 06/13] iio: health: Remove redundant dev_err() Pan Chuang
2026-07-17 9:42 ` [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 08/13] iio: imu: " Pan Chuang
2026-07-17 9:42 ` [PATCH 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
2026-07-17 9:42 ` [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 11/13] iio: proximity: " Pan Chuang
2026-07-17 9:42 ` [PATCH 12/13] iio: light: " Pan Chuang
2026-07-17 9:42 ` [PATCH 13/13] iio: temperature: " Pan Chuang
2026-07-17 10:30 ` [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alsdDLZmctNCeu61@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=gustavograzs@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=maxwell@maxwelld.cc \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=panchuang@vivo.com \
--cc=tduszyns@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome