From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: nord-embedded: Fix i2c9/i2c10 pin functions
Date: Mon, 14 Sep 2026 10:16:03 +0800 [thread overview]
Message-ID: <aqdY43X_kskpsjYV@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <zsohlfgrvaqxg2wsymmgeiiasstmk3y5t6vj3aj3v6gl6arcqf@dwyie4ondge7>
On Sat, Sep 12, 2026 at 06:34:14PM +0300, Abel Vesa wrote:
> On 26-09-11 22:20:36, Shawn Guo wrote:
> > The i2c9/i2c10 and uart9/uart10 pinctrl states shared the same pins and
> > the same "qup1_se2"/"qup1_se3" function name, so the I2C states were
> > indistinguishable from the UART ones and ended up muxing the UART lanes.
> > i2c9 and i2c10 therefore did not work.
> >
> > Now that the TLMM driver names each lane pair separately, select the
> > lane 0/1 function for I2C and the lane 2/3 function for UART.
> >
> > Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
>
> No fixes tag?
The Nord DTS hasn't been picked up. If it's preferable, I can send v15
of Nord DTS to fold this fix.
>
> Otherwise, LGTM.
>
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Thanks Abel!
Shawn
next prev parent reply other threads:[~2026-09-14 2:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 14:20 [PATCH 0/5] arm64: dts: qcom: nord: Add USB support Shawn Guo
2026-09-11 14:20 ` [PATCH 1/5] arm64: dts: qcom: nord-embedded: Fix i2c9/i2c10 pin functions Shawn Guo
2026-09-12 15:34 ` Abel Vesa
2026-09-14 2:16 ` Shawn Guo [this message]
2026-09-14 3:15 ` Shawn Guo
2026-09-11 14:20 ` [PATCH 2/5] arm64: dts: qcom: nord: Add the USB controller nodes Shawn Guo
2026-09-12 15:32 ` Abel Vesa
2026-09-14 8:33 ` Konrad Dybcio
2026-09-16 14:39 ` Shawn Guo
2026-09-11 14:20 ` [PATCH 3/5] arm64: dts: qcom: nord-embedded: Add USB resources and PHYs Shawn Guo
2026-09-12 15:32 ` Abel Vesa
2026-09-14 8:58 ` Konrad Dybcio
2026-09-16 14:56 ` Shawn Guo
2026-09-11 14:20 ` [PATCH 4/5] arm64: dts: qcom: nord-rrd: Enable USB ports Shawn Guo
2026-09-12 15:26 ` Abel Vesa
2026-09-14 8:53 ` Konrad Dybcio
2026-09-11 14:20 ` [PATCH 5/5] arm64: dts: qcom: nord-ride-embedded: " Shawn Guo
2026-09-12 15:25 ` Abel Vesa
2026-09-14 8:55 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqdY43X_kskpsjYV@QCOM-aGQu4IUr3Y \
--to=shengchao.guo@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®