Re: [PATCH v4 01/16] media: imx678: Rework into generic Starvis 2 sensor driver.

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Dave,

On Thu, Oct 15, 2026 at 04:57:27PM +0100, Dave Stevenson wrote:
> The register layout and programming model for multiple of the
> Sony Starvis2 sensors is identical, so prepare for supporting
> those by renaming all common parts of the driver to a starvis2_
> prefix, and renaming the driver.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>  MAINTAINERS                                     |  14 +-
>  drivers/media/i2c/Kconfig                       |  19 +-
>  drivers/media/i2c/Makefile                      |   2 +-
>  drivers/media/i2c/{imx678.c => sony-starvis2.c} | 773 ++++++++++++------------
>  4 files changed, 422 insertions(+), 386 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 760791e3635f..bba095bc1a63 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25640,13 +25640,6 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/media/i2c/sony,imx576.yaml
>  F:	drivers/media/i2c/imx576.c
>  
> -SONY IMX678 SENSOR DRIVER
> -M:	Jai Luthra <jai.luthra@ideasonboard.com>
> -L:	linux-media@vger.kernel.org
> -S:	Maintained
> -F:	Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
> -F:	drivers/media/i2c/imx678.c
> -
>  SONY MEMORYSTICK SUBSYSTEM
>  M:	Maxim Levitsky <maximlevitsky@gmail.com>
>  M:	Alex Dubov <oakad@yahoo.com>
> @@ -25657,6 +25650,13 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git
>  F:	drivers/memstick/
>  F:	include/linux/memstick.h
>  
> +SONY STARVIS 2 SENSOR DRIVER
> +M:	Jai Luthra <jai.luthra@ideasonboard.com>
> +L:	linux-media@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
> +F:	drivers/media/i2c/sony-starvis2.c

Can you also add drivers/media/i2c/sony-starvis2.c to the generic V4L2
CAMERA SENSOR DRIVERS entry, please? Or maybe
drivers/media/i2c/sony-starvis*?

> +
>  SONY VAIO CONTROL DEVICE DRIVER
>  M:	Mattia Dongili <malattia@linux.it>
>  L:	platform-driver-x86@vger.kernel.org
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 7de2d095c969..8c43ae77b47e 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -324,13 +324,11 @@ config VIDEO_IMX576
>  config VIDEO_IMX678
>  	tristate "Sony IMX678 sensor support"
>  	depends on GPIOLIB
> -	select V4L2_CCI_I2C
> +	select VIDEO_SONY_STARVIS2
>  	help
>  	  This is a Video4Linux2 sensor driver for the Sony
> -	  IMX678 camera.
> -
> -	  To compile this driver as a module, choose M here: the
> -	  module will be called imx678.
> +	  IMX678 camera. This sensor is now supported by the common
> +	  Sony Starvis 2 sensor driver.
>  
>  config VIDEO_MAX9271_LIB
>  	tristate
> @@ -879,6 +877,17 @@ config VIDEO_S5KJN5
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called s5kjn5.
>  
> +config VIDEO_SONY_STARVIS2
> +	tristate "Sony Starvis 2 sensor support"
> +	depends on GPIOLIB
> +	select V4L2_CCI_I2C
> +	help
> +	  This is a Video4Linux2 sensor driver for the Sony Starvis
> +	  2 image sensors.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called sony-starvis2.
> +
>  config VIDEO_T4KA3
>  	tristate "Toshiba T4KA3 sensor support"
>  	depends on ACPI || COMPILE_TEST
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 59e31af457cd..609208dabd07 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -64,7 +64,6 @@ obj-$(CONFIG_VIDEO_IMX412) += imx412.o
>  obj-$(CONFIG_VIDEO_IMX415) += imx415.o
>  obj-$(CONFIG_VIDEO_IMX471) += imx471.o
>  obj-$(CONFIG_VIDEO_IMX576) += imx576.o
> -obj-$(CONFIG_VIDEO_IMX678) += imx678.o
>  obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
>  obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
>  obj-$(CONFIG_VIDEO_IT6625) += it6625.o
> @@ -146,6 +145,7 @@ obj-$(CONFIG_VIDEO_SAA7127) += saa7127.o
>  obj-$(CONFIG_VIDEO_SAA717X) += saa717x.o
>  obj-$(CONFIG_VIDEO_SAA7185) += saa7185.o
>  obj-$(CONFIG_VIDEO_SONY_BTF_MPX) += sony-btf-mpx.o
> +obj-$(CONFIG_VIDEO_SONY_STARVIS2) += sony-starvis2.o
>  obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
>  obj-$(CONFIG_VIDEO_T4KA3) += t4ka3.o
>  obj-$(CONFIG_VIDEO_TC358743) += tc358743.o
> diff --git a/drivers/media/i2c/imx678.c b/drivers/media/i2c/sony-starvis2.c
> similarity index 56%
> rename from drivers/media/i2c/imx678.c
> rename to drivers/media/i2c/sony-starvis2.c
> index 8413fd44d657..b4733990d03a 100644
> --- a/drivers/media/i2c/imx678.c
> +++ b/drivers/media/i2c/sony-starvis2.c
> @@ -1,8 +1,13 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * V4L2 driver for Sony IMX678
> + * V4L2 driver for Sony Starvis 2 sensors
>   *
> - * Diagonal 8.86 mm (Type 1/1.8) CMOS image sensor with 8.40 M effective pixels.
> + * Many of the Sony Starvis 2 sensors share a common register layout, so
> + * many can be supported by a common driver.
> + *
> + * Currently supported are:
> + * IMX678: Diagonal 8.86 mm (Type 1/1.8) CMOS image sensor with 8.40 M effective
> + *         pixels.
>   *
>   * Copyright (C) 2026 Ideas On Board Oy.
>   *
> @@ -26,25 +31,25 @@
>  #include <media/v4l2-subdev.h>
>  
>  /* Standby or streaming mode */
> -#define IMX678_REG_MODE_SELECT          CCI_REG8(0x3000)
> -#define IMX678_MODE_STANDBY             0x01
> -#define IMX678_MODE_STREAMING           0x00
> -#define IMX678_STREAM_DELAY_US          25000
> -#define IMX678_STREAM_DELAY_RANGE_US    1000
> +#define STARVIS2_REG_MODE_SELECT          CCI_REG8(0x3000)
> +#define STARVIS2_MODE_STANDBY             0x01
> +#define STARVIS2_MODE_STREAMING           0x00
> +#define STARVIS2_STREAM_DELAY_US          25000
> +#define STARVIS2_STREAM_DELAY_RANGE_US    1000
>  
>  /* XVS/XHS sync control */
> -#define IMX678_REG_XMSTA                CCI_REG8(0x3002)
> -#define IMX678_REG_XXS_DRV              CCI_REG8(0x30a6)
> -#define IMX678_REG_XXS_OUTSEL           CCI_REG8(0x30a4)
> +#define STARVIS2_REG_XMSTA                CCI_REG8(0x3002)
> +#define STARVIS2_REG_XXS_DRV              CCI_REG8(0x30a6)
> +#define STARVIS2_REG_XXS_OUTSEL           CCI_REG8(0x30a4)

It'd be nice to use tabs here, even though the old driver didn't (I wonder
what happened there).

...

> -module_i2c_driver(imx678_i2c_driver);
> +module_i2c_driver(starvis2_i2c_driver);
>  
>  MODULE_AUTHOR("Will Whang <will@willwhang.com>");
>  MODULE_AUTHOR("Tetsuya NOMURA <tetsuya.nomura@soho-enterprise.com>");
>  MODULE_AUTHOR("Jai Luthra <jai.luthra@ideasonboard.com>");

I guess you'll add yours at some point in the set?

> -MODULE_DESCRIPTION("Sony imx678 sensor driver");
> +MODULE_DESCRIPTION("Sony Starvis 2 sensor driver");
>  MODULE_LICENSE("GPL");
> 

-- 
Regards,

Sakari Ailus