From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: longzhao@ambarella.com
Cc: Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
Michael Walle <mwalle@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Long Zhao <zl020895@163.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 7/9] gpio: pl061: keep the parent device in a local
Date: Wed, 21 Oct 2026 20:27:23 +0300 [thread overview]
Message-ID: <atj1-0OckTqIktsY@ashevche-desk.local> (raw)
In-Reply-To: <20261020-cv75-gpio-v11-7-e058bae19571@ambarella.com>
On Tue, Oct 20, 2026 at 03:54:11PM +0800, Long Zhao via B4 Relay wrote:
> IRQ logging uses gc->parent. Keep that device in a local so the
> gpio-regmap switch can change where it comes from without rewriting
> every log line.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Also see some side notes (for the future development) below.
...
> if ((trigger & IRQ_TYPE_LEVEL_MASK) && (trigger & IRQ_TYPE_EDGE_BOTH)) {
> - dev_err(gc->parent,
> + dev_err(parent,
> "trying to configure line %d for both level and edge "
> "detection, choose one!\n",
It's better to join string literals as one might grep by the say 'and edge
detection' phrase and won't find any match in the code. This can be done
for all messages in the driver in a single, but separate, patch (I haven't
checked how many of the messages like this here, though).
> offset);
...
> - dev_dbg(gc->parent, "line %d: IRQ on %s level\n",
> + dev_dbg(parent, "line %d: IRQ on %s level\n",
> offset,
> polarity ? "HIGH" : "LOW");
Since it's debug message, we may use str_high_low() from string_choices.h.
...
> - dev_dbg(gc->parent, "line %d: IRQ on %s edge\n",
> + dev_dbg(parent, "line %d: IRQ on %s edge\n",
> offset,
> rising ? "RISING" : "FALLING");
IIRC there was a patch in mailing list to add str_rising_falling(). But for now
I don't see it in the upstream.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-21 17:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 7:54 [PATCH v11 0/9] gpio: add Ambarella CV75 PL061 support Long Zhao via B4 Relay
2026-10-20 7:54 ` [PATCH v11 1/9] dt-bindings: gpio: pl061: add Ambarella CV75 variant Long Zhao via B4 Relay
2026-10-20 7:54 ` [PATCH v11 2/9] gpiolib: regmap: add GPIO_REGMAP_QUIRK_SET_AFTER_DIR Long Zhao via B4 Relay
2026-10-20 7:54 ` [PATCH v11 3/9] gpio: pl061: drop redundant pending check in the IRQ handler Long Zhao via B4 Relay
2026-10-20 7:54 ` [PATCH v11 4/9] gpio: pl061: convert register access to regmap Long Zhao via B4 Relay
2026-10-21 12:47 ` Andy Shevchenko
2026-10-20 7:54 ` [PATCH v11 5/9] gpio: pl061: use IRQ_TYPE_LEVEL_MASK and IRQ_TYPE_EDGE_BOTH Long Zhao via B4 Relay
2026-10-20 7:54 ` [PATCH v11 6/9] gpio: pl061: use cleanup helpers for locks Long Zhao via B4 Relay
2026-10-21 16:13 ` Andy Shevchenko
2026-10-20 7:54 ` [PATCH v11 7/9] gpio: pl061: keep the parent device in a local Long Zhao via B4 Relay
2026-10-21 17:27 ` Andy Shevchenko [this message]
2026-10-20 7:54 ` [PATCH v11 8/9] gpio: pl061: switch data path to gpio-regmap Long Zhao via B4 Relay
2026-10-21 17:41 ` Andy Shevchenko
2026-10-20 7:54 ` [PATCH v11 9/9] gpio: pl061: add Ambarella register-layout variant Long Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atj1-0OckTqIktsY@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longzhao@ambarella.com \
--cc=mwalle@kernel.org \
--cc=robh@kernel.org \
--cc=zl020895@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®