[PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards

[PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards

[Stefano Radaelli]

From: Stefano Radaelli <stefano.r@variscite.com>

The Ethernet LEDs are physically on the carrier boards, but the
VAR-SOM-MX8MP, DART-MX91, VAR-SOM-MX93 and DART-MX95 module descriptions
include their LED nodes. Other carriers therefore inherit LED definitions
that may not match their wiring.

Move the LED nodes to the Symphony and Sonata board descriptions through
ethphy0 references, along with the LED binding includes where needed.
Keep the existing LED properties unchanged.

Fixes: c277a3d535bb ("arm64: dts: freescale: imx8mp-var-som: Add EQoS support with MaxLinear PHY")
Fixes: d3ad2ce2116f ("arm64: dts: freescale: Add support for Variscite DART-MX91")
Fixes: 947771d00bdc ("arm64: dts: freescale: imx93-var-som: update eqos support for MaxLinear PHY")
Fixes: bec2988b470e ("arm64: dts: freescale: Add support for Variscite DART-MX95")
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
 .../dts/freescale/imx8mp-var-som-symphony.dts | 22 +++++++++++++++++++
 .../boot/dts/freescale/imx8mp-var-som.dtsi    | 20 -----------------
 .../dts/freescale/imx91-var-dart-sonata.dts   | 22 +++++++++++++++++++
 .../boot/dts/freescale/imx91-var-dart.dtsi    | 20 -----------------
 .../dts/freescale/imx93-var-som-symphony.dts  | 21 ++++++++++++++++++
 .../boot/dts/freescale/imx93-var-som.dtsi     | 19 ----------------
 .../dts/freescale/imx95-var-dart-sonata.dts   | 22 +++++++++++++++++++
 .../boot/dts/freescale/imx95-var-dart.dtsi    | 20 -----------------
 8 files changed, 87 insertions(+), 79 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts
index e928a3d44b1d..49d20db7de5f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dts
@@ -3,6 +3,7 @@
  * Copyright 2024 Variscite Ltd.
  */
 
+#include <dt-bindings/leds/common.h>
 #include "imx8mp-var-som.dtsi"
 
 / {
@@ -129,6 +130,27 @@ ethphy1: ethernet-phy@5 {
 	};
 };
 
+&ethphy0 {
+	leds {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+	};
+};
+
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
index 61786eee0e82..cbf58aed180a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
@@ -8,7 +8,6 @@
 /dts-v1/;
 
 #include <dt-bindings/phy/phy-imx8-pcie.h>
-#include <dt-bindings/leds/common.h>
 #include <dt-bindings/usb/pd.h>
 #include "imx8mp.dtsi"
 
@@ -155,25 +154,6 @@ ethphy0: ethernet-phy@4 {
 			reset-assert-us = <10000>;
 			reset-deassert-us = <100000>;
 			vddio-supply = <&reg_phy_vddio>;
-
-			leds {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				led@0 {
-					reg = <0>;
-					color = <LED_COLOR_ID_YELLOW>;
-					function = LED_FUNCTION_LAN;
-					linux,default-trigger = "netdev";
-				};
-
-				led@1 {
-					reg = <1>;
-					color = <LED_COLOR_ID_GREEN>;
-					function = LED_FUNCTION_LAN;
-					linux,default-trigger = "netdev";
-				};
-			};
 		};
 	};
 };
diff --git a/arch/arm64/boot/dts/freescale/imx91-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx91-var-dart-sonata.dts
index f7e32f9375f5..0f2be56ff7ca 100644
--- a/arch/arm64/boot/dts/freescale/imx91-var-dart-sonata.dts
+++ b/arch/arm64/boot/dts/freescale/imx91-var-dart-sonata.dts
@@ -10,6 +10,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include "imx91-var-dart.dtsi"
 
 / {
@@ -173,6 +174,27 @@ led@1 {
 	};
 };
 
+&ethphy0 {
+	leds {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+	};
+};
+
 &fec {
 	pinctrl-names = "default", "sleep";
 	pinctrl-0 = <&pinctrl_fec>;
diff --git a/arch/arm64/boot/dts/freescale/imx91-var-dart.dtsi b/arch/arm64/boot/dts/freescale/imx91-var-dart.dtsi
index a9e44efad13f..ec65cd42c195 100644
--- a/arch/arm64/boot/dts/freescale/imx91-var-dart.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx91-var-dart.dtsi
@@ -10,7 +10,6 @@
 
 /dts-v1/;
 
-#include <dt-bindings/leds/common.h>
 #include <dt-bindings/usb/pd.h>
 #include "imx91.dtsi"
 
@@ -81,25 +80,6 @@ ethphy0: ethernet-phy@0 {
 			reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <15000>;
 			reset-deassert-us = <100000>;
-
-			leds {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				led@0 {
-					reg = <0>;
-					color = <LED_COLOR_ID_YELLOW>;
-					function = LED_FUNCTION_LAN;
-					linux,default-trigger = "netdev";
-				};
-
-				led@1 {
-					reg = <1>;
-					color = <LED_COLOR_ID_GREEN>;
-					function = LED_FUNCTION_LAN;
-					linux,default-trigger = "netdev";
-				};
-			};
 		};
 	};
 };
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
index 1f0954620195..477f31a4cf88 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
@@ -189,6 +189,27 @@ vddio1: vddio-regulator {
 	};
 };
 
+&ethphy0 {
+	leds {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+	};
+};
+
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fec>;
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
index b0ffcb534cb6..d9ecbc3e9a6d 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
@@ -75,25 +75,6 @@ ethphy0: ethernet-phy@0 {
 			reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <10000>;
 			reset-deassert-us = <100000>;
-
-			leds {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				led@0 {
-					reg = <0>;
-					color = <LED_COLOR_ID_YELLOW>;
-					function = LED_FUNCTION_LAN;
-					linux,default-trigger = "netdev";
-				};
-
-				led@1 {
-					reg = <1>;
-					color = <LED_COLOR_ID_GREEN>;
-					function = LED_FUNCTION_LAN;
-					linux,default-trigger = "netdev";
-				};
-			};
 		};
 	};
 };
diff --git a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
index 9344a0d99418..ed3e2e1b995c 100644
--- a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
+++ b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
@@ -8,6 +8,7 @@
  *
  */
 
+#include <dt-bindings/leds/common.h>
 #include "imx95-var-dart.dtsi"
 
 / {
@@ -163,6 +164,27 @@ &enetc_port2 {
 	status = "okay";
 };
 
+&ethphy0 {
+	leds {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+
+		led@1 {
+			reg = <1>;
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_LAN;
+			linux,default-trigger = "netdev";
+		};
+	};
+};
+
 &flexcan1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_flexcan1>;
diff --git a/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi b/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi
index b4c55bd33858..92ff09fe64a7 100644
--- a/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi
@@ -10,7 +10,6 @@
 
 /dts-v1/;
 
-#include <dt-bindings/leds/common.h>
 #include <dt-bindings/usb/pd.h>
 #include "imx95.dtsi"
 
@@ -193,25 +192,6 @@ ethphy0: ethernet-phy@0 {
 		reset-gpios = <&gpio5 16 GPIO_ACTIVE_LOW>;
 		reset-assert-us = <10000>;
 		reset-deassert-us = <100000>;
-
-		leds {
-			#address-cells = <1>;
-			#size-cells = <0>;
-
-			led@0 {
-				reg = <0>;
-				color = <LED_COLOR_ID_YELLOW>;
-				function = LED_FUNCTION_LAN;
-				linux,default-trigger = "netdev";
-			};
-
-			led@1 {
-				reg = <1>;
-				color = <LED_COLOR_ID_GREEN>;
-				function = LED_FUNCTION_LAN;
-				linux,default-trigger = "netdev";
-			};
-		};
 	};
 };
 
-- 
2.47.3

Re: [PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards

[Frank Li]

On Thu, Nov 05, 2026 at 11:17:39AM +0100, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
>
> The Ethernet LEDs are physically on the carrier boards, but the
> VAR-SOM-MX8MP, DART-MX91, VAR-SOM-MX93 and DART-MX95 module descriptions
> include their LED nodes. Other carriers therefore inherit LED definitions
> that may not match their wiring.

what's impact?

Frank

Re: [PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards

[Stefano Radaelli]

On Thu, Nov 05, 2026 at 11:34:49AM -0600, Frank Li wrote:
> On Thu, Nov 05, 2026 at 11:17:39AM +0100, Stefano Radaelli wrote:
> > From: Stefano Radaelli <stefano.r@variscite.com>
> >
> > The Ethernet LEDs are physically on the carrier boards, but the
> > VAR-SOM-MX8MP, DART-MX91, VAR-SOM-MX93 and DART-MX95 module descriptions
> > include their LED nodes. Other carriers therefore inherit LED definitions
> > that may not match their wiring.
> 
> what's impact?
> 

Hi Frank,

There are two main points:

1. The SOM dtsi is intended to be reused with different carriers.
   Defining the LEDs there forces every carrier to inherit the reference
   board’s LED configuration. Customers then have to override those
   definitions or explicitly delete the LED nodes if their carrier has no LEDs.
   Keeping the definitions in the carrier DTS avoids requiring customers
   to undo configuration for hardware that is not part of the SoM.

2. The Ethernet connectors, LEDs and their wiring are on the carrier.
   Their definitions therefore belong in the carrier DTS, while the SOM dtsi
   should describe the hardware on the module.
   This change makes that separation consistent across our boards.

There is no functional change for the existing Symphony and Sonata boards:
their final device trees retain the same LED configuration.

Thank you Frank,
Best Regards,
Stefano

Re: [PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards

[Frank Li]

On Thu, Nov 05, 2026 at 06:44:39PM +0100, Stefano Radaelli wrote:
> On Thu, Nov 05, 2026 at 11:34:49AM -0600, Frank Li wrote:
> > On Thu, Nov 05, 2026 at 11:17:39AM +0100, Stefano Radaelli wrote:
> > > From: Stefano Radaelli <stefano.r@variscite.com>
> > >
> > > The Ethernet LEDs are physically on the carrier boards, but the
> > > VAR-SOM-MX8MP, DART-MX91, VAR-SOM-MX93 and DART-MX95 module descriptions
> > > include their LED nodes. Other carriers therefore inherit LED definitions
> > > that may not match their wiring.
> >
> > what's impact?
> >
>
> Hi Frank,
>
> There are two main points:
>
> 1. The SOM dtsi is intended to be reused with different carriers.
>    Defining the LEDs there forces every carrier to inherit the reference
>    board’s LED configuration. Customers then have to override those
>    definitions or explicitly delete the LED nodes if their carrier has no LEDs.
>    Keeping the definitions in the carrier DTS avoids requiring customers
>    to undo configuration for hardware that is not part of the SoM.
>
> 2. The Ethernet connectors, LEDs and their wiring are on the carrier.
>    Their definitions therefore belong in the carrier DTS, while the SOM dtsi
>    should describe the hardware on the module.
>    This change makes that separation consistent across our boards.
>
> There is no functional change for the existing Symphony and Sonata boards:
> their final device trees retain the same LED configuration.

If not impact for current user, needn't fix tags to back port it.

Frank

>
> Thank you Frank,
> Best Regards,
> Stefano

Re: [PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards

[Stefano Radaelli]

On Thu, Nov 05, 2026 at 11:53:55AM -0600, Frank Li wrote:
> 
> If not impact for current user, needn't fix tags to back port it.
> 
> Frank
> 

Understood. Would you prefer a v2 without the Fixes tags, or can you drop
them when applying the patch?

Best Regards,
Stefano