mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Imre Kaloz <kaloz@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 2/4] MIPS: sgi-ip32: Leave MACE PCI control alone in config accesses
Date: Thu, 5 Nov 2026 16:26:24 +0100	[thread overview]
Message-ID: <auygIGW4c9_eBTT7@alpha.franken.de> (raw)
In-Reply-To: <20261021192418.7246-3-kaloz@kernel.org>

On Wed, Oct 21, 2026 at 09:24:16PM +0200, Imre Kaloz wrote:
> mace_pci_read_config() clears the master abort interrupt enable in the
> MACE PCI control register around each config read. A register read
> followed by two register writes can hang CRIME 1.1 under DMA load.
> 
> Ack master aborts in the error register instead, and follow every
> write with a read so back-to-back accesses cannot form that sequence.
> 
> Fixes: c990081bf87b ("[MIPS] Fix IP32 breakage")
> Cc: stable@vger.kernel.org
> Signed-off-by: Imre Kaloz <kaloz@kernel.org>
> ---
>  arch/mips/pci/ops-mace.c | 26 +++++++++++++++++++-------
>  arch/mips/pci/pci-ip32.c |  2 ++
>  2 files changed, 21 insertions(+), 7 deletions(-)

applied to mips-fixes

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

  reply	other threads:[~2026-11-05 15:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 19:24 [PATCH 0/4] MIPS: sgi-ip32: CRIME 1.1 and MACE PCI fixes Imre Kaloz
2026-10-21 19:24 ` [PATCH 1/4] MIPS: sgi-ip32: Mask MACE PCI interrupts in CRIME only Imre Kaloz
2026-11-05 15:25   ` Thomas Bogendoerfer
2026-10-21 19:24 ` [PATCH 2/4] MIPS: sgi-ip32: Leave MACE PCI control alone in config accesses Imre Kaloz
2026-11-05 15:26   ` Thomas Bogendoerfer [this message]
2026-10-21 19:24 ` [PATCH 3/4] MIPS: sgi-ip32: Report the real CRIME revision Imre Kaloz
2026-11-05 15:26   ` Thomas Bogendoerfer
2026-10-21 19:24 ` [PATCH 4/4] MIPS: sgi-ip32: Fence PIO reads on CRIME 1.1 Imre Kaloz
2026-11-05 15:43   ` Thomas Bogendoerfer
2026-11-05 19:40     ` Imre Kaloz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auygIGW4c9_eBTT7@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=kaloz@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®