[PATCH] input, mouse: Change the prototype of functions in lifebook.c

[PATCH] input, mouse: Change the prototype of functions in lifebook.c

[Rakib Mullick]

 When CONFIG_PM=n, then we are warned by the following warning:

drivers/input/mouse/lifebook.c:33: warning: 'lifebook_limit_serio3'
defined but not used
drivers/input/mouse/lifebook.c:41: warning: 'lifebook_set_6byte_proto'
defined but not used


Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---

--- linus/drivers/input/mouse/lifebook.c	2009-12-28 12:37:51.000000000 +0600
+++ rakib/drivers/input/mouse/lifebook.c	2009-12-28 15:02:02.000000000 +0600
@@ -29,7 +29,7 @@ static bool lifebook_present;

 static const char *desired_serio_phys;

-static int lifebook_limit_serio3(const struct dmi_system_id *d)
+static inline int lifebook_limit_serio3(const struct dmi_system_id *d)
 {
 	desired_serio_phys = "isa0060/serio3";
 	return 0;
@@ -37,7 +37,7 @@ static int lifebook_limit_serio3(const s

 static bool lifebook_use_6byte_proto;

-static int lifebook_set_6byte_proto(const struct dmi_system_id *d)
+static inline int lifebook_set_6byte_proto(const struct dmi_system_id *d)
 {
 	lifebook_use_6byte_proto = true;
 	return 0;

Re: [PATCH] input, mouse: Change the prototype of functions in lifebook.c

[Dmitry Torokhov]

On Tue, Dec 29, 2009 at 10:09:24AM +0600, Rakib Mullick wrote:
>  When CONFIG_PM=n, then we are warned by the following warning:
> 
> drivers/input/mouse/lifebook.c:33: warning: 'lifebook_limit_serio3'
> defined but not used
> drivers/input/mouse/lifebook.c:41: warning: 'lifebook_set_6byte_proto'
> defined but not used
> 

I suppose it is CONFIG_DMI, not CONFIG_PM... In fact, we should simply
make this driver depend on CONFIG_DMI.

Thanks for reporting this.

-- 
Dmitry

Re: [PATCH] input, mouse: Change the prototype of functions in lifebook.c

[Rakib Mullick]

On 12/30/09, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> I suppose it is CONFIG_DMI, not CONFIG_PM... In fact, we should simply
>  make this driver depend on CONFIG_DMI.

Oh.. yes. I made a stupid mistake. Please checkout the following patch.

-------

 input, mouse: Make lifebook mouse driver depend on CONFIG_DMI.

When CONFIG_DMI=n, then we are warned by the following warning:

drivers/input/mouse/lifebook.c:33: warning: 'lifebook_limit_serio3'
defined but not used
drivers/input/mouse/lifebook.c:41: warning: 'lifebook_set_6byte_proto'
defined but not used

We need to make this driver depend on CONFIG_DMI.



Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---

--- linus/drivers/input/mouse/Kconfig	2009-12-28 12:37:51.000000000 +0600
+++ rakib/drivers/input/mouse/Kconfig	2009-12-30 20:24:31.000000000 +0600
@@ -70,7 +70,7 @@ config MOUSE_PS2_SYNAPTICS
 config MOUSE_PS2_LIFEBOOK
 	bool "Fujitsu Lifebook PS/2 mouse protocol extension" if EMBEDDED
 	default y
-	depends on MOUSE_PS2 && X86
+	depends on MOUSE_PS2 && X86 && DMI
 	help
 	  Say Y here if you have a Fujitsu B-series Lifebook PS/2
 	  TouchScreen connected to your system.