From: Ada Couprie Diaz <ada.coupriediaz@arm.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: Ada Couprie Diaz <ada.coupriediaz@arm.com>,
catalin.marinas@arm.com, will@kernel.org, oleg@redhat.com,
sstabellini@kernel.org, mark.rutland@arm.com,
puranjay@kernel.org, broonie@kernel.org, mbenes@suse.cz,
ryan.roberts@arm.com, akpm@linux-foundation.org,
chenl311@chinatelecom.cn, anshuman.khandual@arm.com,
kristina.martsenko@arm.com, liaochang1@huawei.com,
ardb@kernel.org, leitao@debian.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH -next v7 1/7] arm64: ptrace: Replace interrupts_enabled() with regs_irqs_disabled()
Date: Tue, 5 Aug 2025 16:05:45 +0100 [thread overview]
Message-ID: <beb7e8f2-39f8-499f-a173-b8bf2d3296ea@arm.com> (raw)
In-Reply-To: <20250729015456.3411143-2-ruanjinjie@huawei.com>
On 29/07/2025 02:54, Jinjie Ruan wrote:
> The generic entry code expects architecture code to provide
> regs_irqs_disabled(regs) function, but arm64 does not have this and
> provides inerrupts_enabled(regs), which has the opposite polarity.
Nit: "interrupts_enabled(regs)"
> In preparation for moving arm64 over to the generic entry code,
> relace arm64's interrupts_enabled() with regs_irqs_disabled() and
> update its callers under arch/arm64.
>
> For the moment, a definition of interrupts_enabled() is provided for
> the GICv3 driver. Once arch/arm implement regs_irqs_disabled(), this
> can be removed.
>
> Delete the fast_interrupts_enabled() macro as it is unused and we
> don't want any new users to show up.
>
> No functional changes.
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
Otherwise looks good to me !
Reviewed-by: Ada Couprie Diaz <ada.coupriediaz@arm.com>
next prev parent reply other threads:[~2025-08-05 15:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 1:54 [PATCH -next v7 0/7] arm64: entry: Convert to generic irq entry Jinjie Ruan
2025-07-29 1:54 ` [PATCH -next v7 1/7] arm64: ptrace: Replace interrupts_enabled() with regs_irqs_disabled() Jinjie Ruan
2025-08-05 15:05 ` Ada Couprie Diaz [this message]
2025-08-06 2:31 ` Jinjie Ruan
2025-07-29 1:54 ` [PATCH -next v7 2/7] arm64: entry: Refactor the entry and exit for exceptions from EL1 Jinjie Ruan
2025-08-05 15:06 ` Ada Couprie Diaz
2025-08-06 2:49 ` Jinjie Ruan
2025-08-11 16:01 ` Ada Couprie Diaz
2025-08-12 11:01 ` Mark Rutland
2025-07-29 1:54 ` [PATCH -next v7 3/7] arm64: entry: Rework arm64_preempt_schedule_irq() Jinjie Ruan
2025-08-05 15:06 ` Ada Couprie Diaz
2025-07-29 1:54 ` [PATCH -next v7 4/7] arm64: entry: Use preempt_count() and need_resched() helper Jinjie Ruan
2025-08-05 15:06 ` Ada Couprie Diaz
2025-07-29 1:54 ` [PATCH -next v7 5/7] arm64: entry: Refactor preempt_schedule_irq() check code Jinjie Ruan
2025-08-05 15:06 ` Ada Couprie Diaz
2025-08-06 6:26 ` Jinjie Ruan
2025-08-06 6:39 ` Jinjie Ruan
2025-08-11 16:02 ` Ada Couprie Diaz
2025-08-11 16:02 ` Ada Couprie Diaz
2025-08-14 8:49 ` Jinjie Ruan
2025-08-12 11:13 ` Mark Rutland
2025-08-14 9:31 ` Jinjie Ruan
2025-07-29 1:54 ` [PATCH -next v7 6/7] arm64: entry: Move arm64_preempt_schedule_irq() into __exit_to_kernel_mode() Jinjie Ruan
2025-08-05 15:07 ` Ada Couprie Diaz
2025-07-29 1:54 ` [PATCH -next v7 7/7] arm64: entry: Switch to generic IRQ entry Jinjie Ruan
2025-08-05 15:07 ` Ada Couprie Diaz
2025-08-06 6:59 ` Jinjie Ruan
2025-08-05 15:08 ` [PATCH -next v7 0/7] arm64: entry: Convert to generic irq entry Ada Couprie Diaz
2025-08-06 8:11 ` Jinjie Ruan
2025-08-11 16:03 ` Ada Couprie Diaz
2025-08-14 9:37 ` Jinjie Ruan
2025-08-12 11:19 ` Mark Rutland
2025-08-14 9:39 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beb7e8f2-39f8-499f-a173-b8bf2d3296ea@arm.com \
--to=ada.coupriediaz@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenl311@chinatelecom.cn \
--cc=kristina.martsenko@arm.com \
--cc=leitao@debian.org \
--cc=liaochang1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbenes@suse.cz \
--cc=oleg@redhat.com \
--cc=puranjay@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=ryan.roberts@arm.com \
--cc=sstabellini@kernel.org \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®