From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Arnav Kapoor" <kapoorarnav43@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Mudit Sharma" <muditsharma.info@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: bh1745: fix 16-bit register accesses
Date: Wed, 18 Nov 2026 16:17:00 +0200 [thread overview]
Message-ID: <c1a68be0-36ed-4671-82a6-8aafb1855c4e@gmail.com> (raw)
In-Reply-To: <av2PPiin8mJiJD_q@ashevche-desk.local>
On 18/11/2026 13:42, Andy Shevchenko wrote:
> On Wed, Nov 18, 2026 at 12:31:59PM +0200, Matti Vaittinen wrote:
>> On 17/11/2026 16:21, Andy Shevchenko wrote:
>>> + Cc: Matti (even he is not listed as maintainer) for possible another pair of
>>> eyes and/or having an answer why this was missed at the time of the driver
>>> submission (from my perspective this patch is correct).
>>
>> Thanks for the heads-up Andy. Unfortunately, I have never worked with this
>> IC, and I don't think we have it in the ROHM Finland office (but I'll check
>> this just in case. It'd be nice to have this covered in my test setup).
>>
>> What comes to missing this in reviews... Well, I suppose the reviewers are
>> just humans, or if they're not, then they might have concentrated on other
>> important things, like styling, instead of the real functionality.
>>
>> On my own behalf, I was away for 1.5 months when the series was applied, and
>> I only looked at the GTS-helpers usage when I did my shallow and badly
>> belated review. (Furthermore, I am 100% human, so I might have just missed
>> this even if I had all the time in the world to do the review).
>
> Yeah, I don't know how ROHM is big, but in other companies usually there is
> an internal mailing list is set for reviews. Maybe that helps?
I took a look to the Wikipedia. ROHM isn't that big. 2017 it has been
around 21k
people, and I have a feeling (no facts) that size is still about the same.
List might help, if we had more than 1 upstream Linux developers... :)
(I actually did request a list when I started at ROHM - and we had
something for a couple of years. Unfortunately, I was the only one ever
using that. After a company IT-change accidentally killed the list I
never requested a new one. Still, even when we had the list, the bd1745
patches wouldn't probably have emerged to it. The get_maintainers.pl
folks use to get relevant reviewers, wouldn't have known to add that
list for a new driver with no 'rohm' -prefix.)
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
next prev parent reply other threads:[~2026-11-18 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 11:03 Arnav Kapoor
2026-11-17 14:21 ` Andy Shevchenko
2026-11-17 14:23 ` Andy Shevchenko
2026-11-18 10:31 ` Matti Vaittinen
2026-11-18 11:42 ` Andy Shevchenko
2026-11-18 14:17 ` Matti Vaittinen [this message]
2026-11-18 10:31 ` Matti Vaittinen
2026-11-18 10:38 ` Arnav Kapoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1a68be0-36ed-4671-82a6-8aafb1855c4e@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muditsharma.info@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®