* [PATCH -next] drivers: net: declance: fix comparing pointer to 0
@ 2020-01-21 1:35 Chen Zhou
2020-01-21 8:39 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Chen Zhou @ 2020-01-21 1:35 UTC (permalink / raw)
To: davem, mhabets, kuba; +Cc: netdev, linux-kernel, chenzhou10
Fixes coccicheck warning:
./drivers/net/ethernet/amd/declance.c:611:14-15:
WARNING comparing pointer to 0
Compare pointer-typed values to NULL rather than 0.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/net/ethernet/amd/declance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
index 6592a2d..7282ce5 100644
--- a/drivers/net/ethernet/amd/declance.c
+++ b/drivers/net/ethernet/amd/declance.c
@@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
skb = netdev_alloc_skb(dev, len + 2);
- if (skb == 0) {
+ if (!skb) {
dev->stats.rx_dropped++;
*rds_ptr(rd, mblength, lp->type) = 0;
*rds_ptr(rd, rmd1, lp->type) =
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0
2020-01-21 1:35 [PATCH -next] drivers: net: declance: fix comparing pointer to 0 Chen Zhou
@ 2020-01-21 8:39 ` Sergei Shtylyov
2020-01-21 8:54 ` Chen Zhou
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2020-01-21 8:39 UTC (permalink / raw)
To: Chen Zhou, davem, mhabets, kuba; +Cc: netdev, linux-kernel
Hello!
On 21.01.2020 4:35, Chen Zhou wrote:
> Fixes coccicheck warning:
>
> ./drivers/net/ethernet/amd/declance.c:611:14-15:
> WARNING comparing pointer to 0
>
> Compare pointer-typed values to NULL rather than 0.
I don't see NULL in the patch -- you used ! instead.
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/net/ethernet/amd/declance.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
> index 6592a2d..7282ce5 100644
> --- a/drivers/net/ethernet/amd/declance.c
> +++ b/drivers/net/ethernet/amd/declance.c
> @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
> len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
> skb = netdev_alloc_skb(dev, len + 2);
>
> - if (skb == 0) {
> + if (!skb) {
> dev->stats.rx_dropped++;
> *rds_ptr(rd, mblength, lp->type) = 0;
> *rds_ptr(rd, rmd1, lp->type) =
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0
2020-01-21 8:39 ` Sergei Shtylyov
@ 2020-01-21 8:54 ` Chen Zhou
2020-01-21 9:01 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Chen Zhou @ 2020-01-21 8:54 UTC (permalink / raw)
To: Sergei Shtylyov, davem, mhabets, kuba; +Cc: netdev, linux-kernel
Hi Sergei,
On 2020/1/21 16:39, Sergei Shtylyov wrote:
> Hello!
>
> On 21.01.2020 4:35, Chen Zhou wrote:
>
>> Fixes coccicheck warning:
>>
>> ./drivers/net/ethernet/amd/declance.c:611:14-15:
>> WARNING comparing pointer to 0
>>
>> Compare pointer-typed values to NULL rather than 0.
>
> I don't see NULL in the patch -- you used ! instead.
Yeah, i used ! here.
Thanks,
Chen Zhou
>
>> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
>> ---
>> drivers/net/ethernet/amd/declance.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
>> index 6592a2d..7282ce5 100644
>> --- a/drivers/net/ethernet/amd/declance.c
>> +++ b/drivers/net/ethernet/amd/declance.c
>> @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
>> len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
>> skb = netdev_alloc_skb(dev, len + 2);
>> - if (skb == 0) {
>> + if (!skb) {
>> dev->stats.rx_dropped++;
>> *rds_ptr(rd, mblength, lp->type) = 0;
>> *rds_ptr(rd, rmd1, lp->type) =
>
> MBR, Sergei
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0
2020-01-21 8:54 ` Chen Zhou
@ 2020-01-21 9:01 ` Sergei Shtylyov
2020-01-21 9:18 ` Chen Zhou
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2020-01-21 9:01 UTC (permalink / raw)
To: Chen Zhou, davem, mhabets, kuba; +Cc: netdev, linux-kernel
On 21.01.2020 11:54, Chen Zhou wrote:
>>> Fixes coccicheck warning:
>>>
>>> ./drivers/net/ethernet/amd/declance.c:611:14-15:
>>> WARNING comparing pointer to 0
>>>
>>> Compare pointer-typed values to NULL rather than 0.
>>
>> I don't see NULL in the patch -- you used ! instead.
>
> Yeah, i used ! here.
Make the patch description match the diff, please.
> Thanks,
> Chen Zhou
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0
2020-01-21 9:01 ` Sergei Shtylyov
@ 2020-01-21 9:18 ` Chen Zhou
0 siblings, 0 replies; 5+ messages in thread
From: Chen Zhou @ 2020-01-21 9:18 UTC (permalink / raw)
To: Sergei Shtylyov, davem, mhabets, kuba; +Cc: netdev, linux-kernel
On 2020/1/21 17:01, Sergei Shtylyov wrote:
> On 21.01.2020 11:54, Chen Zhou wrote:
>
>>>> Fixes coccicheck warning:
>>>>
>>>> ./drivers/net/ethernet/amd/declance.c:611:14-15:
>>>> WARNING comparing pointer to 0
>>>>
>>>> Compare pointer-typed values to NULL rather than 0.
>>>
>>> I don't see NULL in the patch -- you used ! instead.
>>
>> Yeah, i used ! here.
>
> Make the patch description match the diff, please.
ok, i will fix this in next version.
Thanks,
Chen Zhou
>
>> Thanks,
>> Chen Zhou
>
> MBR, Sergei
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-21 9:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 1:35 [PATCH -next] drivers: net: declance: fix comparing pointer to 0 Chen Zhou
2020-01-21 8:39 ` Sergei Shtylyov
2020-01-21 8:54 ` Chen Zhou
2020-01-21 9:01 ` Sergei Shtylyov
2020-01-21 9:18 ` Chen Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®