From: Binbin Wu <binbin.wu@linux.intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>
Cc: "Gao, Chao" <chao.gao@intel.com>,
"dedekind1@gmail.com" <dedekind1@gmail.com>,
"seanjc@google.com" <seanjc@google.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"kas@kernel.org" <kas@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Maloor, Kishen" <kishen.maloor@intel.com>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH v4 1/4] KVM: TDX: Track configurable CPUID bits allowed by KVM
Date: Tue, 29 Sep 2026 08:19:43 +0800 [thread overview]
Message-ID: <c824aec5-119f-4054-ab47-96839adf08b1@linux.intel.com> (raw)
In-Reply-To: <c2b669f099174c5d67593d5446a02abc43eff40c.camel@intel.com>
On 9/29/2026 7:58 AM, Edgecombe, Rick P wrote:
>
>>
>> My consideration was maybe some userspace could set this bit.
>>
>> But userspace is expected to consult KVM_TDX_CAPABILITIES for the configurable
>> bits before invoking KVM_TDX_INIT_VM
>
> If a guest is already using it, then even if the bit disappears from
> KVM_TDX_CAPABILITIES it could cause a regression when it doesn't get configured
> in the guest.
The precondition is these excluded features bits are not in kvm_cpu_caps[], i.e.
these features are
- Obsolete or
- Not supported by KVM, there would have been issues if a guest is
using them.
I will add the precondition when describe it in the change log.
>
>> , regardless of this patch series, there is no risk to break userspace, except
>> for CORE_CAPABILITIES, which is the only
>> special case as it was defined as fixed-1.
>>
>> I think there is no need to add XTPR to the allow list either.
>
next prev parent reply other threads:[~2026-09-29 0:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 7:25 [PATCH v4 0/4] KVM: TDX: Validate directly configurable CPUID bits Binbin Wu
2026-09-17 7:25 ` [PATCH v4 1/4] KVM: TDX: Track configurable CPUID bits allowed by KVM Binbin Wu
2026-09-23 0:01 ` Edgecombe, Rick P
2026-09-23 0:14 ` Binbin Wu
2026-09-23 0:45 ` Edgecombe, Rick P
2026-09-23 0:57 ` Binbin Wu
2026-09-23 1:09 ` Edgecombe, Rick P
2026-09-23 1:17 ` Binbin Wu
2026-09-23 11:21 ` Xiaoyao Li
2026-09-23 14:25 ` Edgecombe, Rick P
2026-09-24 2:05 ` Xiaoyao Li
2026-09-24 6:36 ` Xiaoyao Li
2026-09-24 7:49 ` Binbin Wu
2026-09-24 9:30 ` Xiaoyao Li
2026-09-24 11:41 ` Binbin Wu
2026-09-24 13:55 ` Xiaoyao Li
2026-09-24 15:10 ` Binbin Wu
2026-09-24 14:33 ` Xiaoyao Li
2026-09-28 8:08 ` Binbin Wu
2026-09-28 23:58 ` Edgecombe, Rick P
2026-09-29 0:19 ` Binbin Wu [this message]
2026-09-17 7:25 ` [PATCH v4 2/4] KVM: TDX: Report CORE_CAPABILITIES as configurable Binbin Wu
2026-09-22 21:11 ` Edgecombe, Rick P
2026-09-23 0:03 ` Binbin Wu
2026-09-24 6:44 ` Xiaoyao Li
2026-09-17 7:25 ` [PATCH v4 3/4] KVM: TDX: Filter configurable CPUID bits Binbin Wu
2026-09-23 0:16 ` Edgecombe, Rick P
2026-09-23 0:28 ` Binbin Wu
2026-09-23 0:34 ` Edgecombe, Rick P
2026-09-17 7:25 ` [PATCH v4 4/4] KVM: TDX: Validate userspace CPUID input for KVM_TDX_INIT_VM Binbin Wu
2026-09-23 0:16 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c824aec5-119f-4054-ab47-96839adf08b1@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dedekind1@gmail.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@linux.intel.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®