[PATCH 0/2] Add support for AD4113

[PATCH 0/2] Add support for AD4113

[Dumitru Ceclan]

This patch series adds support for the AD4113 ADC within the existing
AD7173 driver.

The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
converter (ADC) that integrates an analog front end (AFE) for four
fully differential or eight single-ended inputs.

The part is not released yet and the documentation is not public.
Register map is identical to AD4114. Particularities of this model are
no temperature sensor and 8 VINx inputs.

Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
---
Dumitru Ceclan (2):
      dt-bindings: adc: ad7173: add support for ad4113
      iio: adc: ad7173: add support for ad4113

 .../devicetree/bindings/iio/adc/adi,ad7173.yaml    |  3 +++
 drivers/iio/adc/ad7173.c                           | 22 +++++++++++++++++++++-
 2 files changed, 24 insertions(+), 1 deletion(-)
---
base-commit: 1c61e13d7dc9003662bd7fd6064dfea67e64b014
change-id: 20240725-ad4113-baa63ff99245

Best regards,
-- 
Dumitru Ceclan <dumitru.ceclan@analog.com>

[PATCH 1/2] dt-bindings: adc: ad7173: add support for ad4113

[Dumitru Ceclan]

This commit adds bindings support for AD4113.

The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
converter (ADC) that integrates an analog front end (AFE) for four
fully differential or eight single-ended inputs.

Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
index 17c5d39cc2c1..ad15cf9bc2ff 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
@@ -28,6 +28,7 @@ description: |
   Datasheets for supported chips:
     https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf
     https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf
+    <AD4113: not released yet>
     https://www.analog.com/media/en/technical-documentation/data-sheets/AD4114.pdf
     https://www.analog.com/media/en/technical-documentation/data-sheets/AD4115.pdf
     https://www.analog.com/media/en/technical-documentation/data-sheets/AD4116.pdf
@@ -44,6 +45,7 @@ properties:
     enum:
       - adi,ad4111
       - adi,ad4112
+      - adi,ad4113
       - adi,ad4114
       - adi,ad4115
       - adi,ad4116
@@ -331,6 +333,7 @@ allOf:
             enum:
               - adi,ad4111
               - adi,ad4112
+              - adi,ad4113
               - adi,ad4114
               - adi,ad4115
               - adi,ad4116

-- 
2.43.0

[PATCH 2/2] iio: adc: ad7173: add support for ad4113

[Dumitru Ceclan]

This commit adds support for the AD4113 ADC.
The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
converter (ADC) that integrates an analog front end (AFE) for four
fully differential or eight single-ended inputs.

Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
---
 drivers/iio/adc/ad7173.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
index a854f2d30174..82b63f9705b3 100644
--- a/drivers/iio/adc/ad7173.c
+++ b/drivers/iio/adc/ad7173.c
@@ -3,7 +3,7 @@
  * AD717x and AD411x family SPI ADC driver
  *
  * Supported devices:
- *  AD4111/AD4112/AD4114/AD4115/AD4116
+ *  AD4111/AD4112/AD4113/AD4114/AD4115/AD4116
  *  AD7172-2/AD7172-4/AD7173-8/AD7175-2
  *  AD7175-8/AD7176-2/AD7177-2
  *
@@ -84,6 +84,7 @@
 #define AD4111_ID			AD7173_ID
 #define AD4112_ID			AD7173_ID
 #define AD4114_ID			AD7173_ID
+#define AD4113_ID			0x31D0
 #define AD4116_ID			0x34d0
 #define AD4115_ID			0x38d0
 #define AD7175_8_ID			0x3cd0
@@ -294,6 +295,23 @@ static const struct ad7173_device_info ad4112_device_info = {
 	.num_sinc5_data_rates = ARRAY_SIZE(ad7173_sinc5_data_rates),
 };
 
+static const struct ad7173_device_info ad4113_device_info = {
+	.name = "ad4113",
+	.id = AD4113_ID,
+	.num_voltage_in_div = 8,
+	.num_channels = 16,
+	.num_configs = 8,
+	.num_voltage_in = 8,
+	.num_gpios = 2,
+	.higher_gpio_bits = true,
+	.has_vincom_input = true,
+	.has_input_buf = true,
+	.has_int_ref = true,
+	.clock = 2 * HZ_PER_MHZ,
+	.sinc5_data_rates = ad7173_sinc5_data_rates,
+	.num_sinc5_data_rates = ARRAY_SIZE(ad7173_sinc5_data_rates),
+};
+
 static const struct ad7173_device_info ad4114_device_info = {
 	.name = "ad4114",
 	.id = AD4114_ID,
@@ -1437,6 +1455,7 @@ static int ad7173_probe(struct spi_device *spi)
 static const struct of_device_id ad7173_of_match[] = {
 	{ .compatible = "adi,ad4111",	.data = &ad4111_device_info },
 	{ .compatible = "adi,ad4112",	.data = &ad4112_device_info },
+	{ .compatible = "adi,ad4113",	.data = &ad4113_device_info },
 	{ .compatible = "adi,ad4114",	.data = &ad4114_device_info },
 	{ .compatible = "adi,ad4115",	.data = &ad4115_device_info },
 	{ .compatible = "adi,ad4116",	.data = &ad4116_device_info },
@@ -1454,6 +1473,7 @@ MODULE_DEVICE_TABLE(of, ad7173_of_match);
 static const struct spi_device_id ad7173_id_table[] = {
 	{ "ad4111",   (kernel_ulong_t)&ad4111_device_info },
 	{ "ad4112",   (kernel_ulong_t)&ad4112_device_info },
+	{ "ad4113",   (kernel_ulong_t)&ad4113_device_info },
 	{ "ad4114",   (kernel_ulong_t)&ad4114_device_info },
 	{ "ad4115",   (kernel_ulong_t)&ad4115_device_info },
 	{ "ad4116",   (kernel_ulong_t)&ad4116_device_info },

-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: adc: ad7173: add support for ad4113

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]

On Wed, Aug 07, 2024 at 05:58:04PM +0300, Dumitru Ceclan wrote:
> This commit adds bindings support for AD4113.
> 
> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> converter (ADC) that integrates an analog front end (AFE) for four
> fully differential or eight single-ended inputs.

You should highlight why it is incompatible from existing devices, it's
not clear from the description/diff.

> 
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> index 17c5d39cc2c1..ad15cf9bc2ff 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> @@ -28,6 +28,7 @@ description: |
>    Datasheets for supported chips:
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf
> +    <AD4113: not released yet>
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4114.pdf
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4115.pdf
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4116.pdf
> @@ -44,6 +45,7 @@ properties:
>      enum:
>        - adi,ad4111
>        - adi,ad4112
> +      - adi,ad4113
>        - adi,ad4114
>        - adi,ad4115
>        - adi,ad4116
> @@ -331,6 +333,7 @@ allOf:
>              enum:
>                - adi,ad4111
>                - adi,ad4112
> +              - adi,ad4113
>                - adi,ad4114
>                - adi,ad4115
>                - adi,ad4116
> 
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] iio: adc: ad7173: add support for ad4113

[Nuno Sá]

On Wed, 2024-08-07 at 17:58 +0300, Dumitru Ceclan wrote:
> This commit adds support for the AD4113 ADC.
> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> converter (ADC) that integrates an analog front end (AFE) for four
> fully differential or eight single-ended inputs.
> 
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

>  drivers/iio/adc/ad7173.c | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index a854f2d30174..82b63f9705b3 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -3,7 +3,7 @@
>   * AD717x and AD411x family SPI ADC driver
>   *
>   * Supported devices:
> - *  AD4111/AD4112/AD4114/AD4115/AD4116
> + *  AD4111/AD4112/AD4113/AD4114/AD4115/AD4116
>   *  AD7172-2/AD7172-4/AD7173-8/AD7175-2
>   *  AD7175-8/AD7176-2/AD7177-2
>   *
> @@ -84,6 +84,7 @@
>  #define AD4111_ID			AD7173_ID
>  #define AD4112_ID			AD7173_ID
>  #define AD4114_ID			AD7173_ID
> +#define AD4113_ID			0x31D0
>  #define AD4116_ID			0x34d0
>  #define AD4115_ID			0x38d0
>  #define AD7175_8_ID			0x3cd0
> @@ -294,6 +295,23 @@ static const struct ad7173_device_info ad4112_device_info
> = {
>  	.num_sinc5_data_rates = ARRAY_SIZE(ad7173_sinc5_data_rates),
>  };
>  
> +static const struct ad7173_device_info ad4113_device_info = {
> +	.name = "ad4113",
> +	.id = AD4113_ID,
> +	.num_voltage_in_div = 8,
> +	.num_channels = 16,
> +	.num_configs = 8,
> +	.num_voltage_in = 8,
> +	.num_gpios = 2,
> +	.higher_gpio_bits = true,
> +	.has_vincom_input = true,
> +	.has_input_buf = true,
> +	.has_int_ref = true,
> +	.clock = 2 * HZ_PER_MHZ,
> +	.sinc5_data_rates = ad7173_sinc5_data_rates,
> +	.num_sinc5_data_rates = ARRAY_SIZE(ad7173_sinc5_data_rates),
> +};
> +
>  static const struct ad7173_device_info ad4114_device_info = {
>  	.name = "ad4114",
>  	.id = AD4114_ID,
> @@ -1437,6 +1455,7 @@ static int ad7173_probe(struct spi_device *spi)
>  static const struct of_device_id ad7173_of_match[] = {
>  	{ .compatible = "adi,ad4111",	.data = &ad4111_device_info },
>  	{ .compatible = "adi,ad4112",	.data = &ad4112_device_info },
> +	{ .compatible = "adi,ad4113",	.data = &ad4113_device_info },
>  	{ .compatible = "adi,ad4114",	.data = &ad4114_device_info },
>  	{ .compatible = "adi,ad4115",	.data = &ad4115_device_info },
>  	{ .compatible = "adi,ad4116",	.data = &ad4116_device_info },
> @@ -1454,6 +1473,7 @@ MODULE_DEVICE_TABLE(of, ad7173_of_match);
>  static const struct spi_device_id ad7173_id_table[] = {
>  	{ "ad4111",   (kernel_ulong_t)&ad4111_device_info },
>  	{ "ad4112",   (kernel_ulong_t)&ad4112_device_info },
> +	{ "ad4113",   (kernel_ulong_t)&ad4113_device_info },
>  	{ "ad4114",   (kernel_ulong_t)&ad4114_device_info },
>  	{ "ad4115",   (kernel_ulong_t)&ad4115_device_info },
>  	{ "ad4116",   (kernel_ulong_t)&ad4116_device_info },
>