* [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
@ 2026-09-03 15:23 Colin Ian King
2026-09-03 19:06 ` Matthew Sakai
0 siblings, 1 reply; 6+ messages in thread
From: Colin Ian King @ 2026-09-03 15:23 UTC (permalink / raw)
To: Matthew Sakai, dm-devel; +Cc: kernel-janitors, linux-kernel
There is another spelling mistake in a vdo_log_error message that
I somehow overlooked last time. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-vdo/dm-vdo-target.c b/drivers/md/dm-vdo/dm-vdo-target.c
index 1d8375cc3c3e..043549b1fc2e 100644
--- a/drivers/md/dm-vdo/dm-vdo-target.c
+++ b/drivers/md/dm-vdo/dm-vdo-target.c
@@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char *slab_str, block_count_t *sla
result = kstrtoull(slab_str, 10, &value);
if (result) {
- vdo_log_error("optional parameter error: invalid slab size, must be a postive integer");
+ vdo_log_error("optional parameter error: invalid slab size, must be a positive integer");
return -EINVAL;
}
--
2.55.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
2026-09-03 15:23 [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive" Colin Ian King
@ 2026-09-03 19:06 ` Matthew Sakai
2026-09-03 19:25 ` Robert P. J. Day
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Sakai @ 2026-09-03 19:06 UTC (permalink / raw)
To: Colin Ian King, dm-devel; +Cc: kernel-janitors, linux-kernel
I had to look at this for quite a while to figure out what was going on.
We made the same spelling error twice in the same function and somehow
only noticed the first one previously? Anyway,
Reviewed-by: Matthew Sakai <msakai@redhat.com>
On 9/3/26 11:23 AM, Colin Ian King wrote:
> There is another spelling mistake in a vdo_log_error message that
> I somehow overlooked last time. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-vdo/dm-vdo-target.c b/drivers/md/dm-vdo/dm-vdo-target.c
> index 1d8375cc3c3e..043549b1fc2e 100644
> --- a/drivers/md/dm-vdo/dm-vdo-target.c
> +++ b/drivers/md/dm-vdo/dm-vdo-target.c
> @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char *slab_str, block_count_t *sla
>
> result = kstrtoull(slab_str, 10, &value);
> if (result) {
> - vdo_log_error("optional parameter error: invalid slab size, must be a postive integer");
> + vdo_log_error("optional parameter error: invalid slab size, must be a positive integer");
> return -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
2026-09-03 19:06 ` Matthew Sakai
@ 2026-09-03 19:25 ` Robert P. J. Day
2026-09-03 19:29 ` Colin King (gmail)
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2026-09-03 19:25 UTC (permalink / raw)
To: Matthew Sakai; +Cc: Colin Ian King, dm-devel, kernel-janitors, linux-kernel
On Thu, 3 Sep 2026, Matthew Sakai wrote:
> I had to look at this for quite a while to figure out what was going on.
> We made the same spelling error twice in the same function and somehow only
> noticed the first one previously? Anyway,
>
> Reviewed-by: Matthew Sakai <msakai@redhat.com>
>
> On 9/3/26 11:23 AM, Colin Ian King wrote:
> > There is another spelling mistake in a vdo_log_error message that
> > I somehow overlooked last time. Fix it.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> > drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/dm-vdo/dm-vdo-target.c
> > b/drivers/md/dm-vdo/dm-vdo-target.c
> > index 1d8375cc3c3e..043549b1fc2e 100644
> > --- a/drivers/md/dm-vdo/dm-vdo-target.c
> > +++ b/drivers/md/dm-vdo/dm-vdo-target.c
> > @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char
> > *slab_str, block_count_t *sla
> > result = kstrtoull(slab_str, 10, &value);
> > if (result) {
> > - vdo_log_error("optional parameter error: invalid slab size,
> > must be a postive integer");
> > + vdo_log_error("optional parameter error: invalid slab size,
> > must be a positive integer");
> > return -EINVAL;
> > }
My rule from years back was ... you find one typo, you "grep -rw"
the entire kernel tree.
rday
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
2026-09-03 19:25 ` Robert P. J. Day
@ 2026-09-03 19:29 ` Colin King (gmail)
0 siblings, 0 replies; 6+ messages in thread
From: Colin King (gmail) @ 2026-09-03 19:29 UTC (permalink / raw)
To: Robert P. J. Day, Matthew Sakai; +Cc: dm-devel, kernel-janitors, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1530 bytes --]
On 03/09/2026 20:25, Robert P. J. Day wrote:
> On Thu, 3 Sep 2026, Matthew Sakai wrote:
>
>> I had to look at this for quite a while to figure out what was going on.
>> We made the same spelling error twice in the same function and somehow only
>> noticed the first one previously? Anyway,
>>
>> Reviewed-by: Matthew Sakai <msakai@redhat.com>
>>
>> On 9/3/26 11:23 AM, Colin Ian King wrote:
>>> There is another spelling mistake in a vdo_log_error message that
>>> I somehow overlooked last time. Fix it.
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>> ---
>>> drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/md/dm-vdo/dm-vdo-target.c
>>> b/drivers/md/dm-vdo/dm-vdo-target.c
>>> index 1d8375cc3c3e..043549b1fc2e 100644
>>> --- a/drivers/md/dm-vdo/dm-vdo-target.c
>>> +++ b/drivers/md/dm-vdo/dm-vdo-target.c
>>> @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char
>>> *slab_str, block_count_t *sla
>>> result = kstrtoull(slab_str, 10, &value);
>>> if (result) {
>>> - vdo_log_error("optional parameter error: invalid slab size,
>>> must be a postive integer");
>>> + vdo_log_error("optional parameter error: invalid slab size,
>>> must be a positive integer");
>>> return -EINVAL;
>>> }
>
> My rule from years back was ... you find one typo, you "grep -rw"
> the entire kernel tree.
Yup, normally do, somehow this slipped through :-(
>
> rday
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
@ 2026-03-28 12:33 Colin Ian King
2026-03-31 12:40 ` Matthew Sakai
0 siblings, 1 reply; 6+ messages in thread
From: Colin Ian King @ 2026-03-28 12:33 UTC (permalink / raw)
To: Matthew Sakai, dm-devel; +Cc: kernel-janitors, linux-kernel
There is a spelling mistake in a vdo_log_error message. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-vdo/dm-vdo-target.c b/drivers/md/dm-vdo/dm-vdo-target.c
index 0135a6f941fd..1d8375cc3c3e 100644
--- a/drivers/md/dm-vdo/dm-vdo-target.c
+++ b/drivers/md/dm-vdo/dm-vdo-target.c
@@ -412,7 +412,7 @@ static int __must_check parse_memory(const char *memory_str,
result = kstrtouint(memory_str, 10, &value);
if (result) {
- vdo_log_error("optional parameter error: invalid memory size, must be a postive integer");
+ vdo_log_error("optional parameter error: invalid memory size, must be a positive integer");
return -EINVAL;
}
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"
2026-03-28 12:33 Colin Ian King
@ 2026-03-31 12:40 ` Matthew Sakai
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Sakai @ 2026-03-31 12:40 UTC (permalink / raw)
To: Colin Ian King, dm-devel; +Cc: kernel-janitors, linux-kernel
On 3/28/26 8:33 AM, Colin Ian King wrote:
> There is a spelling mistake in a vdo_log_error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Matthew Sakai <msakai@redhat.com>
Since this is a change to Bruce's recent series, it might make sense to
fold this into one of those patches instead of applying it as a
standalone patch.
Matt
> ---
> drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-vdo/dm-vdo-target.c b/drivers/md/dm-vdo/dm-vdo-target.c
> index 0135a6f941fd..1d8375cc3c3e 100644
> --- a/drivers/md/dm-vdo/dm-vdo-target.c
> +++ b/drivers/md/dm-vdo/dm-vdo-target.c
> @@ -412,7 +412,7 @@ static int __must_check parse_memory(const char *memory_str,
>
> result = kstrtouint(memory_str, 10, &value);
> if (result) {
> - vdo_log_error("optional parameter error: invalid memory size, must be a postive integer");
> + vdo_log_error("optional parameter error: invalid memory size, must be a positive integer");
> return -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-03 20:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-03 15:23 [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive" Colin Ian King
2026-09-03 19:06 ` Matthew Sakai
2026-09-03 19:25 ` Robert P. J. Day
2026-09-03 19:29 ` Colin King (gmail)
-- strict thread matches above, loose matches on Subject: below --
2026-03-28 12:33 Colin Ian King
2026-03-31 12:40 ` Matthew Sakai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®