From: Paul Cercueil <paul.cercueil@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Takahiro Kuwano <takahiro.kuwano@infineon.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org,
Bharat Bhushan <bbhushan2@marvell.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Tanmay Jagdale <tanmay@marvell.com>
Subject: Re: [PATCH v3 6/7] spi: cadence-xspi: Add support for panic writes
Date: Fri, 16 Oct 2026 10:55:43 +0200 [thread overview]
Message-ID: <d6490c5d09075a152909c2be00c2a6f23256c61d.camel@bootlin.com> (raw)
In-Reply-To: <f6008943-c4cb-43ae-a791-31965f374ffd@sirena.org.uk>
Hi Mark,
Le jeudi 15 octobre 2026 à 13:09 +0100, Mark Brown a écrit :
> On Wed, Oct 14, 2026 at 05:43:00PM +0200, Paul Cercueil wrote:
> > From: Tanmay Jagdale <tanmay@marvell.com>
> >
> > Advertise support for panic writes. When a memory op is received with
> > the 'panic' flag set, the driver will then work without relying on
> > interrupts and without sleeping.
>
> We check device properties in cdns_xspi_supports_op() if the kernel is
> built with ACPI support, that ends up using of_find_property() which
> takes the devtree lock which means there's a possibility that we might
> deadlock (eg, if we took a NMI or the CPU fell over at the wrong
> moment). This is probably thin enough it's not worth stopping the
> entire series over, it could be fixed incrementally by storing the
> values during probe.
ACK.
I have an extra set of cleanups in my queue for spi-cadence-xspi so I'll change
it there.
Cheers,
-Paul
next prev parent reply other threads:[~2026-10-16 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 15:42 [PATCH v3 0/7] spi: Add support for panic mem writes Paul Cercueil
2026-10-14 15:42 ` [PATCH v3 1/7] spi: spi-mem: " Paul Cercueil
2026-10-14 15:42 ` [PATCH v3 2/7] mtd: spi-nor: Wait for NOR ready with poll_timeout_us() Paul Cercueil
2026-10-15 12:10 ` Mark Brown
2026-10-14 15:42 ` [PATCH v3 3/7] mtd: spi-nor: Add support for panic writes Paul Cercueil
2026-10-14 15:42 ` [PATCH v3 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Paul Cercueil
2026-10-14 15:42 ` [PATCH v3 5/7] spi: cadence-xspi: Add irq-less support Paul Cercueil
2026-10-14 15:43 ` [PATCH v3 6/7] spi: cadence-xspi: Add support for panic writes Paul Cercueil
2026-10-15 12:09 ` Mark Brown
2026-10-16 8:55 ` Paul Cercueil [this message]
2026-10-14 15:43 ` [PATCH v3 7/7] spi: dt-bindings: cadence: Make XSPI's IRQ line optional Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6490c5d09075a152909c2be00c2a6f23256c61d.camel@bootlin.com \
--to=paul.cercueil@bootlin.com \
--cc=bbhushan2@marvell.com \
--cc=broonie@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sgoutham@marvell.com \
--cc=takahiro.kuwano@infineon.com \
--cc=tanmay@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tony.luck@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®