* [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon
@ 2022-06-29 3:00 Li kunyu
2022-07-11 20:55 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Li kunyu @ 2022-06-29 3:00 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, Li kunyu
I think this semicolon could be deleted.
Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
include/trace/events/iocost.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
index e282ce02fa2d..6d1626e7a4ce 100644
--- a/include/trace/events/iocost.h
+++ b/include/trace/events/iocost.h
@@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
TP_fast_assign(
__assign_str(devname, ioc_name(ioc));
- __entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
+ __entry->old_vrate = atomic64_read(&ioc->vtime_rate);
__entry->new_vrate = new_vrate;
__entry->busy_level = ioc->busy_level;
__entry->read_missed_ppm = missed_ppm[READ];
--
2.18.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon
2022-06-29 3:00 [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon Li kunyu
@ 2022-07-11 20:55 ` Steven Rostedt
2022-07-11 20:57 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2022-07-11 20:55 UTC (permalink / raw)
To: Li kunyu; +Cc: mingo, linux-kernel, Tejun Heo, Jens Axboe
Jens,
Want to take this one? Or I can if you don't.
-- Steve
On Wed, 29 Jun 2022 11:00:13 +0800
Li kunyu <kunyu@nfschina.com> wrote:
> I think this semicolon could be deleted.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> include/trace/events/iocost.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index e282ce02fa2d..6d1626e7a4ce 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
>
> TP_fast_assign(
> __assign_str(devname, ioc_name(ioc));
> - __entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
> + __entry->old_vrate = atomic64_read(&ioc->vtime_rate);
> __entry->new_vrate = new_vrate;
> __entry->busy_level = ioc->busy_level;
> __entry->read_missed_ppm = missed_ppm[READ];
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon
2022-07-11 20:55 ` Steven Rostedt
@ 2022-07-11 20:57 ` Jens Axboe
2022-07-11 21:02 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2022-07-11 20:57 UTC (permalink / raw)
To: Steven Rostedt, Li kunyu; +Cc: mingo, linux-kernel, Tejun Heo
On 7/11/22 2:55 PM, Steven Rostedt wrote:
> Jens,
>
> Want to take this one? Or I can if you don't.
You can just include it in the trace commits, that's fine. Thanks!
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon
2022-07-11 20:57 ` Jens Axboe
@ 2022-07-11 21:02 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2022-07-11 21:02 UTC (permalink / raw)
To: Jens Axboe; +Cc: Li kunyu, mingo, linux-kernel, Tejun Heo
On Mon, 11 Jul 2022 14:57:51 -0600
Jens Axboe <axboe@kernel.dk> wrote:
> On 7/11/22 2:55 PM, Steven Rostedt wrote:
> > Jens,
> >
> > Want to take this one? Or I can if you don't.
>
> You can just include it in the trace commits, that's fine. Thanks!
>
Will do. I'm working on something to push for Linus this week, I'll include
it with that. I don't think this needs to wait till the merge window.
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-11 21:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 3:00 [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon Li kunyu
2022-07-11 20:55 ` Steven Rostedt
2022-07-11 20:57 ` Jens Axboe
2022-07-11 21:02 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®