* [PATCH 0/2] Commonize pinctrl for camera master clock on Qualcomm SDM845
@ 2025-12-13 12:00 David Heidelberg via B4 Relay
2025-12-13 12:00 ` [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
2025-12-13 12:00 ` [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default David Heidelberg via B4 Relay
0 siblings, 2 replies; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-12-13 12:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, David Heidelberg
Inspired by Richard's patch set for SDM670, I noticed that SDM845
follows the same pattern. This change prepares for enabling
additional cameras.
These pinctrl settings have been verified against the downstream
SDM845 kernel.
Since most of these are not yet used in mainline, testing was done
on sdm845-next using OnePlus 6 cameras with downstream drivers.
Thank you
David
Signed-off-by: David Heidelberg <david@ixit.cz>
---
David Heidelberg (2):
arm64: qcom: sdm845: Introduce camera master clock pinctrl
arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default
.../qcom/sdm845-db845c-navigation-mezzanine.dtso | 2 +-
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 8 ----
arch/arm64/boot/dts/qcom/sdm845.dtsi | 43 ++++++++++++++++++++++
3 files changed, 44 insertions(+), 9 deletions(-)
---
base-commit: d9771d0dbe18dd643760431870a6abf9b0866bb0
change-id: 20251213-sdm845-mclk-041f2a952e31
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl
2025-12-13 12:00 [PATCH 0/2] Commonize pinctrl for camera master clock on Qualcomm SDM845 David Heidelberg via B4 Relay
@ 2025-12-13 12:00 ` David Heidelberg via B4 Relay
2025-12-14 0:09 ` Vladimir Zapolskiy
` (2 more replies)
2025-12-13 12:00 ` [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default David Heidelberg via B4 Relay
1 sibling, 3 replies; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-12-13 12:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, David Heidelberg
From: David Heidelberg <david@ixit.cz>
There are shared for the whole architecture, so let's define these in
proper place.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 43 ++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index bf2f9c04adba7..97bd9513b011b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2805,6 +2805,49 @@ tlmm: pinctrl@3400000 {
gpio-ranges = <&tlmm 0 0 151>;
wakeup-parent = <&pdc_intc>;
+ cam_mclk0_default: cam-mclk0-default-state {
+ pins = "gpio13";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cam_mclk0_sleep: cam-mclk0-sleep-state {
+ pins = "gpio13";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ cam_mclk1_default: cam-mclk1-default-state {
+ pins = "gpio14";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cam_mclk1_sleep: cam-mclk1-sleep-state {
+ pins = "gpio14";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ cam_mclk2_default: cam-mclk2-default-state {
+ pins = "gpio15";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cam_mclk2_sleep: cam-mclk2-sleep-state {
+ pins = "gpio15";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+
cci0_default: cci0-default-state {
/* SDA, SCL */
pins = "gpio17", "gpio18";
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default
2025-12-13 12:00 [PATCH 0/2] Commonize pinctrl for camera master clock on Qualcomm SDM845 David Heidelberg via B4 Relay
2025-12-13 12:00 ` [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
@ 2025-12-13 12:00 ` David Heidelberg via B4 Relay
2025-12-14 0:12 ` Vladimir Zapolskiy
2025-12-17 11:11 ` Konrad Dybcio
1 sibling, 2 replies; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-12-13 12:00 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, David Heidelberg
From: David Heidelberg <david@ixit.cz>
All Snapdragon 845 platform has same controls GPIOs.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 2 +-
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 8 --------
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
index dbe1911d8e470..f6c2c98970d76 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
@@ -40,7 +40,7 @@ camera@10 {
/* CAM0_RST_N */
reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
- pinctrl-0 = <&cam0_default>;
+ pinctrl-0 = <&cam0_default &cam_mclk0_default>;
clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
clock-names = "xvclk";
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index ce23f87e0316b..981d19c20fa1f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -877,14 +877,6 @@ rst-pins {
drive-strength = <16>;
bias-disable;
};
-
- mclk0-pins {
- pins = "gpio13";
- function = "cam_mclk";
-
- drive-strength = <16>;
- bias-disable;
- };
};
cam3_default: cam3-default-state {
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl
2025-12-13 12:00 ` [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
@ 2025-12-14 0:09 ` Vladimir Zapolskiy
2025-12-16 12:54 ` Bryan O'Donoghue
2025-12-17 11:11 ` Konrad Dybcio
2 siblings, 0 replies; 8+ messages in thread
From: Vladimir Zapolskiy @ 2025-12-14 0:09 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel
On 12/13/25 14:00, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> There are shared for the whole architecture, so let's define these in
> proper place.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 43 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index bf2f9c04adba7..97bd9513b011b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2805,6 +2805,49 @@ tlmm: pinctrl@3400000 {
> gpio-ranges = <&tlmm 0 0 151>;
> wakeup-parent = <&pdc_intc>;
>
> + cam_mclk0_default: cam-mclk0-default-state {
> + pins = "gpio13";
> + function = "cam_mclk";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + cam_mclk0_sleep: cam-mclk0-sleep-state {
> + pins = "gpio13";
> + function = "cam_mclk";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + cam_mclk1_default: cam-mclk1-default-state {
> + pins = "gpio14";
> + function = "cam_mclk";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + cam_mclk1_sleep: cam-mclk1-sleep-state {
> + pins = "gpio14";
> + function = "cam_mclk";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + cam_mclk2_default: cam-mclk2-default-state {
> + pins = "gpio15";
> + function = "cam_mclk";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + cam_mclk2_sleep: cam-mclk2-sleep-state {
> + pins = "gpio15";
> + function = "cam_mclk";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> +
Please remove an excessive blank line.
> cci0_default: cci0-default-state {
> /* SDA, SCL */
> pins = "gpio17", "gpio18";
>
Please add mclk3 to the list, it's one of the gpio16 pad functions.
After adding that
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default
2025-12-13 12:00 ` [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default David Heidelberg via B4 Relay
@ 2025-12-14 0:12 ` Vladimir Zapolskiy
2025-12-17 11:11 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: Vladimir Zapolskiy @ 2025-12-14 0:12 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel
On 12/13/25 14:00, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> All Snapdragon 845 platform has same controls GPIOs.
It's a bit clumsy and not very informative commit message, and MCLK is
not a "control GPIO", it's a pad function.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 2 +-
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 8 --------
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> index dbe1911d8e470..f6c2c98970d76 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> @@ -40,7 +40,7 @@ camera@10 {
> /* CAM0_RST_N */
> reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> - pinctrl-0 = <&cam0_default>;
> + pinctrl-0 = <&cam0_default &cam_mclk0_default>;
>
> clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> clock-names = "xvclk";
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index ce23f87e0316b..981d19c20fa1f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -877,14 +877,6 @@ rst-pins {
> drive-strength = <16>;
> bias-disable;
> };
> -
> - mclk0-pins {
> - pins = "gpio13";
> - function = "cam_mclk";
> -
> - drive-strength = <16>;
> - bias-disable;
> - };
> };
>
> cam3_default: cam3-default-state {
>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl
2025-12-13 12:00 ` [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
2025-12-14 0:09 ` Vladimir Zapolskiy
@ 2025-12-16 12:54 ` Bryan O'Donoghue
2025-12-17 11:11 ` Konrad Dybcio
2 siblings, 0 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2025-12-16 12:54 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel
On 13/12/2025 12:00, David Heidelberg via B4 Relay wrote:
> There are
*These are
---
bod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default
2025-12-13 12:00 ` [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default David Heidelberg via B4 Relay
2025-12-14 0:12 ` Vladimir Zapolskiy
@ 2025-12-17 11:11 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-12-17 11:11 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel
On 12/13/25 1:00 PM, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> All Snapdragon 845 platform has same controls GPIOs.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 2 +-
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 8 --------
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> index dbe1911d8e470..f6c2c98970d76 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> @@ -40,7 +40,7 @@ camera@10 {
> /* CAM0_RST_N */
> reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> - pinctrl-0 = <&cam0_default>;
> + pinctrl-0 = <&cam0_default &cam_mclk0_default>;
>
> clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> clock-names = "xvclk";
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index ce23f87e0316b..981d19c20fa1f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -877,14 +877,6 @@ rst-pins {
> drive-strength = <16>;
> bias-disable;
> };
> -
> - mclk0-pins {
> - pins = "gpio13";
> - function = "cam_mclk";
> -
> - drive-strength = <16>;
> - bias-disable;
> - };
Please also remove the mclk3 below
Konrad
> };
>
> cam3_default: cam3-default-state {
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl
2025-12-13 12:00 ` [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
2025-12-14 0:09 ` Vladimir Zapolskiy
2025-12-16 12:54 ` Bryan O'Donoghue
@ 2025-12-17 11:11 ` Konrad Dybcio
2 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-12-17 11:11 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel
On 12/13/25 1:00 PM, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> There are shared for the whole architecture, so let's define these in
> proper place.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
In addition to Vlad's comments, please add the missing "dts: " to
the commit title
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-12-17 11:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-13 12:00 [PATCH 0/2] Commonize pinctrl for camera master clock on Qualcomm SDM845 David Heidelberg via B4 Relay
2025-12-13 12:00 ` [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
2025-12-14 0:09 ` Vladimir Zapolskiy
2025-12-16 12:54 ` Bryan O'Donoghue
2025-12-17 11:11 ` Konrad Dybcio
2025-12-13 12:00 ` [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default David Heidelberg via B4 Relay
2025-12-14 0:12 ` Vladimir Zapolskiy
2025-12-17 11:11 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®