mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Li, Xiaoyao" <xiaoyao.li@intel.com>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
	"x86@kernel.org" <x86@kernel.org>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"kas@kernel.org" <kas@kernel.org>,
	"seanjc@google.com" <seanjc@google.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"Peng, Chao P" <chao.p.peng@intel.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	"jgg@nvidia.com" <jgg@nvidia.com>,
	"aneesh.kumar@kernel.org" <aneesh.kumar@kernel.org>,
	"Verma, Vishal L" <vishal.l.verma@intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"bp@alien8.de" <bp@alien8.de>, "Gao, Chao" <chao.gao@intel.com>,
	"aik@amd.com" <aik@amd.com>,
	"yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Subject: Re: [RFC PATCH 06/15] virt: tdx-guest: Support TDI bind and unbind operations
Date: Mon, 9 Nov 2026 23:38:55 +0000	[thread overview]
Message-ID: <d9f4f891962900f6eab756baca4ab4c1a4b235ad.camel@intel.com> (raw)
In-Reply-To: <IA3PR11MB91364D04E26736B09B444B9E92762@IA3PR11MB9136.namprd11.prod.outlook.com>

On Fri, 2026-11-06 at 03:03 +0000, Duan, Zhenzhong wrote:
> > 
> > So is this only a bad host behavior? Or something where we could expect in
> > practice the host will not be able to handle it, and at the same time, want
> > to
> > keep the guest running?
> 
> I used a misbehaving VMM only as an example. Failures can also happen
> with a cooperative host, for example if the device becomes unavailable
> after a host-side administrative action, or if its firmware hangs during
> lock/unlock.

We need to characterize the failures we are handling. Anything that we want to
hand back to TSM to handle we should discuss as part of the TSM subsystem work.
We also need to ask whether the host should be handling any of these errors.

I think for VMM bugs, we should not try to handle them in the guest in order to
keep it running. In fact some security conscious users may prefer to have the
guest stop working if strange behavior is noticed. But in any case, bugs should
be fixed and not grow code to work around them in other components.

If there are scenarios that are more RAS-type in nature, where HW breaks, then
I'd think this is a more advanced capability. I'd think we should prefer to punt
on the ability to have the guest survive rare malfunctions if we can for initial
support.

As I explained up the thread, you need to evaluate the concrete scenarios we are
handling and make the case for which component in the guest should handle it.
And what level of abstraction is appropriate for any erros reported to TSM.

> 
> These failures need not prevent the rest of the guest from running.
> If the host reports a TDCM error, the guest propagates it to userspace
> through the sysfs unlock operation.
> 
> Keeping the guest running is therefore useful in these cases, even
> if the affected device is no longer usable.
> 
> If a host-side failure cannot be reported to the guest and makes
> continued execution unsafe, e.g., device AER error, the host could
> terminate the guest.



  reply	other threads:[~2026-11-09 23:38 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  4:10 [RFC PATCH 00/15] PCI/TSM: coco/tdx-guest: Implement TDX-Connect PCIe TDISP (phase2) Zhenzhong Duan
2026-09-24  4:10 ` [RFC PATCH 01/15] x86/tdx: Export tdg_vm_rd() for tdx-guest module Zhenzhong Duan
2026-09-30 22:13   ` Peter Fang
2026-10-01 12:38     ` Xu Yilun
2026-10-08  6:45       ` Duan, Zhenzhong
2026-10-08 16:30         ` Edgecombe, Rick P
2026-09-24  4:10 ` [RFC PATCH 02/15] x86/tdx: Add TDCM hypercall wrapper for TDX Connect Zhenzhong Duan
2026-10-13 14:34   ` Nikolay Borisov
2026-10-14  6:19     ` Duan, Zhenzhong
2026-10-14  6:27       ` Nikolay Borisov
2026-10-14  7:22         ` Duan, Zhenzhong
2026-10-26  0:33   ` Xiaoyao Li
2026-10-27  3:28     ` Duan, Zhenzhong
2026-10-27  5:49       ` Xiaoyao Li
2026-10-27  6:08         ` Duan, Zhenzhong
2026-10-29  2:15           ` Xiaoyao Li
2026-10-29  7:34             ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 03/15] x86/tdx: Add TDG.TDI.RD module call " Zhenzhong Duan
2026-09-25  0:06   ` Edgecombe, Rick P
2026-10-08  6:27     ` Duan, Zhenzhong
2026-10-08 16:42       ` Edgecombe, Rick P
2026-10-09  2:28         ` Duan, Zhenzhong
2026-10-26  0:51   ` Xiaoyao Li
2026-10-27  6:22     ` Duan, Zhenzhong
2026-11-02 21:07       ` Edgecombe, Rick P
2026-11-03 13:11         ` Duan, Zhenzhong
2026-11-03 21:04           ` Edgecombe, Rick P
2026-11-04 10:16             ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 04/15] virt: tdx-guest: Support devsec TSM for secure devices Zhenzhong Duan
2026-10-15 13:42   ` Xu Yilun
2026-10-16  6:42     ` Duan, Zhenzhong
2026-10-26  1:12   ` Xiaoyao Li
2026-10-27  7:20     ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 05/15] virt: tdx-guest: Add TDCM helpers and TEE-IO support check Zhenzhong Duan
2026-10-13 14:31   ` Nikolay Borisov
2026-10-14  6:11     ` Duan, Zhenzhong
2026-10-26  1:26       ` Xiaoyao Li
2026-10-26  7:13         ` Nikolay Borisov
2026-10-28  5:42           ` Duan, Zhenzhong
2026-10-28  6:51             ` Nikolay Borisov
2026-10-14 12:52   ` Nikolay Borisov
2026-10-15  6:24     ` Duan, Zhenzhong
2026-10-26  2:06   ` Xiaoyao Li
2026-10-27  8:32     ` Duan, Zhenzhong
2026-10-29  2:27       ` Xiaoyao Li
2026-09-24  4:10 ` [RFC PATCH 06/15] virt: tdx-guest: Support TDI bind and unbind operations Zhenzhong Duan
2026-10-13 12:10   ` Nikolay Borisov
2026-10-14  3:06     ` Duan, Zhenzhong
2026-10-14  6:32       ` Nikolay Borisov
2026-10-14  7:33         ` Duan, Zhenzhong
2026-11-04  8:20           ` Xu Yilun
2026-11-04  9:03             ` Duan, Zhenzhong
2026-10-17 18:38   ` Nikolay Borisov
2026-10-19  2:16     ` Duan, Zhenzhong
2026-10-26  2:32       ` Xiaoyao Li
2026-10-27  8:58         ` Duan, Zhenzhong
2026-10-29  2:38           ` Xiaoyao Li
2026-10-29  7:42             ` Duan, Zhenzhong
2026-10-29  3:26           ` Duan, Zhenzhong
2026-11-02 21:11             ` Edgecombe, Rick P
2026-11-03  8:49               ` Duan, Zhenzhong
2026-11-03 21:07                 ` Edgecombe, Rick P
2026-11-04  8:59                   ` Duan, Zhenzhong
2026-11-04 14:39                     ` Edgecombe, Rick P
2026-11-05  4:37                       ` Duan, Zhenzhong
2026-11-05 19:06                         ` Edgecombe, Rick P
2026-11-06  3:03                           ` Duan, Zhenzhong
2026-11-09 23:38                             ` Edgecombe, Rick P [this message]
2026-10-26  2:38   ` Xiaoyao Li
2026-10-27 10:14     ` Duan, Zhenzhong
2026-11-02 21:15       ` Edgecombe, Rick P
2026-11-03  6:02         ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 07/15] PCI/TSM: Track Device Interface Report MMIO range index Zhenzhong Duan
2026-10-26  2:45   ` Xiaoyao Li
2026-10-27  9:11     ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 08/15] x86/tdx: Add TDG.MMIO.ACCEPT module call wrapper for TDX Connect Zhenzhong Duan
2026-09-24 23:41   ` Edgecombe, Rick P
2026-09-25  0:02     ` Edgecombe, Rick P
2026-10-08  6:01       ` Duan, Zhenzhong
2026-10-08 16:47         ` Edgecombe, Rick P
2026-10-08  5:49     ` Duan, Zhenzhong
2026-10-08 16:44       ` Edgecombe, Rick P
2026-10-09  2:16         ` Duan, Zhenzhong
2026-11-03  7:48   ` Xiaoyao Li
2026-09-24  4:10 ` [RFC PATCH 09/15] virt: tdx-guest: Capture the TDI report during device lock Zhenzhong Duan
2026-10-26  5:04   ` Xiaoyao Li
2026-10-28  3:23     ` Duan, Zhenzhong
2026-11-02 21:19       ` Edgecombe, Rick P
2026-11-03  0:36         ` Jason Gunthorpe
2026-11-03  0:48           ` Edgecombe, Rick P
2026-11-03  1:26             ` Jason Gunthorpe
2026-11-03 21:11               ` Edgecombe, Rick P
2026-11-04  8:08         ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 10/15] virt: tdx-guest: Set up and accept private MMIO ranges Zhenzhong Duan
2026-10-26  5:22   ` Xiaoyao Li
2026-10-28  3:32     ` Duan, Zhenzhong
2026-10-29  2:44       ` Xiaoyao Li
2026-10-29  9:56     ` Duan, Zhenzhong
2026-11-02 22:38       ` Edgecombe, Rick P
2026-09-24  4:10 ` [RFC PATCH 11/15] x86/tdx: Add TDG.TDI.START module call wrapper for TDX Connect Zhenzhong Duan
2026-09-24  4:10 ` [RFC PATCH 12/15] virt: tdx-guest: Support Trust Device Interface (TDI) activation Zhenzhong Duan
2026-10-26  7:19   ` Xiaoyao Li
2026-10-28  6:44     ` Duan, Zhenzhong
2026-10-28 12:41       ` Jason Gunthorpe
2026-10-29  2:24         ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 13/15] x86/tdx: Add __tdcall_saved() helper Zhenzhong Duan
2026-10-26  7:35   ` Xiaoyao Li
2026-09-24  4:10 ` [RFC PATCH 14/15] x86/tdx: Add TDG.DMAR.ACCEPT module call wrapper for TDX Connect Zhenzhong Duan
2026-10-26  7:39   ` Xiaoyao Li
2026-10-28  5:57     ` Duan, Zhenzhong
2026-09-24  4:10 ` [RFC PATCH 15/15] virt: tdx-guest: Accept default DMAR entry during PCI driver attach Zhenzhong Duan
2026-10-26  7:49   ` Xiaoyao Li
2026-10-26 12:02     ` Jason Gunthorpe
2026-10-28  9:39     ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9f4f891962900f6eab756baca4ab4c1a4b235ad.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=aik@amd.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=bp@alien8.de \
    --cc=chao.gao@intel.com \
    --cc=chao.p.peng@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jgg@nvidia.com \
    --cc=kas@kernel.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nicolinc@nvidia.com \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@kernel.org \
    --cc=vishal.l.verma@intel.com \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    --cc=yilun.xu@linux.intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®