mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Add support for the ASUS ROG Phone 3 (SM8250)
@ 2026-03-11  2:43 Alexander Koskovich
  2026-03-11  2:43 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add ASUS ROG Phone 3 Alexander Koskovich
  2026-03-11  2:43 ` [PATCH v3 2/2] arm64: dts: qcom: sm8250-asus-obiwan: " Alexander Koskovich
  0 siblings, 2 replies; 9+ messages in thread
From: Alexander Koskovich @ 2026-03-11  2:43 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kees Cook, Tony Luck, Guilherme G. Piccoli
  Cc: linux-arm-msm, devicetree, linux-kernel, Alexander Koskovich,
	Krzysztof Kozlowski

Add the bindings & devicetree for the ASUS ROG Phone 3, this is a smartphone
based on SM8250.

This submission depends on some other changes that are currently in review:

Tianma TA066VVHM03 panel driver [1]
Support for dsc_slice_per_pkt [2]
Support for V4L2 device tree properties on OV8856 [3]

Additionally, full USB functionality on the side port (usb_1) depends on a
vbus-detect-gpios property for qcom,pmic-typec. This device has two USB-C ports
that share the same USBIN input, which interferes with the existing driver's
VBUS based CC detection. Will submit an RFC for that change shortly.

The end impact of this is that if you are plugged into a PC or charger on the
bottom USB (usb_2), you cannot use the side USB (usb_1) for USB flash drives,
etc.

I have left the GT9896 DTS out of this initial submission since the driver is
still in review [4] but I have validated that the touchscreen works with that
driver added and DTS updated so can update once that is merged.

[1]: https://lore.kernel.org/dri-devel/20260308-tianma-ta066vvhm03-v1-0-869fac443b20@pm.me
[2]: https://lore.kernel.org/linux-arm-msm/20251001135914.13754-3-caojunjie650@gmail.com
[3]: https://lore.kernel.org/linux-media/20260307-ov8856-v4l2-props-v1-0-7677b4c658e4@pm.me
[4]: https://lore.kernel.org/linux-input/20260228-gtx8-v2-0-3a408c365f6c@mainlining.org

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
Changes in v3:
- property-n/property-names order fixed
- Moved cpu7_opp21 to sm8250.dtsi
- Added newlines to ports to seperate subnode from properties
- Added additional supported boards to qcom,board-id
- Validated debug UART functionality and added pinctrl & comment
- Added a default state for the USB2 mux between pogo port and bottom port
- Link to v2: https://lore.kernel.org/r/20260309-sm8250-asus-obiwan-v2-0-edf7d07b32af@pm.me

Changes in v2:
- Fixed From/SoB mismatch
- Changed qcom,board-id to 50, this is MP, mine is PR so it was 40.
- Dropped reserved_memory patch for Dmitry's suggestion
- Grouped root node children alphabetically
- Adopt preferred regulator naming
- Add gpu_zap_shader label in sm8250.dtsi to use in sm8250-asus-obiwan
- Dropped default dr_mode=otg
- Dropped side_ovp_acok_default from pinctrl (left in by mistake, for qcom,typec rfc)
- Clarified comment on usb_2 around USB 3 presence on board
- Moved endpoint connection for dp to sm8250.dtsi
- Moved usb-role-switch to sm8250.dtsi
- Updated bindings commit message to satisfy checkpatch.pl (also ran strict)
- Updated cover letter to fix typos
- Link to v1: https://lore.kernel.org/r/20260308-sm8250-asus-obiwan-v1-0-3c72941eb796@pm.me

---
Alexander Koskovich (2):
      dt-bindings: arm: qcom: Add ASUS ROG Phone 3
      arm64: dts: qcom: sm8250-asus-obiwan: Add ASUS ROG Phone 3

 Documentation/devicetree/bindings/arm/qcom.yaml |    1 +
 arch/arm64/boot/dts/qcom/Makefile               |    1 +
 arch/arm64/boot/dts/qcom/sm8250-asus-obiwan.dts | 1319 +++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sm8250.dtsi            |   13 +-
 4 files changed, 1333 insertions(+), 1 deletion(-)
---
base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
change-id: 20260308-sm8250-asus-obiwan-1c1b63ce121c

Best regards,
-- 
Alexander Koskovich <akoskovich@pm.me>



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-03-23 14:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-11  2:43 [PATCH v3 0/2] Add support for the ASUS ROG Phone 3 (SM8250) Alexander Koskovich
2026-03-11  2:43 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add ASUS ROG Phone 3 Alexander Koskovich
2026-03-11  2:43 ` [PATCH v3 2/2] arm64: dts: qcom: sm8250-asus-obiwan: " Alexander Koskovich
2026-03-18 10:28   ` Konrad Dybcio
2026-03-18 11:14     ` Alexander Koskovich
2026-03-18 11:29       ` Konrad Dybcio
2026-03-18 11:56         ` Alexander Koskovich
2026-03-23 14:10           ` Konrad Dybcio
2026-03-18 14:40         ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®