mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Balbir Singh <balbirs@nvidia.com>
To: Bert Karwatzki <spasswolf@web.de>
Cc: Ingo Molnar <mingo@kernel.org>, Kees Cook <kees@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: commit 7ffb791423c7 breaks steam game
Date: Wed, 12 Mar 2025 13:23:47 +1100	[thread overview]
Message-ID: <ddc0181a-7580-427b-b1e2-c3b1a3d48ff1@nvidia.com> (raw)
In-Reply-To: <cc1c59bba5b4e8b8afef14690f6c974e8bd814a3.camel@web.de>

On 3/12/25 11:26, Bert Karwatzki wrote:
> The combination
> 
> CONFIG_RANDOMIZE_BASE=y
> # CONFIG_RANDOMIZE_MEMORY is not set
> # CONFIG_PCI_P2PDMA is not set
> 
> also shows the laggy input when running stellaris
> 

Hmm.. my changes do not get compiled when
CONFIG_RANDOMIZE_MEMORY is not set

It sounds like there is an issue on the system which KASLR
was hiding by bringing the region to 0xafe0..

With this patch CONFIG_PCI_P2PDMA exposes the system to the
full direct map and that seems broken on your system.

Please see below

<snip>

> The diff to the other case
> CONFIG_RANDOMIZE_BASE=y
> CONFIG_RANDOMIZE_MEMORY=y
> # CONFIG_PCI_P2PDMA is not set
> is
> 
> # diff -u proc_iomme_6.14.0-rc6-norandmemnop2p.txt proc_iomme_6.14.0-rc6-
> nop2pdma.txt
> --- proc_iomme_6.14.0-rc6-norandmemnop2p.txt	2025-03-12 01:18:33.022790613
> +0100
> +++ proc_iomme_6.14.0-rc6-nop2pdma.txt	2025-03-12 01:19:36.000325778 +0100
> @@ -85,10 +85,10 @@
>  fee00000-fee00fff : pnp 00:04
>  ff000000-ffffffff : pnp 00:04
>  100000000-fee2fffff : System RAM
> -  3a7e00000-3a89d2f56 : Kernel code
> -  3a8a00000-3a8e31fff : Kernel rodata
> -  3a9000000-3a912a5ff : Kernel data
> -  3a969c000-3a97fffff : Kernel bss
> +  d32200000-d32dd0f56 : Kernel code
> +  d32e00000-d33231fff : Kernel rodata
> +  d33400000-d3352a5ff : Kernel data
> +  d33a9c000-d33bfffff : Kernel bss
>  fee300000-100fffffff : Reserved
>  1010000000-ffffffffff : PCI Bus 0000:00
>    fc00000000-fe0fffffff : PCI Bus 0000:01
> @@ -104,4 +104,4 @@
>        fe30300000-fe303fffff : 0000:04:00.0
>      fe30400000-fe30403fff : 0000:04:00.0
>      fe30404000-fe30404fff : 0000:04:00.0
> -3ffe00000000-3fffffffffff : 0000:03:00.0
> +afe00000000-affffffffff : 0000:03:00.0
> 

So this is the interesting bit 0000:03:00.0

I assume you'd see the card at 0x3ffe00000000 in the output when
CONFIG_RANDOMIZE_BASE = n

Basically the change is moving the BAR region from
0xafe0... to 0x3ffe0.. and the game does not seem to like that
change. It sounds like everything else is working fine?
Any chance you can try another game to see if there are
issues with just one game?

1. Can you please also share the full lscpu output?
  - I am particularly interested in the address bits (physical and virtual)
2. Can you please share the full dmesg in both cases?

Thanks,
Balbir

  reply	other threads:[~2025-03-12  2:23 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 11:22 Bert Karwatzki
2025-03-10 21:48 ` Balbir Singh
2025-03-11  7:19   ` Balbir Singh
2025-03-11  7:28     ` Ingo Molnar
2025-03-11 11:15     ` Bert Karwatzki
2025-03-11 18:24       ` Bert Karwatzki
2025-03-11 22:10         ` Balbir Singh
2025-03-11 23:09           ` Bert Karwatzki
2025-03-12  0:26             ` Bert Karwatzki
2025-03-12  2:23               ` Balbir Singh [this message]
2025-03-12  1:24             ` Balbir Singh
2025-03-13  9:22               ` Bert Karwatzki
2025-03-13 10:40                 ` Balbir Singh
2025-03-13 10:53                   ` Bert Karwatzki
2025-03-13 11:47                     ` Balbir Singh
2025-03-13 18:12                       ` Bert Karwatzki
2025-03-13 21:54                         ` Balbir Singh
2025-03-13 22:22                           ` Bert Karwatzki
2025-03-14  6:14                             ` Balbir Singh
2025-03-14 13:34                               ` Balbir Singh
2025-03-14 14:18                                 ` Bert Karwatzki
2025-03-15  0:16                                   ` Balbir Singh
2025-03-15 17:40                                     ` Alex Deucher
2025-03-16 13:09                                       ` Bert Karwatzki
2025-03-16 20:06                                         ` Bert Karwatzki
2025-03-17  9:13                                         ` Balbir Singh
2025-03-20  9:01                                           ` Ingo Molnar
2025-03-20 23:55                                             ` Balbir Singh
2025-03-21 10:24                                               ` Ingo Molnar
2025-03-21 11:05                                                 ` Balbir Singh
2025-03-22  8:04                                                   ` Ingo Molnar
2025-03-22  9:40                                                     ` Balbir Singh
2025-03-20 23:43                                           ` Bert Karwatzki
2025-03-21  4:55                                             ` Balbir Singh
2025-03-21 12:26                                               ` Bert Karwatzki
2025-03-22  2:06                                                 ` Balbir Singh
2025-03-22 12:23 Bert Karwatzki
2025-03-23  6:51 ` Balbir Singh
2025-03-24 11:23   ` Bert Karwatzki
2025-03-24 12:14     ` Christian König
2025-03-24 22:48       ` Balbir Singh
     [not found]         ` <938c2cbd-c47f-4925-ba82-94eef54d9ebc@amd.com>
2025-03-25 22:45           ` Balbir Singh
2025-03-25 23:21             ` Bert Karwatzki
2025-03-25 23:43               ` Balbir Singh
2025-03-26  1:50                 ` Balbir Singh
2025-03-26 10:10                   ` Bert Karwatzki
2025-03-26 10:36                     ` Balbir Singh
2025-03-26 11:14                       ` Bert Karwatzki
2025-03-27 10:53                       ` Ingo Molnar
2025-03-27 22:03                         ` Balbir Singh
2025-03-24 21:43     ` Balbir Singh
2025-03-24 23:07 Bert Karwatzki
     [not found] ` <634e77d7-4f3c-4d1a-8aa3-1978896f9bf2@amd.com>
2025-03-25 10:25   ` Balbir Singh
2025-03-25 10:14 Bert Karwatzki
2025-03-25 12:23 ` Christian König
2025-03-26 22:00   ` Bert Karwatzki
2025-03-26 22:58     ` Linus Torvalds
2025-03-27  0:57       ` Balbir Singh
2025-03-27  0:58       ` Bert Karwatzki
2025-03-27 10:40       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddc0181a-7580-427b-b1e2-c3b1a3d48ff1@nvidia.com \
    --to=balbirs@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=spasswolf@web.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®