Re: [PATCH v10 4/6] clk: qcom: Add NSS clock Controller driver for IPQ9574

[Manikanta Mylavarapu <quic_mmanikan@quicinc.com>]

On 2/21/2025 5:19 PM, Konrad Dybcio wrote:
> On 21.02.2025 11:14 AM, Manikanta Mylavarapu wrote:
>> From: Devi Priya <quic_devipriy@quicinc.com>
>>
>> Add Networking Sub System Clock Controller (NSSCC) driver for ipq9574 based
>> devices.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>> ---
> 
> [...]
> 
>> +static int nss_cc_ipq9574_probe(struct platform_device *pdev)
>> +{
>> +	struct regmap *regmap;
>> +	int ret;
>> +
>> +	ret = devm_pm_runtime_enable(&pdev->dev);
>> +	if (ret)
>> +		return ret;
>> +
>> +	ret = devm_pm_clk_create(&pdev->dev);
>> +	if (ret)
>> +		return ret;
>> +
>> +	ret = pm_clk_add(&pdev->dev, "nsscc");
>> +	if (ret)
>> +		return dev_err_probe(&pdev->dev, ret, "Fail to add AHB clock\n");
>> +
>> +	ret = pm_runtime_resume_and_get(&pdev->dev);
>> +	if (ret)
>> +		return ret;
> 
> if /\ suceeds
> 
>> +
>> +	regmap = qcom_cc_map(pdev, &nss_cc_ipq9574_desc);
>> +	if (IS_ERR(regmap))
>> +		return PTR_ERR(regmap);
> 
> you return here without pm_runtime_put, which doesn't decrease the refcount
> for core to put down the resource
> 
> if (IS_ERR(regmap)) {
> 	pm_runtime_put(&pdev->dev);
> 	return PTR_ERR(regmap);
> }
> 
> instead
> 

Hi Konrad,

Thank you for reviewing the patch.
I will incorporate your suggested change in the next version.

Thanks & Regards,
Manikanta.