From: Tim Chen <tim.c.chen@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Dave Hansen <dave.hansen@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Arjan Van De Ven <arjan.van.de.ven@intel.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Peter Zijlstra <peterz@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ashok Raj <ashok.raj@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS
Date: Thu, 11 Jan 2018 13:24:52 -0800 [thread overview]
Message-ID: <deb1ee64-443c-670a-d16f-b3c71b963934@linux.intel.com> (raw)
In-Reply-To: <90242f1d-216d-2213-4bb2-5450f4cb07be@linux.intel.com>
On 01/11/2018 01:05 PM, Tim Chen wrote:
> On 01/11/2018 08:04 AM, Thomas Gleixner wrote:
>> On Tue, 9 Jan 2018, Tim Chen wrote:
>>> +
>>> +.macro WRMSR_ASM msr_nr:req edx_val:req eax_val:req
>>> + movl \msr_nr, %ecx
>>> + movl \edx_val, %edx
>>> + movl \eax_val, %eax
>>> +.endm
>>
>> This is the most brilliant piece of useless code I've seen in a long time.
>>
>>
>> tglx
>>
>
> Sorry that was a major brain fart on my part.
>
Our internal tester mixed in retpoline with IBRS so we've missed
this. Will correct our test.
Tim
next prev parent reply other threads:[~2018-01-11 21:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 2:26 [PATCH v3 0/5] IBRS patch series Tim Chen
2018-01-10 2:26 ` [PATCH v3 1/5] x86/feature: Detect the x86 IBRS feature to control Speculation Tim Chen
2018-01-10 2:26 ` [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS Tim Chen
2018-01-11 16:04 ` Thomas Gleixner
2018-01-11 21:05 ` Tim Chen
2018-01-11 21:24 ` Tim Chen [this message]
2018-01-10 2:26 ` [PATCH v3 3/5] x86/enter: Use IBRS on syscall and interrupts Tim Chen
2018-01-10 10:04 ` Peter Zijlstra
2018-01-10 11:27 ` Paolo Bonzini
2018-01-10 18:16 ` Tim Chen
2018-01-10 18:28 ` Peter Zijlstra
2018-01-10 18:44 ` Tim Chen
2018-01-10 18:47 ` Van De Ven, Arjan
2018-01-11 12:45 ` Woodhouse, David
2018-01-10 2:26 ` [PATCH v3 4/5] x86/ibrs: Create boot option for IBRS Tim Chen
2018-01-10 2:26 ` [PATCH v3 5/5] x86/idle: Disable IBRS entering idle and enable it on wakeup Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb1ee64-443c-670a-d16f-b3c71b963934@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=ashok.raj@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome