From: Dave Hansen <dave.hansen@intel.com>
To: Amit Shah <amit@kernel.org>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
x86@kernel.org, linux-doc@vger.kernel.org
Cc: amit.shah@amd.com, thomas.lendacky@amd.com, bp@alien8.de,
tglx@linutronix.de, peterz@infradead.org, jpoimboe@kernel.org,
pawan.kumar.gupta@linux.intel.com, corbet@lwn.net,
mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
seanjc@google.com, pbonzini@redhat.com,
daniel.sneddon@linux.intel.com, kai.huang@intel.com,
sandipan.das@amd.com, boris.ostrovsky@oracle.com,
Babu.Moger@amd.com, david.kaplan@amd.com, dwmw@amazon.co.uk,
andrew.cooper3@citrix.com
Subject: Re: [RFC PATCH v2 1/3] x86: cpu/bugs: update SpectreRSB comments for AMD
Date: Mon, 11 Nov 2024 09:01:23 -0800 [thread overview]
Message-ID: <e414bc00-9216-4f09-b0b1-f45ea4b24e11@intel.com> (raw)
In-Reply-To: <20241111163913.36139-2-amit@kernel.org>
On 11/11/24 08:39, Amit Shah wrote:
> From: Amit Shah <amit.shah@amd.com>
>
> AMD CPUs do not fall back to the BTB when the RSB underflows for RET
> address speculation. AMD CPUs have not needed to stuff the RSB for
> underflow conditions.
>
> The RSB poisoning case is addressed by RSB filling - clean up the FIXME
> comment about it.
This amounts to "Josh was wrong" in commit 9756bba284. Before moving
forward with this, it would be great to get his ack on this to make sure
you two are on the same page.
next prev parent reply other threads:[~2024-11-11 17:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 16:39 [RFC PATCH v2 0/3] Add support for the ERAPS feature Amit Shah
2024-11-11 16:39 ` [RFC PATCH v2 1/3] x86: cpu/bugs: update SpectreRSB comments for AMD Amit Shah
2024-11-11 17:01 ` Dave Hansen [this message]
2024-11-11 19:33 ` Josh Poimboeuf
2024-11-11 19:58 ` Kaplan, David
2024-11-11 20:39 ` Josh Poimboeuf
2024-11-11 20:40 ` Josh Poimboeuf
2024-11-12 0:30 ` Josh Poimboeuf
2024-11-12 0:29 ` Andrew Cooper
2024-11-12 1:46 ` Josh Poimboeuf
2024-11-12 11:58 ` Borislav Petkov
2024-11-13 21:24 ` Josh Poimboeuf
2024-11-13 21:37 ` Borislav Petkov
2024-11-14 0:43 ` Josh Poimboeuf
2024-11-14 7:47 ` Borislav Petkov
2024-11-14 9:47 ` Ingo Molnar
2024-11-14 9:54 ` Borislav Petkov
2024-11-12 15:16 ` Shah, Amit
2024-11-12 21:43 ` Pawan Gupta
2024-11-13 20:21 ` Josh Poimboeuf
2024-11-14 1:55 ` Pawan Gupta
2024-11-14 2:31 ` Josh Poimboeuf
2024-11-14 8:01 ` Pawan Gupta
2024-11-15 5:48 ` Josh Poimboeuf
2024-11-15 14:44 ` Kaplan, David
2024-11-15 17:05 ` Josh Poimboeuf
2024-11-15 17:50 ` Pawan Gupta
2024-11-15 18:10 ` Josh Poimboeuf
2024-11-18 10:15 ` Shah, Amit
2024-11-11 16:39 ` [RFC PATCH v2 2/3] x86: cpu/bugs: add support for AMD ERAPS feature Amit Shah
2024-11-11 18:57 ` Dave Hansen
2024-11-13 10:33 ` Shah, Amit
2024-11-11 16:39 ` [RFC PATCH v2 3/3] x86: kvm: svm: add support for ERAPS and FLUSH_RAP_ON_VMRUN Amit Shah
2024-11-11 19:02 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e414bc00-9216-4f09-b0b1-f45ea4b24e11@intel.com \
--to=dave.hansen@intel.com \
--cc=Babu.Moger@amd.com \
--cc=amit.shah@amd.com \
--cc=amit@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david.kaplan@amd.com \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®