[PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[Krzysztof Kozlowski]

Static 'struct qcom_cc_desc' is not modified by drivers and can be made
const for code safety.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Drivers for SM8750 video cc had the same issue. It would be nice if new
code is being built on top of UPSTREAM code, not downstream.
---
 drivers/clk/qcom/videocc-glymur.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/videocc-glymur.c b/drivers/clk/qcom/videocc-glymur.c
index bb3aae6b8396..ea20605dd1e5 100644
--- a/drivers/clk/qcom/videocc-glymur.c
+++ b/drivers/clk/qcom/videocc-glymur.c
@@ -495,7 +495,7 @@ static struct qcom_cc_driver_data video_cc_glymur_driver_data = {
 	.clk_regs_configure = clk_glymur_regs_configure,
 };
 
-static struct qcom_cc_desc video_cc_glymur_desc = {
+static const struct qcom_cc_desc video_cc_glymur_desc = {
 	.config = &video_cc_glymur_regmap_config,
 	.clks = video_cc_glymur_clocks,
 	.num_clks = ARRAY_SIZE(video_cc_glymur_clocks),
-- 
2.51.0

Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[Konrad Dybcio]

On 3/31/26 10:55 AM, Krzysztof Kozlowski wrote:
> Static 'struct qcom_cc_desc' is not modified by drivers and can be made
> const for code safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

> Drivers for SM8750 video cc had the same issue. It would be nice if new
> code is being built on top of UPSTREAM code, not downstream.
> ---

You're free to contribute to the internal template that these drivers are
based on

Konrad

Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[Taniya Das]

On 3/31/2026 2:29 PM, Konrad Dybcio wrote:
>> Drivers for SM8750 video cc had the same issue. It would be nice if new
>> code is being built on top of UPSTREAM code, not downstream.
>> ---
> You're free to contribute to the internal template that these drivers are
> based on

The internal template for upstream code generation is fixed and glymur
still was using older template.

-- 
Thanks,
Taniya Das

Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[Krzysztof Kozlowski]

On 31/03/2026 10:59, Konrad Dybcio wrote:
> You're free to contribute to the internal template that these drivers are
> based on

That's a very reversed logic. I don't use "internal template" because it
is the wrong approach and I am always advocating against it. I am
advocating on basing your work on UPSTREAM work.

Additionally, it's internal, not open-source. I could work on many
internal things, but they don't matter, I don't want to touch them, I
don't care about them. Actually, I imply that no one in open source
community should particularly care about internal stuff.

So no, the users of broken internal stuff need to fix that broken stuff.
Job of the community is not to dwell into internal Qualcomm templates...

Best regards,
Krzysztof

Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[Taniya Das]

On 3/31/2026 2:25 PM, Krzysztof Kozlowski wrote:
> Static 'struct qcom_cc_desc' is not modified by drivers and can be made
> const for code safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Drivers for SM8750 video cc had the same issue. It would be nice if new
> code is being built on top of UPSTREAM code, not downstream.
> ---
>  drivers/clk/qcom/videocc-glymur.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/videocc-glymur.c b/drivers/clk/qcom/videocc-glymur.c
> index bb3aae6b8396..ea20605dd1e5 100644
> --- a/drivers/clk/qcom/videocc-glymur.c
> +++ b/drivers/clk/qcom/videocc-glymur.c
> @@ -495,7 +495,7 @@ static struct qcom_cc_driver_data video_cc_glymur_driver_data = {
>  	.clk_regs_configure = clk_glymur_regs_configure,
>  };
>  
> -static struct qcom_cc_desc video_cc_glymur_desc = {
> +static const struct qcom_cc_desc video_cc_glymur_desc = {
>  	.config = &video_cc_glymur_regmap_config,
>  	.clks = video_cc_glymur_clocks,
>  	.num_clks = ARRAY_SIZE(video_cc_glymur_clocks),

Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>

-- 
Thanks,
Taniya Das

Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[Bjorn Andersson]

On Tue, 31 Mar 2026 10:55:22 +0200, Krzysztof Kozlowski wrote:
> Static 'struct qcom_cc_desc' is not modified by drivers and can be made
> const for code safety.
> 
> 

Applied, thanks!

[1/1] clk: qcom: videocc-glymur: Constify qcom_cc_desc
      commit: 03aa6ed7069f4872333d410303ae8dd341bb096d

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>