mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: K Prateek Nayak <kprateek.nayak@amd.com>
To: John Stultz <jstultz@google.com>
Cc: Suleiman Souhlal <suleiman@google.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Will Deacon <will@kernel.org>, Boqun Feng <boqun@kernel.org>,
	Andrea Righi <arighi@nvidia.com>, <linux-kernel@vger.kernel.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	"Waiman Long" <longman@redhat.com>
Subject: Re: [RFC PATCH 00/16][PoC] sched/core: Alternate approach to sleeping-owner handling in PROXY_EXEC
Date: Thu, 17 Sep 2026 10:52:01 +0530	[thread overview]
Message-ID: <f0f597da-4700-4682-9361-b921aab7e462@amd.com> (raw)
In-Reply-To: <CANDhNCoVzHqS627Vv55E==VsJfnDMwvEnvYMxBt5Euu8PRUP3Q@mail.gmail.com>

Hello John,

On 9/16/2026 11:27 PM, John Stultz wrote:
> On Tue, Sep 15, 2026 at 10:22 PM John Stultz <jstultz@google.com> wrote:
>> The series definitely looks interesting, and it seems to be holding up
>> ok in testing.  Though figuring out how to refactor them so that they
> 
> Well, I did hit the following last night during stress testing:
> 
> [11176.672951] WARNING: kernel/sched/sched.h:1645 at
> sched_change_begin+0x1b6/0x2b0, CPU#14: torture_shuffle/433
> [11176.676650] CPU: 14 UID: 0 PID: 433 Comm: torture_shuffle Not
> tainted 7.2.0-rc4-00032-gf14e36dcc837-dirty #138 PREEMPT(full)
> [11176.680917] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS 1.17.0-debian-1.17.0-1 04/01/2014
> [11176.684794] RIP: 0010:sched_change_begin+0x1b6/0x2b0
> [11176.686748] Code: c9 1e 48 89 03 80 7b 1c 00 0f 85 ca 00 00 00 80
> 7b 1d 00 0f 85 91 00 00 00 48 89 d8 5b 5d 41 5c 41 5d 41 5e e9 1b 63
> 23 01 90 <0f> 0b 90 41 f6 c5 08 0f 85 c7 fe ff ff 48 89 ef 41 83 cd 08
> e8 b1
> [11176.693913] RSP: 0018:ffffc900010b3e10 EFLAGS: 00010046
> [11176.695962] RAX: 0000000000000000 RBX: ffff8881b9198020 RCX: 0000000000000001
> [11176.698747] RDX: 0000000000000001 RSI: ffffffff82c8b519 RDI: ffffffff82cad7fe
> [11176.701554] RBP: ffff8881b91abdc0 R08: 0000000000000001 R09: 00000000d19ffe29
> [11176.704561] R10: 000000000000000e R11: ffff88810264cff0 R12: ffff888106694400
> [11176.707423] R13: 0000000000000002 R14: 0000000000000000 R15: ffffc90000017d58
> [11176.710161] FS:  0000000000000000(0000) GS:ffff88823563e000(0000)
> knlGS:0000000000000000
> [11176.713196] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [11176.715628] CR2: 0000000000000000 CR3: 00000001072a7006 CR4: 0000000000370ef0
> [11176.718462] Call Trace:
> [11176.719460]  <TASK>
> [11176.720319]  __set_cpus_allowed_ptr_locked+0x146/0x1f0
> [11176.722343]  ? __pfx_torture_shuffle+0x10/0x10
> [11176.724063]  __set_cpus_allowed_ptr+0x64/0xa0
> [11176.725913]  set_cpus_allowed_ptr+0x3a/0x60
> [11176.727513]  torture_shuffle+0x12b/0x230
> [11176.729014]  kthread+0x103/0x130
> [11176.730304]  ? __pfx_kthread+0x10/0x10
> [11176.731758]  ret_from_fork+0x27c/0x340
> [11176.733220]  ? __pfx_kthread+0x10/0x10
> [11176.734680]  ret_from_fork_asm+0x1a/0x30
> [11176.736366]  </TASK>
> 
> Followed shortly after by:
> [11663.223681] kernel BUG at kernel/sched/rt.c:1020!
> [11663.226093] Oops: invalid opcode: 0000 [#1] SMP NOPTI
> [11663.228669] CPU: 46 UID: 0 PID: 0 Comm: swapper/46 Tainted: G
>  W           7.2.0-rc4-00032-gf14e36dcc837-dirty #138 PREEMPT(full)
> [11663.234796] Tainted: [W]=WARN
> [11663.236392] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS 1.17.0-debian-1.17.0-1 04/01/2014
> [11663.241196] RIP: 0010:dequeue_rt_stack+0x2ad/0x2c0
> [11663.243652] Code: 83 a8 fe ff ff 39 c1 0f 8e 47 ff ff ff 90 0f 0b
> 90 e9 b7 fd ff ff 90 0f 0b 90 e9 e8 fd ff ff f3 48 0f bc d0 e9 80 fe
> ff ff 90 <0f> 0b 48 8d 3d 1a 79 dc 01 67 48 0f b9 3a e9 e9 fe ff ff 90
> 90 90
> [11663.253981] RSP: 0018:ffffc90000c10dd8 EFLAGS: 00010046
> [11663.256630] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff88810ad50080
> [11663.260225] RDX: ffff888235e3e000 RSI: 0000000000000000 RDI: ffff88810ad501c0
> [11663.263862] RBP: ffff8881b99abdc0 R08: 0000000000000000 R09: ffffffff83b9a280
> [11663.266876] R10: 000000000000002e R11: 0000000000000000 R12: ffff8881b99abdc0
> [11663.269626] R13: ffff88810ad501c0 R14: 0000000000000000 R15: 0000000000000025
> [11663.272412] FS:  0000000000000000(0000) GS:ffff888235e3e000(0000)
> knlGS:0000000000000000
> [11663.276347] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [11663.279185] CR2: 00007f03955d60ac CR3: 00000001072a7006 CR4: 0000000000370ef0
> [11663.282698] Call Trace:
> [11663.284061]  <IRQ>
> [11663.285116]  enqueue_task_rt+0x77/0x3f0
> [11663.287276]  enqueue_task+0x1cf/0x330
> [11663.289121]  proxy_activate_blocked_task+0x498/0x640
> [11663.291579]  ttwu_do_activate+0x287/0x290
> [11663.293582]  sched_ttwu_pending+0x10b/0x220
> [11663.295726]  __flush_smp_call_function_queue+0x1f8/0x680
> [11663.298320]  __sysvec_call_function_single+0x35/0x180
> [11663.300877]  sysvec_call_function_single+0x8a/0xb0
> [11663.303287]  </IRQ>
> [11663.304376]  <TASK>
> [11663.305467]  asm_sysvec_call_function_single+0x1a/0x20
> [11663.307994] RIP: 0010:pv_native_safe_halt+0xf/0x20
> 
> 
> The only change I made to your tree was passing the rf into
> proxy_activate_blocked_task, to use rq_(un)lock() instead of
> raw_spin_rq_(un)lock().

Thank you for testing and the report! Let me go find what I've
broken.

-- 
Thanks and Regards,
Prateek


      reply	other threads:[~2026-09-17  5:22 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26  6:28 K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 01/16] sched/core: Break activation of blocked task into a separate helper K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 02/16] sched/core: Use enqueue/dequeue flags instead of task_on_rq_migrating() K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 03/16] sched/fair: Use enqueue flags for DO_ATTACH in update_load_avg() K Prateek Nayak
2026-08-26 15:36   ` Andrea Righi
2026-08-26  6:28 ` [RFC PATCH 04/16] sched/core: Activate blocked donor when no owner is found K Prateek Nayak
2026-08-26 15:56   ` Andrea Righi
2026-08-26 17:20     ` K Prateek Nayak
2026-08-28  6:04       ` K Prateek Nayak
2026-08-31 15:07         ` Andrea Righi
2026-09-16  4:16           ` K Prateek Nayak
2026-09-16  3:29   ` John Stultz
2026-09-16  4:16     ` K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 05/16] sched/core: Do not queue blocked donor on a delayed owner K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 06/16] sched/core: Queue blocked donor onto sleeping owner for chain-wakeup K Prateek Nayak
2026-08-26 16:20   ` Andrea Righi
2026-08-27  3:51     ` K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 07/16] sched/core: Avoid delaying blocked donors queued on sleeping owner K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 08/16] sched/deadline: Prepare for blocking and proxy activation with MIGRATING flag K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 09/16] sched/core: Track CPU where the task was blocked on K Prateek Nayak
2026-09-16  5:52   ` John Stultz
2026-09-16  6:29     ` K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 10/16] sched/core: Introduce p->is_linked to track if task is queued on sleeping owner K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 11/16] sched/core: Prepare to inspect ->is_linked alongside ->on_rq during wakeup K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 12/16] sched:core: Add MIGRATING flags when blocking and activating linked donors K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 13/16] sched/core: Use p->is_linked state to unlink from sleeping owner early K Prateek Nayak
2026-08-26  6:28 ` [RFC PATCH 14/16] sched/core: Introduce chain-wakeup to activate blocked donors K Prateek Nayak
2026-09-15  5:48   ` John Stultz
2026-08-26  6:28 ` [RFC PATCH 15/16] locking/mutex: Track locks owned by a task in a per-task counter K Prateek Nayak
2026-08-26  6:29 ` [RFC PATCH 16/16] sched/core: Set activation of non lock-holders to fast-path K Prateek Nayak
2026-09-16  5:22 ` [RFC PATCH 00/16][PoC] sched/core: Alternate approach to sleeping-owner handling in PROXY_EXEC John Stultz
2026-09-16  6:10   ` K Prateek Nayak
2026-09-16  6:23     ` John Stultz
2026-09-16  6:59       ` K Prateek Nayak
2026-09-16 17:57   ` John Stultz
2026-09-17  5:22     ` K Prateek Nayak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0f597da-4700-4682-9361-b921aab7e462@amd.com \
    --to=kprateek.nayak@amd.com \
    --cc=arighi@nvidia.com \
    --cc=boqun@kernel.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=suleiman@google.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®