mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	kernel-hardening@lists.openwall.com, adurbin@google.com,
	Eric Northup <digitaleric@google.com>,
	jln@google.com, wad@google.com,
	Mathias Krause <minipli@googlemail.com>,
	Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v6 0/7] Kernel base address randomization
Date: Tue, 01 Oct 2013 22:11:37 -0700	[thread overview]
Message-ID: <fcdac020-6b9a-4d36-b424-290597669cb0@email.android.com> (raw)
In-Reply-To: <20131002050714.GA27982@gmail.com>

I think that the randomization offset would be necessary in order to identify pointers.

Ingo Molnar <mingo@kernel.org> wrote:
>
>* Kees Cook <keescook@chromium.org> wrote:
>
>> Here is the latest version of the kASLR series. It has much improved 
>> e820 walking code, and expands the window available on 64-bit.
>> 
>> This is rolled out on Chrome OS devices, and working well.
>
>There's one kernel debuggability detail that should be discussed I
>think: 
>should symbolic printouts (in oops messages but also in /proc/kallsyms)
>
>and instrumentation interfaces that expose kernel addresses attempt to 
>de-randomize the addresses, stack contents and register values that lie
>
>within the random range?
>
>- it would be easier to use those addresses and look them up in a
>vmlinux
>   or in a System.map as well.
>
> - it would be somewhat safer to post an oops publicly if it did not
>   contain the random offset in an easily identifiable way.
>
>- oops patterns from distribution kernels that enable randomization
>would 
>   match up better.
>
> - this would make it safer to expose /proc/kallsyms to user-space
>   profiling, while keeping the random offset a kernel-internal secret.
>
> - RIP information in profiling streams would thus not contain the
>   kernel random offset either.
>
>The other approach would be what your series does, to keep all the raw,
>
>randomized output and to assume that users who are allowed to access to
>
>logs or profiling can learn the random offset.
>
>I tend to lean towards the 'raw' approach that you picked, but an
>argument 
>can be made for both approaches - and in any case I haven't seen this 
>discussed to conclusion with cons/pros listed and a consensus/decision 
>reached.
>
>Thanks,
>
>	Ingo

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.

  reply	other threads:[~2013-10-02  5:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01 19:37 Kees Cook
2013-10-01 19:37 ` [PATCH 1/7] x86, kaslr: move CPU flags out of cpucheck Kees Cook
2013-10-01 20:48   ` H. Peter Anvin
2013-10-01 21:09     ` Kees Cook
2013-10-01 19:37 ` [PATCH 2/7] x86, kaslr: return location from decompress_kernel Kees Cook
2013-10-01 19:37 ` [PATCH 3/7] x86, kaslr: find minimum safe relocation position Kees Cook
2013-10-01 19:37 ` [PATCH 4/7] x86, kaslr: select random base offset Kees Cook
2013-10-01 20:46   ` H. Peter Anvin
2013-10-01 21:18     ` Kees Cook
2013-10-01 19:37 ` [PATCH 5/7] x86, kaslr: select memory region from e820 maps Kees Cook
2013-10-01 19:37 ` [PATCH 6/7] x86, kaslr: report kernel offset on panic Kees Cook
2013-10-02  0:38   ` HATAYAMA Daisuke
2013-10-02  1:06     ` HATAYAMA Daisuke
2013-10-02  7:51       ` Kees Cook
2013-10-02  7:48     ` Kees Cook
2013-10-02  9:13       ` HATAYAMA Daisuke
2013-10-03  0:33         ` HATAYAMA Daisuke
2013-10-03 13:47           ` Dave Anderson
2013-10-07  1:59             ` HATAYAMA Daisuke
2013-10-07 13:21               ` Dave Anderson
2013-10-08  9:52                 ` HATAYAMA Daisuke
2013-10-08 13:38                   ` Dave Anderson
2013-10-09 10:04                     ` HATAYAMA Daisuke
2013-10-09 14:13                       ` H. Peter Anvin
2013-10-09 18:06                       ` Kees Cook
2013-10-01 19:37 ` [PATCH 7/7] x86, kaslr: raise max positions to 1GiB on x86_64 Kees Cook
2013-10-02  5:07 ` [PATCH v6 0/7] Kernel base address randomization Ingo Molnar
2013-10-02  5:11   ` H. Peter Anvin [this message]
2013-10-02  5:25     ` Ingo Molnar
2013-10-02  5:30       ` H. Peter Anvin
2013-10-02  5:36         ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcdac020-6b9a-4d36-b424-290597669cb0@email.android.com \
    --to=hpa@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=adurbin@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=digitaleric@google.com \
    --cc=jln@google.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=minipli@googlemail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wad@google.com \
    --cc=x86@kernel.org \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome