[PATCH RFT] mailbox: exynos: drop superfluous mbox setting per channel

[PATCH RFT] mailbox: exynos: drop superfluous mbox setting per channel

[Wolfram Sang]

The core initializes the 'mbox' field exactly like this, so don't
duplicate it in the driver.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Only build-tested. Found because I made the same mistake in my
to-be-upstreamed driver and then looked for that pattern. Testing would
be still much appreciated!

 drivers/mailbox/exynos-mailbox.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mailbox.c
index 5f2d3b81c1db..d2355b128ba4 100644
--- a/drivers/mailbox/exynos-mailbox.c
+++ b/drivers/mailbox/exynos-mailbox.c
@@ -99,7 +99,6 @@ static int exynos_mbox_probe(struct platform_device *pdev)
 	struct mbox_controller *mbox;
 	struct mbox_chan *chans;
 	struct clk *pclk;
-	int i;
 
 	exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL);
 	if (!exynos_mbox)
@@ -129,9 +128,6 @@ static int exynos_mbox_probe(struct platform_device *pdev)
 	mbox->ops = &exynos_mbox_chan_ops;
 	mbox->of_xlate = exynos_mbox_of_xlate;
 
-	for (i = 0; i < EXYNOS_MBOX_CHAN_COUNT; i++)
-		chans[i].mbox = mbox;
-
 	exynos_mbox->mbox = mbox;
 
 	platform_set_drvdata(pdev, exynos_mbox);
-- 
2.47.3

Re: [PATCH RFT] mailbox: exynos: drop superfluous mbox setting per channel

[Tudor Ambarus]

On 3/9/26 9:39 AM, Wolfram Sang wrote:
> The core initializes the 'mbox' field exactly like this, so don't
> duplicate it in the driver.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Tested-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> 
> Only build-tested. Found because I made the same mistake in my
> to-be-upstreamed driver and then looked for that pattern. Testing would
> be still much appreciated!
> 
>  drivers/mailbox/exynos-mailbox.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mailbox.c
> index 5f2d3b81c1db..d2355b128ba4 100644
> --- a/drivers/mailbox/exynos-mailbox.c
> +++ b/drivers/mailbox/exynos-mailbox.c
> @@ -99,7 +99,6 @@ static int exynos_mbox_probe(struct platform_device *pdev)
>  	struct mbox_controller *mbox;
>  	struct mbox_chan *chans;
>  	struct clk *pclk;
> -	int i;
>  
>  	exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL);
>  	if (!exynos_mbox)
> @@ -129,9 +128,6 @@ static int exynos_mbox_probe(struct platform_device *pdev)
>  	mbox->ops = &exynos_mbox_chan_ops;
>  	mbox->of_xlate = exynos_mbox_of_xlate;
>  
> -	for (i = 0; i < EXYNOS_MBOX_CHAN_COUNT; i++)
> -		chans[i].mbox = mbox;
> -
>  	exynos_mbox->mbox = mbox;
>  
>  	platform_set_drvdata(pdev, exynos_mbox);