[PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Lucas Tanure]

Add support for Steam Deck bios old properties. If a Steam deck didn't
upgrade the BIOS, the driver should be able to handle the previous
properties for shared boost types.

Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
Changes since V3:
 - Fixed missing space in if statement
 - Fix the build issue, as dependency patches are already merged

Changes since V2:
 - sent the wrong patch with missing fixed lines
Changes since V1:
 - else in same line as {
---
 sound/soc/codecs/cs35l41.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
index 1624510d09c0..2803ff0f0003 100644
--- a/sound/soc/codecs/cs35l41.c
+++ b/sound/soc/codecs/cs35l41.c
@@ -1022,9 +1022,15 @@ static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_hw_cfg *hw_cf
 	unsigned int val;
 	int ret;
 
-	ret = device_property_read_u32(dev, "cirrus,boost-type", &val);
-	if (ret >= 0)
-		hw_cfg->bst_type = val;
+	if (device_property_read_bool(dev, "cirrus,shared-boost-active")) {
+		hw_cfg->bst_type = CS35L41_SHD_BOOST_ACTV;
+	} else if (device_property_read_bool(dev, "cirrus,shared-boost-passive")) {
+		hw_cfg->bst_type = CS35L41_SHD_BOOST_PASS;
+	} else {
+		ret = device_property_read_u32(dev, "cirrus,boost-type", &val);
+		if (ret >= 0)
+			hw_cfg->bst_type = val;
+	}
 
 	ret = device_property_read_u32(dev, "cirrus,boost-peak-milliamp", &val);
 	if (ret >= 0)
-- 
2.39.2

Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Krzysztof Kozlowski]

On 09/03/2023 11:41, Lucas Tanure wrote:
> Add support for Steam Deck bios old properties. If a Steam deck didn't
> upgrade the BIOS, the driver should be able to handle the previous
> properties for shared boost types.
> 
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> Changes since V3:
>  - Fixed missing space in if statement
>  - Fix the build issue, as dependency patches are already merged
> 
> Changes since V2:
>  - sent the wrong patch with missing fixed lines
> Changes since V1:
>  - else in same line as {
> ---
>  sound/soc/codecs/cs35l41.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
> index 1624510d09c0..2803ff0f0003 100644
> --- a/sound/soc/codecs/cs35l41.c
> +++ b/sound/soc/codecs/cs35l41.c
> @@ -1022,9 +1022,15 @@ static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_hw_cfg *hw_cf
>  	unsigned int val;
>  	int ret;
>  
> -	ret = device_property_read_u32(dev, "cirrus,boost-type", &val);
> -	if (ret >= 0)
> -		hw_cfg->bst_type = val;
> +	if (device_property_read_bool(dev, "cirrus,shared-boost-active")) {

You are now changing ABI and adding undocumented properties.

NAK.

Best regards,
Krzysztof

Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:

> You are now changing ABI and adding undocumented properties.

This is newly added code, changes are fine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Krzysztof Kozlowski]

On 09/03/2023 12:04, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
> 
>> You are now changing ABI and adding undocumented properties.
> 
> This is newly added code, changes are fine.

OK, for the ABI code, but not for the undocumented properties. Commit
does not explain that.

Best regards,
Krzysztof

Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Thu, Mar 09, 2023 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
> On 09/03/2023 12:04, Mark Brown wrote:
> > On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:

> >> You are now changing ABI and adding undocumented properties.

> > This is newly added code, changes are fine.

> OK, for the ABI code, but not for the undocumented properties. Commit
> does not explain that.

It does, it says that it's adding support for the properties used in the
firmware on existing Steam Decks.  Those aren't even DT systems.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Krzysztof Kozlowski]

On 09/03/2023 12:19, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
>> On 09/03/2023 12:04, Mark Brown wrote:
>>> On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
> 
>>>> You are now changing ABI and adding undocumented properties.
> 
>>> This is newly added code, changes are fine.
> 
>> OK, for the ABI code, but not for the undocumented properties. Commit
>> does not explain that.
> 
> It does, it says that it's adding support for the properties used in the
> firmware on existing Steam Decks.  Those aren't even DT systems.

For some reason DT is cced...

The code unfortunately will allow to put them into DT and next time
people will use it as an argument to document in the binding ("because
driver already has them"). I heard this argument already many times.

Document then that these are not DT properties.

Best regards,
Krzysztof

Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
> On 09/03/2023 11:41, Lucas Tanure wrote:

> > -	ret = device_property_read_u32(dev, "cirrus,boost-type", &val);
> > -	if (ret >= 0)
> > -		hw_cfg->bst_type = val;
> > +	if (device_property_read_bool(dev, "cirrus,shared-boost-active")) {

> You are now changing ABI and adding undocumented properties.

Note also that this doesn't change the existing property, it continues
to work identically.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Mark Brown]

On Thu, 09 Mar 2023 10:41:33 +0000, Lucas Tanure wrote:
> Add support for Steam Deck bios old properties. If a Steam deck didn't
> upgrade the BIOS, the driver should be able to handle the previous
> properties for shared boost types.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l41: Steam Deck Shared boost properties quirk
      commit: 8987986b07f5dded3f81b159f5bb146f2d1a21ed

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark