* [PATCH] ALSA: line6: fix ifnullfree.cocci warnings
[not found] <201609200807.amTCnbAm%fengguang.wu@intel.com>
@ 2016-09-20 0:10 ` kbuild test robot
2016-09-20 10:54 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2016-09-20 0:10 UTC (permalink / raw)
To: Andrej Krutak
Cc: kbuild-all, alsa-devel, Takashi Iwai, Jaroslav Kysela, linux-kernel
sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Andrej Krutak <dev@andree.sk>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/sound/usb/line6/driver.c
+++ b/sound/usb/line6/driver.c
@@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca
/* Free buffer memory first. We cannot depend on the existence of private
* data from the (podhd) module, it may be gone already during this call
*/
- if (line6->buffer_message)
- kfree(line6->buffer_message);
+ kfree(line6->buffer_message);
kfree(line6->buffer_listen);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings
2016-09-20 0:10 ` [PATCH] ALSA: line6: fix ifnullfree.cocci warnings kbuild test robot
@ 2016-09-20 10:54 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-09-20 10:54 UTC (permalink / raw)
To: kbuild test robot
Cc: Andrej Krutak, kbuild-all, alsa-devel, Jaroslav Kysela, linux-kernel
On Tue, 20 Sep 2016 02:10:13 +0200,
kbuild test robot wrote:
>
> sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
> NULL check before some freeing functions is not needed.
>
> Based on checkpatch warning
> "kfree(NULL) is safe this check is probably not required"
> and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> CC: Andrej Krutak <dev@andree.sk>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Applied, thanks.
Takashi
> ---
>
> driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca
> /* Free buffer memory first. We cannot depend on the existence of private
> * data from the (podhd) module, it may be gone already during this call
> */
> - if (line6->buffer_message)
> - kfree(line6->buffer_message);
> + kfree(line6->buffer_message);
>
> kfree(line6->buffer_listen);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-20 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201609200807.amTCnbAm%fengguang.wu@intel.com>
2016-09-20 0:10 ` [PATCH] ALSA: line6: fix ifnullfree.cocci warnings kbuild test robot
2016-09-20 10:54 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®