* [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops, Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops [not found] <20180921054514.GA11771@nick> @ 2018-09-21 6:51 ` Takashi Iwai 2018-09-21 9:21 ` Nick Simonov 0 siblings, 1 reply; 3+ messages in thread From: Takashi Iwai @ 2018-09-21 6:51 UTC (permalink / raw) To: Nick Simonov; +Cc: oleksandr_andrushchenko, alsa-devel, xen-devel, linux-kernel On Fri, 21 Sep 2018 07:47:38 +0200, Nick Simonov wrote: > > snd_pcm_ops are not supposed to change. So mark the > non-const structs as const. Also, refine indentation > to increase readability. > > Signed-off-by: Nick Simonov <nicksimonovv@gmail.com> > --- > Changes v2: > - Fix typo in commit description, ncrease to increase. Since I already merged your first version, please resubmit as an incremental patch. At best, check the latest linux-next or my sound.git tree for-next branch, and create a patch on its top. thanks, Takashi ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops 2018-09-21 6:51 ` [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops, Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops Takashi Iwai @ 2018-09-21 9:21 ` Nick Simonov 2018-09-21 9:23 ` Takashi Iwai 0 siblings, 1 reply; 3+ messages in thread From: Nick Simonov @ 2018-09-21 9:21 UTC (permalink / raw) To: Takashi Iwai; +Cc: oleksandr_andrushchenko, alsa-devel, xen-devel, linux-kernel On Fri, Sep 21, 2018 at 08:51:51AM +0200, Takashi Iwai wrote: > On Fri, 21 Sep 2018 07:47:38 +0200, > Nick Simonov wrote: > > > > snd_pcm_ops are not supposed to change. So mark the > > non-const structs as const. Also, refine indentation > > to increase readability. > > > > Signed-off-by: Nick Simonov <nicksimonovv@gmail.com> > > --- > > Changes v2: > > - Fix typo in commit description, ncrease to increase. > > Since I already merged your first version, please resubmit as an > incremental patch. At best, check the latest linux-next or my > sound.git tree for-next branch, and create a patch on its top. > > > thanks, > > Takashi Sorry I want to clarify, there is no mistakes in the code itself there is a typo in commit message. As I now there is no way to change commit message without rebase after merge, so which is the proper way in this case? leave it as is? Thanks, Nick ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops 2018-09-21 9:21 ` Nick Simonov @ 2018-09-21 9:23 ` Takashi Iwai 0 siblings, 0 replies; 3+ messages in thread From: Takashi Iwai @ 2018-09-21 9:23 UTC (permalink / raw) To: Nick Simonov; +Cc: oleksandr_andrushchenko, alsa-devel, xen-devel, linux-kernel On Fri, 21 Sep 2018 11:21:35 +0200, Nick Simonov wrote: > > On Fri, Sep 21, 2018 at 08:51:51AM +0200, Takashi Iwai wrote: > > On Fri, 21 Sep 2018 07:47:38 +0200, > > Nick Simonov wrote: > > > > > > snd_pcm_ops are not supposed to change. So mark the > > > non-const structs as const. Also, refine indentation > > > to increase readability. > > > > > > Signed-off-by: Nick Simonov <nicksimonovv@gmail.com> > > > --- > > > Changes v2: > > > - Fix typo in commit description, ncrease to increase. > > > > Since I already merged your first version, please resubmit as an > > incremental patch. At best, check the latest linux-next or my > > sound.git tree for-next branch, and create a patch on its top. > > > > > > thanks, > > > > Takashi > > Sorry I want to clarify, there is no mistakes in the code itself > there is a typo in commit message. As I now there is no way to change > commit message without rebase after merge, so which is the proper way in > this case? leave it as is? Then let's leave as is. thanks, Takashi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-21 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180921054514.GA11771@nick>
2018-09-21 6:51 ` [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops, Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops Takashi Iwai
2018-09-21 9:21 ` Nick Simonov
2018-09-21 9:23 ` Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®