[PATCH] Sound: Core: fixed assignment in if condition style error in hwdep.c

[PATCH] Sound: Core: fixed assignment in if condition style error in hwdep.c

[Vincent Heuken]

This is a patch to the hwdep.c file that fixes one instance of
the following error:
ERROR: do not use assignment in if condition

It also, incidentally, fixes one instance of the following warning:
WARNING: line over 80 characters

Signed-off-by: Vincent Heuken <me@vincentheuken.com>
---
 sound/core/hwdep.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index 69459e5..42d8324 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -527,7 +527,9 @@ static void __init snd_hwdep_proc_init(void)
 {
 	struct snd_info_entry *entry;
 
-	if ((entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL)) != NULL) {
+	entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL);
+
+	if (entry != NULL) {
 		entry->c.text.read = snd_hwdep_proc_read;
 		if (snd_info_register(entry) < 0) {
 			snd_info_free_entry(entry);
-- 
2.0.0

Re: [PATCH] Sound: Core: fixed assignment in if condition style error in hwdep.c

[Takashi Iwai]

At Fri, 20 Jun 2014 08:50:35 -0700,
Vincent Heuken wrote:
> 
> This is a patch to the hwdep.c file that fixes one instance of
> the following error:
> ERROR: do not use assignment in if condition
> 
> It also, incidentally, fixes one instance of the following warning:
> WARNING: line over 80 characters
> 
> Signed-off-by: Vincent Heuken <me@vincentheuken.com>

If this is a preliminary work for any real fix, I'd happily apply this
patch.  But, if it's only about a coding style fix, I won't buy it
alone.  Let me know if it's the former case.


thanks,

Takashi

> ---
>  sound/core/hwdep.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
> index 69459e5..42d8324 100644
> --- a/sound/core/hwdep.c
> +++ b/sound/core/hwdep.c
> @@ -527,7 +527,9 @@ static void __init snd_hwdep_proc_init(void)
>  {
>  	struct snd_info_entry *entry;
>  
> -	if ((entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL)) != NULL) {
> +	entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL);
> +
> +	if (entry != NULL) {
>  		entry->c.text.read = snd_hwdep_proc_read;
>  		if (snd_info_register(entry) < 0) {
>  			snd_info_free_entry(entry);
> -- 
> 2.0.0
>