* [PATCH] Enable Realtek ALC269 codec input layer beep
@ 2011-05-19 14:32 Madis Janson
2011-05-19 16:18 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Madis Janson @ 2011-05-19 14:32 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
This fixes the input layer beep not working on some EeePC 1000 models by
adding the subsystem id into whitelist. Otherwise the corresponding ALSA
mixer is not enabled and stays muted, resulting in no console beep.
diff -u linux-2.6.39/sound/pci/hda/patch_realtek.c lohe-2.6.39/sound/pci/hda/patch_realtek.c
--- linux-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 07:06:34.000000000 +0300
+++ lohe-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 11:58:28.415669828 +0300
@@ -5646,6 +5646,7 @@
SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1),
SND_PCI_QUIRK(0x1043, 0x83ce, "EeePC", 1),
SND_PCI_QUIRK(0x1043, 0x831a, "EeePC", 1),
+ SND_PCI_QUIRK(0x1043, 0x834a, "EeePC", 1),
SND_PCI_QUIRK(0x8086, 0xd613, "Intel", 1),
{}
};
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Enable Realtek ALC269 codec input layer beep
2011-05-19 14:32 [PATCH] Enable Realtek ALC269 codec input layer beep Madis Janson
@ 2011-05-19 16:18 ` Takashi Iwai
2011-05-19 16:31 ` Madis Janson
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2011-05-19 16:18 UTC (permalink / raw)
To: Madis Janson; +Cc: Linus Torvalds, linux-kernel
At Thu, 19 May 2011 17:32:19 +0300 (EEST),
Madis Janson wrote:
>
>
> This fixes the input layer beep not working on some EeePC 1000 models by
> adding the subsystem id into whitelist. Otherwise the corresponding ALSA
> mixer is not enabled and stays muted, resulting in no console beep.
The change look good, but could you give your sign-off?
See Documentation/SubmittingPatches section 12 "Sign your work" for
details.
Also, at the next time, please try to send the patch to the
corresponding subsystem maintainers. scripts/get_maintainer.pl is
your friend.
thanks,
Takashi
> diff -u linux-2.6.39/sound/pci/hda/patch_realtek.c lohe-2.6.39/sound/pci/hda/patch_realtek.c
> --- linux-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 07:06:34.000000000 +0300
> +++ lohe-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 11:58:28.415669828 +0300
> @@ -5646,6 +5646,7 @@
> SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1),
> SND_PCI_QUIRK(0x1043, 0x83ce, "EeePC", 1),
> SND_PCI_QUIRK(0x1043, 0x831a, "EeePC", 1),
> + SND_PCI_QUIRK(0x1043, 0x834a, "EeePC", 1),
> SND_PCI_QUIRK(0x8086, 0xd613, "Intel", 1),
> {}
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Enable Realtek ALC269 codec input layer beep
2011-05-19 16:18 ` Takashi Iwai
@ 2011-05-19 16:31 ` Madis Janson
2011-05-19 16:33 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Madis Janson @ 2011-05-19 16:31 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linus Torvalds, linux-kernel
On Thu, 19 May 2011, Takashi Iwai wrote:
> The change look good, but could you give your sign-off?
> See Documentation/SubmittingPatches section 12 "Sign your work" for
> details.
>
> Also, at the next time, please try to send the patch to the
> corresponding subsystem maintainers. scripts/get_maintainer.pl is
> your friend.
Ok. Would this sign-off suffice? :)
---
This fixes the input layer beep not working on some EeePC 1000 models by
adding the subsystem id into whitelist. Otherwise the corresponding ALSA
mixer is not enabled and stays muted, resulting in no console beep.
Signed-off-by: Madis Janson <madis@cyber.ee>
diff -u linux-2.6.39/sound/pci/hda/patch_realtek.c lohe-2.6.39/sound/pci/hda/patch_realtek.c
--- linux-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 07:06:34.000000000 +0300
+++ lohe-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 11:58:28.415669828 +0300
@@ -5646,6 +5646,7 @@
SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1),
SND_PCI_QUIRK(0x1043, 0x83ce, "EeePC", 1),
SND_PCI_QUIRK(0x1043, 0x831a, "EeePC", 1),
+ SND_PCI_QUIRK(0x1043, 0x834a, "EeePC", 1),
SND_PCI_QUIRK(0x8086, 0xd613, "Intel", 1),
{}
};
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Enable Realtek ALC269 codec input layer beep
2011-05-19 16:31 ` Madis Janson
@ 2011-05-19 16:33 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2011-05-19 16:33 UTC (permalink / raw)
To: Madis Janson; +Cc: Linus Torvalds, linux-kernel
At Thu, 19 May 2011 19:31:36 +0300 (EEST),
Madis Janson wrote:
>
>
> On Thu, 19 May 2011, Takashi Iwai wrote:
>
> > The change look good, but could you give your sign-off?
> > See Documentation/SubmittingPatches section 12 "Sign your work" for
> > details.
> >
> > Also, at the next time, please try to send the patch to the
> > corresponding subsystem maintainers. scripts/get_maintainer.pl is
> > your friend.
>
> Ok. Would this sign-off suffice? :)
Yep. Applied now. Thanks.
Takashi
> ---
>
> This fixes the input layer beep not working on some EeePC 1000 models by
> adding the subsystem id into whitelist. Otherwise the corresponding ALSA
> mixer is not enabled and stays muted, resulting in no console beep.
>
> Signed-off-by: Madis Janson <madis@cyber.ee>
>
> diff -u linux-2.6.39/sound/pci/hda/patch_realtek.c lohe-2.6.39/sound/pci/hda/patch_realtek.c
> --- linux-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 07:06:34.000000000 +0300
> +++ lohe-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 11:58:28.415669828 +0300
> @@ -5646,6 +5646,7 @@
> SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1),
> SND_PCI_QUIRK(0x1043, 0x83ce, "EeePC", 1),
> SND_PCI_QUIRK(0x1043, 0x831a, "EeePC", 1),
> + SND_PCI_QUIRK(0x1043, 0x834a, "EeePC", 1),
> SND_PCI_QUIRK(0x8086, 0xd613, "Intel", 1),
> {}
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-19 16:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 14:32 [PATCH] Enable Realtek ALC269 codec input layer beep Madis Janson
2011-05-19 16:18 ` Takashi Iwai
2011-05-19 16:31 ` Madis Janson
2011-05-19 16:33 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®