* Re: [PATCH] tools build: use .s extension for preprocessed assembler code
2016-01-31 17:59 [PATCH] tools build: use .s extension for preprocessed assembler code Masahiro Yamada
@ 2016-03-01 5:31 ` Masahiro Yamada
2016-03-01 13:20 ` Arnaldo Carvalho de Melo
2016-03-01 13:06 ` Jiri Olsa
2016-03-05 8:18 ` [tip:perf/core] tools build: Use " tip-bot for Masahiro Yamada
2 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2016-03-01 5:31 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Masahiro Yamada, Aaro Koskinen, Adrian Hunter, Lukas Wunner,
Jiri Olsa, Linux Kernel Mailing List
Hi Arnaldo,
Do you have any comment on this patch?
(I hope I am addressing myself to a right person.
"git log --pretty=fuller tools/build/Makefile.build" showed that
several patches in this area had been applied by you.)
Thanks,
2016-02-01 2:59 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> The "man gcc" says .i extension represents the file is C source code
> that should not be preprocessed. Here, .s should be used.
>
> For clarification,
> .c ---(preprocess)---> .i
> .S ---(preprocess)---> .s
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> tools/build/Makefile.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 4a96473..ee566e8 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
> $(call rule_mkdir)
> $(call if_changed_dep,cc_i_c)
>
> -$(OUTPUT)%.i: %.S FORCE
> +$(OUTPUT)%.s: %.S FORCE
> $(call rule_mkdir)
> $(call if_changed_dep,cc_i_c)
>
> --
> 1.9.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools build: use .s extension for preprocessed assembler code
2016-03-01 5:31 ` Masahiro Yamada
@ 2016-03-01 13:20 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-03-01 13:20 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Aaro Koskinen, Adrian Hunter, Lukas Wunner, Jiri Olsa,
Linux Kernel Mailing List
Em Tue, Mar 01, 2016 at 02:31:10PM +0900, Masahiro Yamada escreveu:
> Hi Arnaldo,
>
> Do you have any comment on this patch?
Sorry for the delay, I saw this patch, found no problems with it but was
waiting for Jiri's Ack, which he provided today, applying, thanks.
- Arnaldo
> (I hope I am addressing myself to a right person.
> "git log --pretty=fuller tools/build/Makefile.build" showed that
> several patches in this area had been applied by you.)
>
>
> Thanks,
>
>
> 2016-02-01 2:59 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > The "man gcc" says .i extension represents the file is C source code
> > that should not be preprocessed. Here, .s should be used.
> >
> > For clarification,
> > .c ---(preprocess)---> .i
> > .S ---(preprocess)---> .s
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > tools/build/Makefile.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> > index 4a96473..ee566e8 100644
> > --- a/tools/build/Makefile.build
> > +++ b/tools/build/Makefile.build
> > @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
> > $(call rule_mkdir)
> > $(call if_changed_dep,cc_i_c)
> >
> > -$(OUTPUT)%.i: %.S FORCE
> > +$(OUTPUT)%.s: %.S FORCE
> > $(call rule_mkdir)
> > $(call if_changed_dep,cc_i_c)
> >
> > --
> > 1.9.1
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools build: use .s extension for preprocessed assembler code
2016-01-31 17:59 [PATCH] tools build: use .s extension for preprocessed assembler code Masahiro Yamada
2016-03-01 5:31 ` Masahiro Yamada
@ 2016-03-01 13:06 ` Jiri Olsa
2016-03-05 8:18 ` [tip:perf/core] tools build: Use " tip-bot for Masahiro Yamada
2 siblings, 0 replies; 5+ messages in thread
From: Jiri Olsa @ 2016-03-01 13:06 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kernel, Aaro Koskinen, Adrian Hunter, Lukas Wunner,
Jiri Olsa, Arnaldo Carvalho de Melo
On Mon, Feb 01, 2016 at 02:59:00AM +0900, Masahiro Yamada wrote:
> The "man gcc" says .i extension represents the file is C source code
> that should not be preprocessed. Here, .s should be used.
>
> For clarification,
> .c ---(preprocess)---> .i
> .S ---(preprocess)---> .s
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> tools/build/Makefile.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 4a96473..ee566e8 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
> $(call rule_mkdir)
> $(call if_changed_dep,cc_i_c)
>
> -$(OUTPUT)%.i: %.S FORCE
> +$(OUTPUT)%.s: %.S FORCE
> $(call rule_mkdir)
> $(call if_changed_dep,cc_i_c)
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/core] tools build: Use .s extension for preprocessed assembler code
2016-01-31 17:59 [PATCH] tools build: use .s extension for preprocessed assembler code Masahiro Yamada
2016-03-01 5:31 ` Masahiro Yamada
2016-03-01 13:06 ` Jiri Olsa
@ 2016-03-05 8:18 ` tip-bot for Masahiro Yamada
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Masahiro Yamada @ 2016-03-05 8:18 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, mingo, yamada.masahiro, jolsa, adrian.hunter, acme,
linux-kernel, lukas, aaro.koskinen, tglx
Commit-ID: 676787939ef8ccfcf8039104f766ebe5ebe23924
Gitweb: http://git.kernel.org/tip/676787939ef8ccfcf8039104f766ebe5ebe23924
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
AuthorDate: Mon, 1 Feb 2016 02:59:00 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 3 Mar 2016 11:10:37 -0300
tools build: Use .s extension for preprocessed assembler code
The "man gcc" says .i extension represents the file is C source code
that should not be preprocessed. Here, .s should be used.
For clarification,
.c ---(preprocess)---> .i
.S ---(preprocess)---> .s
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Lukas Wunner <lukas@wunner.de>
Link: http://lkml.kernel.org/r/1454263140-19670-1-git-send-email-yamada.masahiro@socionext.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/build/Makefile.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
index 4a96473..ee566e8 100644
--- a/tools/build/Makefile.build
+++ b/tools/build/Makefile.build
@@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
$(call rule_mkdir)
$(call if_changed_dep,cc_i_c)
-$(OUTPUT)%.i: %.S FORCE
+$(OUTPUT)%.s: %.S FORCE
$(call rule_mkdir)
$(call if_changed_dep,cc_i_c)
^ permalink raw reply [flat|nested] 5+ messages in thread