[PATCH] scsi: qedf: Remove unesseary function call

[PATCH] scsi: qedf: Remove unesseary function call

[Jesse Taube]

The result of `skb_transport_header` was unused. Calling this function
warned when `skb_transport_header_was_set` returned false causing a
panic on debug kernels.

Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
---
 drivers/scsi/qedf/qedf_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index da429b3a4283..f2bc0ac684e0 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
 
 	/* Pull the header */
 	hp = (struct fcoe_hdr *)skb->data;
-	fh = (struct fc_frame_header *) skb_transport_header(skb);
 	skb_pull(skb, sizeof(struct fcoe_hdr));
 	fr_len = skb->len - sizeof(struct fcoe_crc_eof);
 
-- 
2.56.0

Re: [PATCH] scsi: qedf: Remove unesseary function call

[Laurence Oberman]

On Thu, 2026-10-29 at 12:04 -0400, Jesse Taube wrote:
> The result of `skb_transport_header` was unused. Calling this
> function
> warned when `skb_transport_header_was_set` returned false causing a
> panic on debug kernels.
> 
> Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
> ---
>  drivers/scsi/qedf/qedf_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c
> b/drivers/scsi/qedf/qedf_main.c
> index da429b3a4283..f2bc0ac684e0 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx
> *qedf,
>  
>  	/* Pull the header */
>  	hp = (struct fcoe_hdr *)skb->data;
> -	fh = (struct fc_frame_header *) skb_transport_header(skb);
>  	skb_pull(skb, sizeof(struct fcoe_hdr));
>  	fr_len = skb->len - sizeof(struct fcoe_crc_eof);
>  

Looks good
Reviewed-by: Laurence Oberman <loberman@redhat.com>

Re: [PATCH] scsi: qedf: Remove unesseary function call

[John Meneghini]

Reviewed-by: John Meneghini <jmeneghi@redhat.com>

Nilesh or Manish now that you are on the MAINTAINERS list for this file, can we get an ACK from you?

I really want Martin to merge this so we can move forward with some of these bugs, and he needs your ACK.

Thanks,

/John

On 10/29/26 12:04, Jesse Taube wrote:
> The result of `skb_transport_header` was unused. Calling this function
> warned when `skb_transport_header_was_set` returned false causing a
> panic on debug kernels.
> 
> Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
> ---
>   drivers/scsi/qedf/qedf_main.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index da429b3a4283..f2bc0ac684e0 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
>   
>   	/* Pull the header */
>   	hp = (struct fcoe_hdr *)skb->data;
> -	fh = (struct fc_frame_header *) skb_transport_header(skb);
>   	skb_pull(skb, sizeof(struct fcoe_hdr));
>   	fr_len = skb->len - sizeof(struct fcoe_crc_eof);
>   

RE: [EXTERNAL] [PATCH] scsi: qedf: Remove unesseary function call

[Nilesh Javali]

Jesse,


From: Jesse Taube <jtaubepe@redhat.com> 
Sent: Thursday, October 29, 2026 9:35 PM
To: Martin K. Petersen <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; James E.J. Bottomley <James.Bottomley@HansenPartnership.com>; Nimal Prabudoss I <nprabudo@redhat.com>; jmeneghi@redhat.com; Nilesh Javali <njavali@marvell.com>; Manish Rangankar <mrangankar@marvell.com>; GR-ETH-Storage-Upstream <GR-ETH-Storage-Upstream@marvell.com>; Jesse Taube <jtaubepe@redhat.com>
Subject: [EXTERNAL] [PATCH] scsi: qedf: Remove unesseary function call

The result of `skb_transport_header` was unused. Calling this function warned when `skb_transport_header_was_set` returned false causing a panic on debug kernels. Signed-off-by: Jesse Taube <jtaubepe@ redhat. com> --- drivers/scsi/qedf/qedf_main. c
ZjQcmQRYFpfptBannerStart
Prioritize security for external emails: 
Confirm sender and content safety before clicking links or opening attachments 
  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!tY3Z1f8UYlXatS-ced3a7ljFdyuZqiShD8U84cQDrie6xfl-Cea4s-00pRZgkOAcEQxp3FPrt-DlvgUuwE4NK53b1Rpl$  ‌ 


ZjQcmQRYFpfptBannerEnd
The result of `skb_transport_header` was unused. Calling this function
warned when `skb_transport_header_was_set` returned false causing a
panic on debug kernels.

Signed-off-by: Jesse Taube <mailto:jtaubepe@redhat.com>
---
 drivers/scsi/qedf/qedf_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index da429b3a4283..f2bc0ac684e0 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
 
 	/* Pull the header */
 	hp = (struct fcoe_hdr *)skb->data;
-	fh = (struct fc_frame_header *) skb_transport_header(skb);
 	skb_pull(skb, sizeof(struct fcoe_hdr));
 	fr_len = skb->len - sizeof(struct fcoe_crc_eof);
 
-- 
2.56.0

Thanks for the patch.
Reviewed-by: Nilesh Javali <njavali@marvell.com>

Re: [PATCH] scsi: qedf: Remove unesseary function call

[Martin K. Petersen]

Jesse,

> The result of `skb_transport_header` was unused. Calling this function
> warned when `skb_transport_header_was_set` returned false causing a
> panic on debug kernels.

Applied to 7.5/scsi-staging, thanks!

-- 
Martin K. Petersen