Re: [PATCH 1/7] dt-bindings: clock: Add Amlogic S7 SCMI clock IDs

From: Conor Dooley <conor@kernel.org>
To: Carlo Caione <ccaione@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Jian Hu <jian.hu@amlogic.com>, Chuan Liu <chuan.liu@amlogic.com>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] dt-bindings: clock: Add Amlogic S7 SCMI clock IDs
Date: Sun, 8 Nov 2026 23:21:08 +0000	[thread overview]
Message-ID: <20261108-computer-backed-d98862794d18@spud> (raw)
In-Reply-To: <20261106-upstream-s7-clk-v1-1-7d501d62621f@baylibre.com>

[-- Attachment #1.1: Type: text/plain, Size: 2044 bytes --]

On Fri, Nov 06, 2026 at 09:30:24AM +0100, Carlo Caione wrote:
> The S7 firmware exposes clocks through SCMI, including sources needed
> by the other clock controllers.
> 
> Define their identifiers so devicetree can reference these
> firmware-provided clocks.

Are SCMI clock IDs actually suitable for being bindings? Can't the IDs
vary here between versions of the firmware?
They're also not a "made up" set of indexes, like traditional clocks
are, they're real numbers that come from some document akin to
interrupts that we do not have bindings for and no driver is likely to
reference these definitions either right?

Is something like this not more suitable for being included as a header
in the amlogic dts directory?

> 
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
>  include/dt-bindings/clock/amlogic,s7-scmi-clkc.h | 27 ++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/include/dt-bindings/clock/amlogic,s7-scmi-clkc.h b/include/dt-bindings/clock/amlogic,s7-scmi-clkc.h
> new file mode 100644
> index 000000000000..10d7caa5d1e2
> --- /dev/null
> +++ b/include/dt-bindings/clock/amlogic,s7-scmi-clkc.h
> @@ -0,0 +1,27 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2026 BayLibre, SAS.
> + */
> +
> +#ifndef __AMLOGIC_S7_SCMI_CLKC_H
> +#define __AMLOGIC_S7_SCMI_CLKC_H
> +
> +#define CLKID_DDR_PHY_OSC			0
> +#define CLKID_USB1_PLL_OSC			1
> +#define CLKID_TOP_PLL_OSC			2
> +#define CLKID_HDMI_PLL_OSC			3
> +#define CLKID_USB0_PHY_PLL_OSC			4
> +#define CLKID_USB1_PHY_PLL_OSC			5
> +#define CLKID_USB0_PLL_OSC			6
> +#define CLKID_ETH_PLL_OSC			7
> +#define CLKID_ADC_PLL_OSC			8
> +#define CLKID_CPU_CLK				9
> +#define CLKID_DSU_CLK				10
> +#define CLKID_GP1_PLL				11
> +#define CLKID_ACLKM				12
> +#define CLKID_PWM_G				13
> +#define CLKID_PWM_H				14
> +#define CLKID_PWM_I				15
> +#define CLKID_PWM_J				16
> +
> +#endif /* __AMLOGIC_S7_SCMI_CLKC_H */
> 
> -- 
> 2.56.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic