[PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[Kathiravan Thirumoorthy]

Now that Linux has the consumer for the GPLL4, drop the
CLK_INGORE_UNUSED flag.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 drivers/clk/qcom/gcc-ipq5424.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/clk/qcom/gcc-ipq5424.c b/drivers/clk/qcom/gcc-ipq5424.c
index 35af6ffeeb85..3ddd4b3aedea 100644
--- a/drivers/clk/qcom/gcc-ipq5424.c
+++ b/drivers/clk/qcom/gcc-ipq5424.c
@@ -139,17 +139,6 @@ static struct clk_alpha_pll gpll4 = {
 			.parent_data = &gcc_parent_data_xo,
 			.num_parents = 1,
 			.ops = &clk_alpha_pll_ops,
-			/*
-			 * There are no consumers for this GPLL in kernel yet,
-			 * (will be added soon), so the clock framework
-			 * disables this source. But some of the clocks
-			 * initialized by boot loaders uses this source. So we
-			 * need to keep this clock ON. Add the
-			 * CLK_IGNORE_UNUSED flag so the clock will not be
-			 * disabled. Once the consumer in kernel is added, we
-			 * can get rid of this flag.
-			 */
-			.flags = CLK_IGNORE_UNUSED,
 		},
 	},
 };

---
base-commit: c1ecb239fa3456529a32255359fc78b69eb9d847
change-id: 20260525-ipq5424_drop_clk_ignore_unused-90bf48733c6e

Best regards,
--  
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[Dmitry Baryshkov]

On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy wrote:
> Now that Linux has the consumer for the GPLL4, drop the

what is the consumer? When was it added?

> CLK_INGORE_UNUSED flag.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/gcc-ipq5424.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-ipq5424.c b/drivers/clk/qcom/gcc-ipq5424.c
> index 35af6ffeeb85..3ddd4b3aedea 100644
> --- a/drivers/clk/qcom/gcc-ipq5424.c
> +++ b/drivers/clk/qcom/gcc-ipq5424.c
> @@ -139,17 +139,6 @@ static struct clk_alpha_pll gpll4 = {
>  			.parent_data = &gcc_parent_data_xo,
>  			.num_parents = 1,
>  			.ops = &clk_alpha_pll_ops,
> -			/*
> -			 * There are no consumers for this GPLL in kernel yet,
> -			 * (will be added soon), so the clock framework
> -			 * disables this source. But some of the clocks
> -			 * initialized by boot loaders uses this source. So we
> -			 * need to keep this clock ON. Add the
> -			 * CLK_IGNORE_UNUSED flag so the clock will not be
> -			 * disabled. Once the consumer in kernel is added, we
> -			 * can get rid of this flag.
> -			 */
> -			.flags = CLK_IGNORE_UNUSED,
>  		},
>  	},
>  };
> 
> ---
> base-commit: c1ecb239fa3456529a32255359fc78b69eb9d847
> change-id: 20260525-ipq5424_drop_clk_ignore_unused-90bf48733c6e
> 
> Best regards,
> --  
> Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> 

-- 
With best wishes
Dmitry

Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[Kathiravan Thirumoorthy]

On 5/25/2026 3:39 PM, Dmitry Baryshkov wrote:
> On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy wrote:
>> Now that Linux has the consumer for the GPLL4, drop the
> what is the consumer? When was it added?

PCIe and USB are the major consumers, which got added with the below 
commits and landed in v6.16 and v6.14 respectively.

ab7f31a3830d ("arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller 
nodes")

113d52bdc820 ("arm64: dts: qcom: ipq5424: Add USB controller and phy nodes")

While I was revisiting the code found that this flag is not removed. 
Hence I sent this.

Shall I reword the commit message as below for the next spin?

--

Since PCIe and USB are enabled and consume GPLL4, there is no need to
keep the CLK_IGNORE_UNUSED flag. Drop it.

--

>
>> CLK_INGORE_UNUSED flag.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>>   drivers/clk/qcom/gcc-ipq5424.c | 11 -----------
>>   1 file changed, 11 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/gcc-ipq5424.c b/drivers/clk/qcom/gcc-ipq5424.c
>> index 35af6ffeeb85..3ddd4b3aedea 100644
>> --- a/drivers/clk/qcom/gcc-ipq5424.c
>> +++ b/drivers/clk/qcom/gcc-ipq5424.c
>> @@ -139,17 +139,6 @@ static struct clk_alpha_pll gpll4 = {
>>   			.parent_data = &gcc_parent_data_xo,
>>   			.num_parents = 1,
>>   			.ops = &clk_alpha_pll_ops,
>> -			/*
>> -			 * There are no consumers for this GPLL in kernel yet,
>> -			 * (will be added soon), so the clock framework
>> -			 * disables this source. But some of the clocks
>> -			 * initialized by boot loaders uses this source. So we
>> -			 * need to keep this clock ON. Add the
>> -			 * CLK_IGNORE_UNUSED flag so the clock will not be
>> -			 * disabled. Once the consumer in kernel is added, we
>> -			 * can get rid of this flag.
>> -			 */
>> -			.flags = CLK_IGNORE_UNUSED,
>>   		},
>>   	},
>>   };
>>
>> ---
>> base-commit: c1ecb239fa3456529a32255359fc78b69eb9d847
>> change-id: 20260525-ipq5424_drop_clk_ignore_unused-90bf48733c6e
>>
>> Best regards,
>> --
>> Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>>

Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[Dmitry Baryshkov]

On Mon, May 25, 2026 at 08:35:16PM +0530, Kathiravan Thirumoorthy wrote:
> 
> On 5/25/2026 3:39 PM, Dmitry Baryshkov wrote:
> > On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy wrote:
> > > Now that Linux has the consumer for the GPLL4, drop the
> > what is the consumer? When was it added?
> 
> PCIe and USB are the major consumers, which got added with the below commits
> and landed in v6.16 and v6.14 respectively.
> 
> ab7f31a3830d ("arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller
> nodes")
> 
> 113d52bdc820 ("arm64: dts: qcom: ipq5424: Add USB controller and phy nodes")
> 
> While I was revisiting the code found that this flag is not removed. Hence I
> sent this.
> 
> Shall I reword the commit message as below for the next spin?
> 
> --
> 
> Since PCIe and USB are enabled and consume GPLL4, there is no need to
> keep the CLK_IGNORE_UNUSED flag. Drop it.

Yes, it would be perfect. BTW: what happens if both are disabled (or not
probed at the boot time)?


-- 
With best wishes
Dmitry

Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[Kathiravan Thirumoorthy]

On 5/25/2026 8:55 PM, Dmitry Baryshkov wrote:
> On Mon, May 25, 2026 at 08:35:16PM +0530, Kathiravan Thirumoorthy wrote:
>> On 5/25/2026 3:39 PM, Dmitry Baryshkov wrote:
>>> On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy wrote:
>>>> Now that Linux has the consumer for the GPLL4, drop the
>>> what is the consumer? When was it added?
>> PCIe and USB are the major consumers, which got added with the below commits
>> and landed in v6.16 and v6.14 respectively.
>>
>> ab7f31a3830d ("arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller
>> nodes")
>>
>> 113d52bdc820 ("arm64: dts: qcom: ipq5424: Add USB controller and phy nodes")
>>
>> While I was revisiting the code found that this flag is not removed. Hence I
>> sent this.
>>
>> Shall I reword the commit message as below for the next spin?
>>
>> --
>>
>> Since PCIe and USB are enabled and consume GPLL4, there is no need to
>> keep the CLK_IGNORE_UNUSED flag. Drop it.
> Yes, it would be perfect. BTW: what happens if both are disabled (or not
> probed at the boot time)?

Until all the drivers probed, icc_sync_state() will not disable the ICC 
clocks which will in turn keep GPLL4 in ON state. If we disable the 
nodes, then system will go for the reboot without much information.

>
>

Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[Kathiravan Thirumoorthy]

On 5/25/2026 10:49 PM, Kathiravan Thirumoorthy wrote:
>
> On 5/25/2026 8:55 PM, Dmitry Baryshkov wrote:
>> On Mon, May 25, 2026 at 08:35:16PM +0530, Kathiravan Thirumoorthy wrote:
>>> On 5/25/2026 3:39 PM, Dmitry Baryshkov wrote:
>>>> On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy 
>>>> wrote:
>>>>> Now that Linux has the consumer for the GPLL4, drop the
>>>> what is the consumer? When was it added?
>>> PCIe and USB are the major consumers, which got added with the below 
>>> commits
>>> and landed in v6.16 and v6.14 respectively.
>>>
>>> ab7f31a3830d ("arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller
>>> nodes")
>>>
>>> 113d52bdc820 ("arm64: dts: qcom: ipq5424: Add USB controller and phy 
>>> nodes")
>>>
>>> While I was revisiting the code found that this flag is not removed. 
>>> Hence I
>>> sent this.
>>>
>>> Shall I reword the commit message as below for the next spin?
>>>
>>> -- 
>>>
>>> Since PCIe and USB are enabled and consume GPLL4, there is no need to
>>> keep the CLK_IGNORE_UNUSED flag. Drop it.
>> Yes, it would be perfect. BTW: what happens if both are disabled (or not
>> probed at the boot time)?
>
> Until all the drivers probed, icc_sync_state() will not disable the 
> ICC clocks which will in turn keep GPLL4 in ON state. If we disable 
> the nodes, then system will go for the reboot without much information.

Dmitry, Do you have any further comments? Will that be okay if I can 
send the V2 with updated commit message?