* [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller
@ 2017-02-23 8:32 Claudiu Beznea
2017-02-23 8:42 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Claudiu Beznea @ 2017-02-23 8:32 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni, boris.brezillon, robh+dt,
pawel.moll, mark.rutland, ijc+devicetree, galak,
ludovic.desroches, cyrille.pitchen
Cc: linux-arm-kernel, devicetree, linux-kernel, Claudiu Beznea
Add pwm controller bindings for sam5d2_xplained
and enable it.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
index 9fc270f..493ea29 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
@@ -318,6 +318,10 @@
};
};
+ pwm0: pwm@f802c000 {
+ status = "okay";
+ };
+
flx0: flexcom@f8034000 {
atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index cd459e8..e88785e 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -1098,6 +1098,14 @@
status = "disabled";
};
+ pwm0: pwm@f802c000 {
+ compatible = "atmel,sama5d2-pwm";
+ reg = <0xf802c000 0x4000>;
+ interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
+ #pwm-cells = <3>;
+ clocks = <&pwm_clk>;
+ };
+
sfr: sfr@f8030000 {
compatible = "atmel,sama5d2-sfr", "syscon";
reg = <0xf8030000 0x98>;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller
2017-02-23 8:32 [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller Claudiu Beznea
@ 2017-02-23 8:42 ` Alexandre Belloni
2017-02-23 8:43 ` m18063
2017-03-28 11:04 ` m18063
0 siblings, 2 replies; 5+ messages in thread
From: Alexandre Belloni @ 2017-02-23 8:42 UTC (permalink / raw)
To: Claudiu Beznea
Cc: nicolas.ferre, boris.brezillon, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, ludovic.desroches,
cyrille.pitchen, linux-arm-kernel, devicetree, linux-kernel
Hi,
There is a typo in your subject, please fix.
On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote:
> Add pwm controller bindings for sam5d2_xplained
> and enable it.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
> arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> index 9fc270f..493ea29 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> @@ -318,6 +318,10 @@
> };
> };
>
> + pwm0: pwm@f802c000 {
> + status = "okay";
> + };
> +
> flx0: flexcom@f8034000 {
> atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
> status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index cd459e8..e88785e 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1098,6 +1098,14 @@
> status = "disabled";
> };
>
> + pwm0: pwm@f802c000 {
> + compatible = "atmel,sama5d2-pwm";
This compatible is not documented and is not used in any driver. Is that
really working?
> + reg = <0xf802c000 0x4000>;
> + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
> + #pwm-cells = <3>;
> + clocks = <&pwm_clk>;
> + };
> +
> sfr: sfr@f8030000 {
> compatible = "atmel,sama5d2-sfr", "syscon";
> reg = <0xf8030000 0x98>;
> --
> 2.7.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller
2017-02-23 8:42 ` Alexandre Belloni
@ 2017-02-23 8:43 ` m18063
2017-03-28 11:04 ` m18063
1 sibling, 0 replies; 5+ messages in thread
From: m18063 @ 2017-02-23 8:43 UTC (permalink / raw)
To: Alexandre Belloni
Cc: nicolas.ferre, boris.brezillon, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, ludovic.desroches,
cyrille.pitchen, linux-arm-kernel, devicetree, linux-kernel
Hi,
I will correct it asap.
Thank you,
Claudiu Beznea
On 23.02.2017 10:42, Alexandre Belloni wrote:
> Hi,
>
> There is a typo in your subject, please fix.
>
> On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote:
>> Add pwm controller bindings for sam5d2_xplained
>> and enable it.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
>> arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++
>> 2 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> index 9fc270f..493ea29 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> @@ -318,6 +318,10 @@
>> };
>> };
>>
>> + pwm0: pwm@f802c000 {
>> + status = "okay";
>> + };
>> +
>> flx0: flexcom@f8034000 {
>> atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
>> status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
>> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
>> index cd459e8..e88785e 100644
>> --- a/arch/arm/boot/dts/sama5d2.dtsi
>> +++ b/arch/arm/boot/dts/sama5d2.dtsi
>> @@ -1098,6 +1098,14 @@
>> status = "disabled";
>> };
>>
>> + pwm0: pwm@f802c000 {
>> + compatible = "atmel,sama5d2-pwm";
> This compatible is not documented and is not used in any driver. Is that
> really working?
>
>> + reg = <0xf802c000 0x4000>;
>> + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
>> + #pwm-cells = <3>;
>> + clocks = <&pwm_clk>;
>> + };
>> +
>> sfr: sfr@f8030000 {
>> compatible = "atmel,sama5d2-sfr", "syscon";
>> reg = <0xf8030000 0x98>;
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller
2017-02-23 8:42 ` Alexandre Belloni
2017-02-23 8:43 ` m18063
@ 2017-03-28 11:04 ` m18063
2017-03-28 11:34 ` Alexandre Belloni
1 sibling, 1 reply; 5+ messages in thread
From: m18063 @ 2017-03-28 11:04 UTC (permalink / raw)
To: Alexandre Belloni
Cc: nicolas.ferre, boris.brezillon, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, ludovic.desroches,
cyrille.pitchen, linux-arm-kernel, devicetree, linux-kernel
Hi Alexandre,
Sorry for the late response, I am seeing just now your question bellow.
Thank you,
Claudiu Beznea
On 23.02.2017 10:42, Alexandre Belloni wrote:
> Hi,
>
> There is a typo in your subject, please fix.
>
> On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote:
>> Add pwm controller bindings for sam5d2_xplained
>> and enable it.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
>> arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++
>> 2 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> index 9fc270f..493ea29 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> @@ -318,6 +318,10 @@
>> };
>> };
>>
>> + pwm0: pwm@f802c000 {
>> + status = "okay";
>> + };
>> +
>> flx0: flexcom@f8034000 {
>> atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
>> status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
>> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
>> index cd459e8..e88785e 100644
>> --- a/arch/arm/boot/dts/sama5d2.dtsi
>> +++ b/arch/arm/boot/dts/sama5d2.dtsi
>> @@ -1098,6 +1098,14 @@
>> status = "disabled";
>> };
>>
>> + pwm0: pwm@f802c000 {
>> + compatible = "atmel,sama5d2-pwm";
> This compatible is not documented and is not used in any driver. Is that
> really working?
At the moment I send this patch another driver patch was send
to used this device tree bindings and also to document it.
Meanwhile you reviewed also that other patch.
Please let me know if you want to send again this DT patch since
I didn't yet receive any inputs its v2.
>
>> + reg = <0xf802c000 0x4000>;
>> + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
>> + #pwm-cells = <3>;
>> + clocks = <&pwm_clk>;
>> + };
>> +
>> sfr: sfr@f8030000 {
>> compatible = "atmel,sama5d2-sfr", "syscon";
>> reg = <0xf8030000 0x98>;
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller
2017-03-28 11:04 ` m18063
@ 2017-03-28 11:34 ` Alexandre Belloni
0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2017-03-28 11:34 UTC (permalink / raw)
To: m18063
Cc: nicolas.ferre, boris.brezillon, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, ludovic.desroches,
cyrille.pitchen, linux-arm-kernel, devicetree, linux-kernel
Hi,
On 28/03/2017 at 14:04:25 +0300, m18063 wrote:
> >> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> >> index cd459e8..e88785e 100644
> >> --- a/arch/arm/boot/dts/sama5d2.dtsi
> >> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> >> @@ -1098,6 +1098,14 @@
> >> status = "disabled";
> >> };
> >>
> >> + pwm0: pwm@f802c000 {
> >> + compatible = "atmel,sama5d2-pwm";
> > This compatible is not documented and is not used in any driver. Is that
> > really working?
>
> At the moment I send this patch another driver patch was send
> to used this device tree bindings and also to document it.
> Meanwhile you reviewed also that other patch.
>
Yes, I received that patch first, without the other ones. You should
have put everything in the same series.
> Please let me know if you want to send again this DT patch since
> I didn't yet receive any inputs its v2.
>
I'll take it once the pwm patch are taken by Thierry because it is not
useful as-is, unless you use:
compatible = "atmel,sama5d2-pwm", "atmel,sama5d3-pwm";
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-28 11:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-23 8:32 [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller Claudiu Beznea
2017-02-23 8:42 ` Alexandre Belloni
2017-02-23 8:43 ` m18063
2017-03-28 11:04 ` m18063
2017-03-28 11:34 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®