[Question] should we export set_suspend_voltage()?

[Question] should we export set_suspend_voltage()?

[Yi Zhang]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1183 bytes --]


Hi, Liam & Mark:


seems at present, the set_suspend_voltage() is designed to cover the suspend voltage handling from board level, when the system enters into the suspend;
but the behavior of my chip is as following:
a) there are two sets of registers to configure one regulator's voltage separately, one is for active mode, the other is for the low power mode, say, suspend-to-ram;
b) both of the sets have control bits independently;
c) once the low power mode is triggered, by external signal, for example, pull-down a gpio, the regulator switches to use the registers for low power mode;
d) the consumers have different requirements for the voltage in low power mode according to different scenario, IOW, we cannot assume a fix value when system boots up;

So 
do you think it's good to export the set_suspend_voltage()? to make it controllable by the regulator itself?
another method in my opinion is add a set of virtual-regulator for this usage?

could you please share your advice?

thanks very much;

--
Yi Zhangÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [Question] should we export set_suspend_voltage()?

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Fri, Feb 06, 2015 at 10:57:49AM +0800, Yi Zhang wrote:

Please fix your mailer to word wrap within paragraphs, your mail is very
difficult to read and reply to.

> do you think it's good to export the set_suspend_voltage()? to make it
> controllable by the regulator itself?  another method in my opinion is
> add a set of virtual-regulator for this usage?

> could you please share your advice?

There's been some discussion of this in the context of some Qualcomm
systems recently, search the archives for discussions especially with
Bjorn Andersson recently.  The basic idea was to mirror the existing
APIs but with an additional mode argument (and permisions) to allow
consumers to manipulate states other than the default state.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re:Re: [Question] should we export set_suspend_voltage()?

[Yi Zhang]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1165 bytes --]


At 2015-02-07 06:10:58, "Mark Brown" <broonie@kernel.org> wrote:
>On Fri, Feb 06, 2015 at 10:57:49AM +0800, Yi Zhang wrote:
>
>Please fix your mailer to word wrap within paragraphs, your mail is very
>difficult to read and reply to.
>

Thanks Mark for pointing this out;

>> do you think it's good to export the set_suspend_voltage()? to make it
>> controllable by the regulator itself?  another method in my opinion is
>> add a set of virtual-regulator for this usage?
>
>> could you please share your advice?
>
>There's been some discussion of this in the context of some Qualcomm
>systems recently, search the archives for discussions especially with
>Bjorn Andersson recently.  The basic idea was to mirror the existing
>APIs but with an additional mode argument (and permisions) to allow

>consumers to manipulate states other than the default state.

Thanks, I searched http://article.gmane.org/gmane.linux.ports.arm.msm/10606
if possible, could you please add me in that loop? thanks very much;

 ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥