mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kurz <gkurz@fr.ibm.com>
To: Oren Laadan <orenl@cs.columbia.edu>
Cc: Ingo Molnar <mingo@elte.hu>, Daniel Lezcano <dlezcano@fr.ibm.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	containers@lists.linux-foundation.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/2] Track in-kernel when we expect	checkpoint/restart to work
Date: Fri, 10 Oct 2008 18:34:49 +0200	[thread overview]
Message-ID: <1223656489.10017.33.camel@localhost.localdomain> (raw)
In-Reply-To: <48EF7211.2000303@cs.columbia.edu>

On Fri, 2008-10-10 at 11:17 -0400, Oren Laadan wrote:
> 
> Ingo Molnar wrote:
> > * Daniel Lezcano <dlezcano@fr.ibm.com> wrote:
> > 
> >>> By the way, why don't you introduce the reverse operation ?
> >> I think implementing the reverse operation will be a nightmare, IMHO 
> >> it is safe to say we deny checkpointing for the process life-cycle 
> >> either if the created resource was destroyed before we initiate the 
> >> checkpoint.
> > 
> > it's also a not too interesting case. The end goal is to just be able to 
> > checkpoint everything that matters - in the long run there simply wont 
> > be many places that are marked 'cannot checkpoint'.
> > 
> > So the ability to deny a checkpoint is a transitional feature - a 
> > flexible CR todo list in essence - but also needed for 
> > applications/users that want to rely on CR being a dependable facility.
> > 
> > It would be bad for most of the practical usecases of checkpointing to 
> > allow the checkpointing of an app, just to see it break on restore due 
> > to lost context.
> 
> Actually it need not wait for restore to fail - it can fail during the
> checkpoint, as soon as the unsupported feature is encountered.
> 

Of course, bad things must be spotted at checkpoint time ! :)

> Adding that flag of what you suggest will help make it more vocal and
> obvious that a feature isn't supported, even without the user actually
> trying to take a checkpoint. I  like that I idea.
> 

This flag is weak... testing it gives absolutly no hint whether the
checkpoint may succeed or not. As it is designed now, a user can only be
aware that checkpoint is *forever* denied. I agree that it's only useful
as a "flexible CR todo list".

In the long run, if there are still things that can prevent checkpoint
from being consistent, they will have to be checked at checkpoint time.

Greg.



  parent reply	other threads:[~2008-10-10 16:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-09 19:04 Dave Hansen
2008-10-09 19:04 ` [RFC][PATCH 2/2] first callers of process_deny_checkpoint() Dave Hansen
2008-10-09 19:43   ` Serge E. Hallyn
2008-10-09 20:54     ` Dave Hansen
2008-10-10  8:46       ` Ingo Molnar
2008-10-10 13:17         ` Rafael J. Wysocki
2008-10-10 14:54           ` Ingo Molnar
2008-10-10 19:53             ` Rafael J. Wysocki
2008-10-10 19:53               ` Ingo Molnar
2008-10-10 20:40                 ` Len Brown
2008-10-10 22:57                 ` Rafael J. Wysocki
2008-10-11 13:48         ` Pavel Machek
2008-10-11 15:00           ` Ingo Molnar
2008-10-10 10:27       ` Cedric Le Goater
2008-10-10  8:41   ` Daniel Lezcano
2008-10-10 10:17   ` Cedric Le Goater
2008-10-10 14:04     ` Serge E. Hallyn
2008-10-10 16:45       ` Greg Kurz
2008-10-10 17:13         ` Serge E. Hallyn
2008-10-10 17:28         ` Dave Hansen
2008-10-13  8:20           ` Greg Kurz
2008-10-10  8:20 ` [RFC][PATCH 1/2] Track in-kernel when we expect checkpoint/restart to work Greg Kurz
2008-10-10  8:37   ` Daniel Lezcano
2008-10-10  8:47     ` Greg Kurz
2008-10-10 10:11     ` Oren Laadan
2008-10-10 14:59     ` Ingo Molnar
2008-10-10 15:17       ` Oren Laadan
2008-10-10 15:28         ` Ingo Molnar
2008-10-10 16:34         ` Greg Kurz [this message]
2008-10-10 16:36           ` Dave Hansen
2008-10-10 20:57             ` Daniel Lezcano
2008-10-10 17:18           ` Chris Friesen
2008-10-13  8:18             ` Greg Kurz
2008-10-13 16:46               ` Serge E. Hallyn
2008-10-10 16:33     ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223656489.10017.33.camel@localhost.localdomain \
    --to=gkurz@fr.ibm.com \
    --cc=arnd@arndb.de \
    --cc=containers@lists.linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=dlezcano@fr.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=orenl@cs.columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome