mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Brian Gerst <brgerst@gmail.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, mingo@elte.hu
Subject: Re: [PATCH] x86-32: Allocate irq stacks seperate from percpu area
Date: Wed, 27 Oct 2010 18:07:48 +0200	[thread overview]
Message-ID: <1288195668.2709.167.camel@edumazet-laptop> (raw)
In-Reply-To: <4CC846D5.50106@kernel.org>

Le mercredi 27 octobre 2010 à 17:35 +0200, Tejun Heo a écrit :

> Hmmm, okay.  Can you please print out early_cpu_to_node() output for
> each cpu from arch/x86/kernel/setup_percpu.c::setup_per_cpu_areas()?
> BTW, some clarifications.
> 
> * In the pcpu-alloc debug message, the n of [n] might not necessarily
>   match the NUMA node.
> 
> * I was confused before.  If CPU distance reported by
>   early_cpu_to_node() is greater than LOCAL_DISTANCE (ie. NUMA
>   configuration), cpus will always belong to different [n].  What gets
>   adjusted is the size of each unit.
> 
> * No matter what, here, the end result is correct.  As there's no low
>   memory on node 1, it doesn't matter how the groups are organized in
>   the first chunk as long as embedding is used.  And for other chunks,
>   pages for each cpu are allocated separatedly w/ cpu_to_node() anyway
>   so NUMA affinity will be correct, again, regardless of the group
>   organization.
> 
> Thanks.
> 

Will do in a few moment, once I recover from frozen machine  :(
(See end of this mail)

Thanks !

By the way, booting with hashdist=1 to make alloc_large_system_hash()
use vmalloc() show that only pages from node 0 were used at boot.

# grep alloc_large /proc/vmallocinfo 
0xf7a01000-0xf7a82000  528384 alloc_large_system_hash+0x144/0x1d9 pages=128 vmalloc N0=128
0xf7a83000-0xf7ac4000  266240 alloc_large_system_hash+0x144/0x1d9 pages=64 vmalloc N0=64
0xf7b11000-0xf7b32000  135168 alloc_large_system_hash+0x144/0x1d9 pages=32 vmalloc N0=32
0xf7b33000-0xf7c34000 1052672 alloc_large_system_hash+0x144/0x1d9 pages=256 vmalloc N0=256
0xf7c39000-0xf7cba000  528384 alloc_large_system_hash+0x144/0x1d9 pages=128 vmalloc N0=128
0xf7cbb000-0xf7cc0000   20480 alloc_large_system_hash+0x144/0x1d9 pages=4 vmalloc N0=4
0xf7cc1000-0xf7cc6000   20480 alloc_large_system_hash+0x144/0x1d9 pages=4 vmalloc N0=4


So I tried following experiment :

# swapoff
# numactl --membind=0 swapon -a
# grep swap /proc/vmallocinfo 
0xf9bf3000-0xf9cf4000 1052672 sys_swapon+0x4aa/0xb24 pages=256 vmalloc N0=256
# swapoff -a
# numactl --membind=1 swapon -a

<<FREEZE>>



  reply	other threads:[~2010-10-27 16:07 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 22:41 [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues David Howells
2010-10-26  9:10 ` Tejun Heo
2010-10-26 10:22 ` David Howells
2010-10-26 12:14   ` Tejun Heo
2010-10-26 12:27     ` Tejun Heo
2010-10-26 12:45       ` [PATCH] x86, percpu: revert commit fe8e0c25 Tejun Heo
2010-10-26 13:25         ` Ingo Molnar
2010-10-26 13:34           ` Tejun Heo
2010-10-26 13:49             ` Brian Gerst
2010-10-26 15:08               ` Linus Torvalds
2010-10-27  5:43                 ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Brian Gerst
2010-10-27  6:07                   ` Eric Dumazet
2010-10-27  9:57                     ` Peter Zijlstra
2010-10-27 13:33                       ` Eric Dumazet
2010-10-27 13:42                         ` Tejun Heo
2010-10-27 13:57                           ` Eric Dumazet
2010-10-27 14:00                             ` Tejun Heo
2010-10-27 14:24                               ` Eric Dumazet
2010-10-27 14:39                                 ` Tejun Heo
2010-10-27 14:39                                 ` Eric Dumazet
2010-10-27 14:43                                   ` Tejun Heo
2010-10-27 15:21                                     ` Eric Dumazet
2010-10-27 15:35                                       ` Tejun Heo
2010-10-27 16:07                                         ` Eric Dumazet [this message]
2010-10-27 17:33                                           ` [PATCH] numa: fix slab_node(MPOL_BIND) Eric Dumazet
2010-10-28 15:59                                             ` Linus Torvalds
2010-10-28 16:27                                               ` Eric Dumazet
2010-10-28 16:45                                               ` Mel Gorman
2010-10-28 16:55                                               ` Christoph Lameter
2010-10-28 21:07                                                 ` Andrew Morton
2010-10-29 14:55                                                   ` Christoph Lameter
2010-10-27 20:55                                         ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Eric Dumazet
2010-10-28 12:01                                           ` Tejun Heo
2010-10-28 12:30                                             ` Eric Dumazet
2010-10-28 14:40                       ` [PATCH] x86-32: NUMA irq stacks allocations Eric Dumazet
2010-10-29  6:43                         ` [tip:x86/urgent] x86-32: Restore irq stacks NUMA-aware allocations tip-bot for Eric Dumazet
2010-10-29 18:32                           ` Peter Zijlstra
2010-10-29 20:09                             ` Cyrill Gorcunov
2010-10-29 20:28                             ` Cyrill Gorcunov
2010-10-29 20:53                               ` Eric Dumazet
2010-10-29 20:59                                 ` Cyrill Gorcunov
2010-10-29 20:58                               ` Eric Dumazet
2010-10-29 21:21                                 ` Cyrill Gorcunov
2010-10-27 15:19                   ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Linus Torvalds
2010-10-27 15:30                     ` Ingo Molnar
2010-10-27 15:33                       ` Ingo Molnar
2010-10-27 15:40                         ` Tejun Heo
2010-10-27 15:43                           ` Ingo Molnar
2010-10-27 16:03                   ` [tip:x86/urgent] " tip-bot for Brian Gerst
2010-10-27 16:04                   ` [tip:x86/urgent] percpu: Remove the multi-page alignment facility tip-bot for Ingo Molnar
2010-10-26 14:06         ` [RFC PATCH] percpu: always align percpu output section to PAGE_SIZE Tejun Heo
2011-03-24  6:46           ` [Uclinux-dist-devel] " Mike Frysinger
2011-03-24  8:25             ` Tejun Heo
2011-03-24  8:51               ` Tejun Heo
2011-03-24 13:46                 ` Mike Frysinger
2011-03-24 17:51                   ` Tejun Heo
2011-03-24  8:54           ` [PATCH UPDATED] " Tejun Heo
2010-10-26 14:50   ` [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues David Howells
2010-10-26 14:56     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288195668.2709.167.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®