From: tip-bot for Eric Dumazet <eric.dumazet@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
eric.dumazet@gmail.com, brgerst@gmail.com, peterz@infradead.org,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86-32: Restore irq stacks NUMA-aware allocations
Date: Fri, 29 Oct 2010 06:43:02 GMT [thread overview]
Message-ID: <tip-5c1eb08936693cd78c71164c8bea0b086ae72c67@git.kernel.org> (raw)
In-Reply-To: <1288276854.2649.607.camel@edumazet-laptop>
Commit-ID: 5c1eb08936693cd78c71164c8bea0b086ae72c67
Gitweb: http://git.kernel.org/tip/5c1eb08936693cd78c71164c8bea0b086ae72c67
Author: Eric Dumazet <eric.dumazet@gmail.com>
AuthorDate: Thu, 28 Oct 2010 16:40:54 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 29 Oct 2010 08:17:07 +0200
x86-32: Restore irq stacks NUMA-aware allocations
Commit 22d4cd4c4d ("Allocate irq stacks seperate from percpu
area") removed NUMA affinity of IRQ stacks as side-effect of
the fix.
Using alloc_pages_node() instead of __get_free_pages() is safe,
even if the target node has no available LOWMEM pages :
alloc_pages_node() fallbacks to another node.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Brian Gerst <brgerst@gmail.com>
Cc: tj@kernel.org
Cc: torvalds@linux-foundation.org
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1288276854.2649.607.camel@edumazet-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/irq_32.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c
index 64668db..96656f2 100644
--- a/arch/x86/kernel/irq_32.c
+++ b/arch/x86/kernel/irq_32.c
@@ -17,6 +17,7 @@
#include <linux/delay.h>
#include <linux/uaccess.h>
#include <linux/percpu.h>
+#include <linux/mm.h>
#include <asm/apic.h>
@@ -125,7 +126,9 @@ void __cpuinit irq_ctx_init(int cpu)
if (per_cpu(hardirq_ctx, cpu))
return;
- irqctx = (union irq_ctx *)__get_free_pages(THREAD_FLAGS, THREAD_ORDER);
+ irqctx = page_address(alloc_pages_node(cpu_to_node(cpu),
+ THREAD_FLAGS,
+ THREAD_ORDER));
irqctx->tinfo.task = NULL;
irqctx->tinfo.exec_domain = NULL;
irqctx->tinfo.cpu = cpu;
@@ -134,7 +137,9 @@ void __cpuinit irq_ctx_init(int cpu)
per_cpu(hardirq_ctx, cpu) = irqctx;
- irqctx = (union irq_ctx *)__get_free_pages(THREAD_FLAGS, THREAD_ORDER);
+ irqctx = page_address(alloc_pages_node(cpu_to_node(cpu),
+ THREAD_FLAGS,
+ THREAD_ORDER));
irqctx->tinfo.task = NULL;
irqctx->tinfo.exec_domain = NULL;
irqctx->tinfo.cpu = cpu;
next prev parent reply other threads:[~2010-10-29 6:43 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 22:41 [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues David Howells
2010-10-26 9:10 ` Tejun Heo
2010-10-26 10:22 ` David Howells
2010-10-26 12:14 ` Tejun Heo
2010-10-26 12:27 ` Tejun Heo
2010-10-26 12:45 ` [PATCH] x86, percpu: revert commit fe8e0c25 Tejun Heo
2010-10-26 13:25 ` Ingo Molnar
2010-10-26 13:34 ` Tejun Heo
2010-10-26 13:49 ` Brian Gerst
2010-10-26 15:08 ` Linus Torvalds
2010-10-27 5:43 ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Brian Gerst
2010-10-27 6:07 ` Eric Dumazet
2010-10-27 9:57 ` Peter Zijlstra
2010-10-27 13:33 ` Eric Dumazet
2010-10-27 13:42 ` Tejun Heo
2010-10-27 13:57 ` Eric Dumazet
2010-10-27 14:00 ` Tejun Heo
2010-10-27 14:24 ` Eric Dumazet
2010-10-27 14:39 ` Tejun Heo
2010-10-27 14:39 ` Eric Dumazet
2010-10-27 14:43 ` Tejun Heo
2010-10-27 15:21 ` Eric Dumazet
2010-10-27 15:35 ` Tejun Heo
2010-10-27 16:07 ` Eric Dumazet
2010-10-27 17:33 ` [PATCH] numa: fix slab_node(MPOL_BIND) Eric Dumazet
2010-10-28 15:59 ` Linus Torvalds
2010-10-28 16:27 ` Eric Dumazet
2010-10-28 16:45 ` Mel Gorman
2010-10-28 16:55 ` Christoph Lameter
2010-10-28 21:07 ` Andrew Morton
2010-10-29 14:55 ` Christoph Lameter
2010-10-27 20:55 ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Eric Dumazet
2010-10-28 12:01 ` Tejun Heo
2010-10-28 12:30 ` Eric Dumazet
2010-10-28 14:40 ` [PATCH] x86-32: NUMA irq stacks allocations Eric Dumazet
2010-10-29 6:43 ` tip-bot for Eric Dumazet [this message]
2010-10-29 18:32 ` [tip:x86/urgent] x86-32: Restore irq stacks NUMA-aware allocations Peter Zijlstra
2010-10-29 20:09 ` Cyrill Gorcunov
2010-10-29 20:28 ` Cyrill Gorcunov
2010-10-29 20:53 ` Eric Dumazet
2010-10-29 20:59 ` Cyrill Gorcunov
2010-10-29 20:58 ` Eric Dumazet
2010-10-29 21:21 ` Cyrill Gorcunov
2010-10-27 15:19 ` [PATCH] x86-32: Allocate irq stacks seperate from percpu area Linus Torvalds
2010-10-27 15:30 ` Ingo Molnar
2010-10-27 15:33 ` Ingo Molnar
2010-10-27 15:40 ` Tejun Heo
2010-10-27 15:43 ` Ingo Molnar
2010-10-27 16:03 ` [tip:x86/urgent] " tip-bot for Brian Gerst
2010-10-27 16:04 ` [tip:x86/urgent] percpu: Remove the multi-page alignment facility tip-bot for Ingo Molnar
2010-10-26 14:06 ` [RFC PATCH] percpu: always align percpu output section to PAGE_SIZE Tejun Heo
2011-03-24 6:46 ` [Uclinux-dist-devel] " Mike Frysinger
2011-03-24 8:25 ` Tejun Heo
2011-03-24 8:51 ` Tejun Heo
2011-03-24 13:46 ` Mike Frysinger
2011-03-24 17:51 ` Tejun Heo
2011-03-24 8:54 ` [PATCH UPDATED] " Tejun Heo
2010-10-26 14:50 ` [PATCH] MN10300: Fix the PERCPU() alignment to allow for workqueues David Howells
2010-10-26 14:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-5c1eb08936693cd78c71164c8bea0b086ae72c67@git.kernel.org \
--to=eric.dumazet@gmail.com \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome