Re: [PATCH v2] docs: submitting-patches: Clarify half-baked review tags

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1: Type: text/plain, Size: 922 bytes --]

On 05.11.26 16:53, Krzysztof Kozlowski wrote:
> Reviewing pieces of the patch while ignoring the main part of it, is
> much closer to Acknowledgment, thus Ack, and "Reviewed-by" credit should
> not be applicable.

I disagree with:

 >> Reviewing pieces of the patch while ignoring the main part of it, is
 >> much closer to Acknowledgment, thus Ack, and "Reviewed-by" credit should
 >> not be applicable.

And I agree with Andy's statement:

 >> TL;DR: As a reviewer for the piece in question I have done my part fully. It's
 >> not my issue that the piece is bundled into a single patch. We have options:
 >> 1) ask to split (and review as standalone piece);
 >> 2) add (partial) Rb with the pointers of what exactly has been reviewed;
 >> 3) ignore (silent agreement with the respective subsystem maintainer's opinion);
 >> 4) ...something I forgot?..
 >>
 >> (even partial) Rb != Ack.


Juergen

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]