mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2] docs: submitting-patches: Clarify half-baked review tags
Date: Thu, 5 Nov 2026 10:12:00 +0100	[thread overview]
Message-ID: <e1c7e287-ccc9-4705-bd72-e801ba203668@oss.qualcomm.com> (raw)
In-Reply-To: <auxHASG78dTviSz8@shikoro>

On 05/11/2026 10:06, Wolfram Sang wrote:
> 
>> Reviewed-by even with the "# subpart" still appears in person's credits
>> and reviewing entire patch of 700 lines of diff code (like Frank's SPI
>> patch) is not the same as 10 diff codes for one driver.
> 
> Yes, if you want to spoil that, you'd need to introduce
> 
> 	Partly-reviewed-by: ...
> 
> or something.

Ack is for that, no need for a new tag, quoting:

"Acked-by.... user may not have carried out a technical review of the
patch, yet they may be satisfied ..."

"Reviewed-by:, instead, indicates that *the patch* has been reviewed and
found acceptable according to the Reviewer's Statement:"

Note that there is little sense in reviewing - as in statement of
oversight credit review - pieces of patch in context I discuss here,
e.g. one big complex rework combined with updates of drivers. Who cares
about the drivers? The complex rework is important and should be
reviewed, but people skip bigger picture and put their stamp of approval.

Stamp of approval is Ack, no need to mix it with reviewer's statement of
oversight.

Best regards,
Krzysztof

  reply	other threads:[~2026-11-05  9:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  8:27 Krzysztof Kozlowski
2026-11-05  8:50 ` Wolfram Sang
2026-11-05  8:57   ` Krzysztof Kozlowski
2026-11-05  9:06     ` Wolfram Sang
2026-11-05  9:12       ` Krzysztof Kozlowski [this message]
2026-11-05  9:26         ` Andy Shevchenko
2026-11-05 10:59           ` Krzysztof Kozlowski
2026-11-05  9:28         ` Wolfram Sang
2026-11-05 11:03           ` Krzysztof Kozlowski
2026-11-05 11:19             ` Wolfram Sang
2026-11-05 11:53               ` Andy Shevchenko
2026-11-05 12:56                 ` Krzysztof Kozlowski
2026-11-05 14:14                   ` Andy Shevchenko
2026-11-05  9:29       ` Geert Uytterhoeven
2026-11-05  9:44         ` Wolfram Sang
2026-11-05  9:47           ` Andy Shevchenko
2026-11-05  9:19 ` Andy Shevchenko
2026-11-05  9:27   ` Krzysztof Kozlowski
2026-11-05  9:48     ` Andy Shevchenko
2026-11-05 10:55       ` Krzysztof Kozlowski
2026-11-05  9:30   ` Jürgen Groß
2026-11-05 15:33     ` Krzysztof Kozlowski
2026-11-05 15:44       ` Juergen Gross
2026-11-05 15:53         ` Krzysztof Kozlowski
2026-11-05 15:59           ` Jürgen Groß
2026-11-05 16:22             ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1c7e287-ccc9-4705-bd72-e801ba203668@oss.qualcomm.com \
    --to=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®